feat: shorten

Author: nva-sec

src/main/java/net/potato/tuff/Updater.java

@@ -1,106 +1,99 @@
 package net.potato.tuff;
 
-import com.google.gson.JsonObject;
-import com.google.gson.JsonParser;
+import com.google.gson.*;
 import org.bukkit.Bukkit;
 import org.bukkit.plugin.java.JavaPlugin;
 import org.bukkit.scheduler.BukkitRunnable;
-
-import java.io.File;
-import java.io.FileOutputStream;
-import java.io.InputStream;
-import java.io.InputStreamReader;
-import java.net.HttpURLConnection;
-import java.net.URL;
-import java.nio.channels.Channels;
-import java.nio.channels.ReadableByteChannel;
+import java.io.*;
+import java.net.*;
+import java.nio.channels.*;
 
 public class Updater {
 
-    private final JavaPlugin plugin;
-    private final String currentVersion;
+    private final JavaPlugin p;
+    private final String cv;
 
-    public Updater(JavaPlugin plugin) {
-        this.plugin = plugin;
-        this.currentVersion = plugin.getDescription().getVersion();
+    public Updater(JavaPlugin pl) {
+        p = pl;
+        cv = pl.getDescription().getVersion();
     }
 
     public void scheduleCheck() {
-        if (!plugin.getConfig().getBoolean("updater.enabled", true)) return;
-        long interval = plugin.getConfig().getLong("updater.check-interval-minutes", 60) * 60 * 20;
+        if (!p.getConfig().getBoolean("updater.enabled", true)) return;
+        long i = p.getConfig().getLong("updater.check-interval-minutes", 60) * 60 * 20;
         new BukkitRunnable() {
             @Override
             public void run() {
-                checkForUpdates();
+                cfu();
             }
-        }.runTaskTimerAsynchronously(plugin, 0L, interval);
+        }.runTaskTimerAsynchronously(p, 0L, i);
     }
 
-    private void checkForUpdates() {
-        String localLatestVersion = currentVersion;
+    private void cfu() {
+        String llv = cv;
 
-        String versionUrl = "https://verytuffautoupdater.netlify.app/version-remote.json";
+        String vu = "https://verytuffautoupdater.netlify.app/version-remote.json";
 
         try {
-            URL url = new URL(versionUrl);
-            HttpURLConnection connection = (HttpURLConnection) url.openConnection();
-            connection.setConnectTimeout(5000);
+            URL u = new URL(vu);
+            HttpURLConnection c = (HttpURLConnection) u.openConnection();
+            c.setConnectTimeout(5000);
 
-            if (connection.getResponseCode() == 200) {
-                InputStreamReader reader = new InputStreamReader(connection.getInputStream());
-                JsonObject versionInfo = JsonParser.parseReader(reader).getAsJsonObject();
-                reader.close();
+            if (c.getResponseCode() == 200) {
+                InputStreamReader r = new InputStreamReader(c.getInputStream());
+                JsonObject vi = new JsonParser().parse(r).getAsJsonObject();
+                r.close();
 
-                String webLatestVersion = versionInfo.get("latestVersion").getAsString();
+                String wlv = vi.get("latestVersion").getAsString();
 
-                if (isNewer(webLatestVersion, currentVersion)) {
-                    plugin.getLogger().info("A new version is available: " + webLatestVersion + "! Downloading...");
-                    String downloadUrl = versionInfo.get("downloadUrl").getAsString();
-                    downloadUpdate(downloadUrl);
+                if (in(wlv, cv)) {
+                    p.getLogger().info("A new version is available: " + wlv + "! Downloading...");
+                    String du = vi.get("downloadUrl").getAsString();
+                    du(du);
                 } else {
-                    plugin.getLogger().info("You are running the latest version (" + currentVersion + ").");
+                    p.getLogger().info("You are running the latest version (" + cv + ").");
                 }
             } else {
-                plugin.getLogger().warning("Could not check for updates. (Response code: " + connection.getResponseCode() + ")");
+                p.getLogger().warning("Could not check for updates. (Response code: " + c.getResponseCode() + ")");
             }
         } catch (Exception e) {
-            plugin.getLogger().warning("An error occurred while checking for updates: " + e.getMessage());
+            p.getLogger().warning("An error occurred while checking for updates: " + e.getMessage());
         }
     }
 
-    private boolean isNewer(String latest, String current) {
-        return !latest.trim().equalsIgnoreCase(current);
+    private boolean in(String l, String c) {
+        return !l.trim().equalsIgnoreCase(c);
     }
 
-    private void downloadUpdate(String url) {
+    private void du(String u) {
         try {
-            File updateFolder = plugin.getServer().getUpdateFolderFile();
-            if (!updateFolder.exists()) {
-                updateFolder.mkdirs();
+            File uf = p.getServer().getUpdateFolderFile();
+            if (!uf.exists()) {
+                uf.mkdirs();
             }
-            File downloadTarget = new File(updateFolder, plugin.getName() + ".jar");
+            File dt = new File(uf, p.getName() + ".jar");
 
-            URL downloadUrl = new URL(url);
-            ReadableByteChannel rbc = Channels.newChannel(downloadUrl.openStream());
-            FileOutputStream fos = new FileOutputStream(downloadTarget);
+            URL dl = new URL(u);
+            ReadableByteChannel rbc = Channels.newChannel(dl.openStream());
+            FileOutputStream fos = new FileOutputStream(dt);
             fos.getChannel().transferFrom(rbc, 0, Long.MAX_VALUE);
             fos.close();
             rbc.close();
 
-            plugin.getLogger().info("Successfully downloaded the new version to the 'update' folder.");
-            plugin.getLogger().info("The update will be applied on the next server restart.");
+            p.getLogger().info("Successfully downloaded the new version to the 'update' folder.");
+            p.getLogger().info("The update will be applied on the next server restart.");
 
-            if (plugin.getConfig().getBoolean("updater.restart-on-update", false)) {
-                plugin.getLogger().info("Restarting server to apply the update...");
+            if (p.getConfig().getBoolean("updater.restart-on-update", false)) {
+                p.getLogger().info("Restarting server to apply the update...");
                 new BukkitRunnable() {
                     @Override
                     public void run() {
                         Bukkit.dispatchCommand(Bukkit.getConsoleSender(), "restart");
                     }
-                }.runTask(plugin);
+                }.runTask(p);
             }
         } catch (Exception e) {
-            plugin.getLogger().severe("The update download failed: " + e.getMessage());
+            p.getLogger().severe("The update download failed: " + e.getMessage());
         }
     }
-}
+}