Skip to content

Commit f4bcde4

Browse files
committed
CLI summary label is clearer as overall
Right now the CLI summary reports its metrics as "Total". I assumed at first glace this meant sum of all the categories. Since that's what the "Total-time" metric is reporting. If the label was "Overall", I think this would be more obvious. The last "Total Time" is now "Overall Wall-Time" to be more consistent with the line items' equivalent report. I also reordered the line item "Total-time" to be before "Wall-Time" because I find that to be a slightly more intuitive order. Before this change: ``` Running 8bitbench-wasm: 8bitbench-wasm First-Score 23.66 pts 8bitbench-wasm Worst-Score 31.79 pts 8bitbench-wasm Average-Score 32.19 pts 8bitbench-wasm Score 28.93 pts 8bitbench-wasm First-Time 211.36 ms 8bitbench-wasm Worst-Time 157.26 ms 8bitbench-wasm Average-Time 155.35 ms 8bitbench-wasm Wall-Time 2390.92 ms 8bitbench-wasm Total-Time 523.97 ms Total: Total First-Score 164.07 pts Total Worst-Score 306.75 pts Total Average-Score 427.19 pts Total Stdlib-Score 13.10 pts Total MainRun-Score 2.89 pts Total First-Time 31.58 ms Total Worst-Time 16.97 ms Total Average-Time 12.16 ms Total Stdlib-Time 381.82 ms Total MainRun-Time 1732.12 ms Total Score 254.28 pts Total Time 93008.80 ms ``` After: ``` Running 8bitbench-wasm: 8bitbench-wasm First-Score 23.14 pts 8bitbench-wasm Worst-Score 31.58 pts 8bitbench-wasm Average-Score 32.05 pts 8bitbench-wasm Score 28.61 pts 8bitbench-wasm First-Time 216.06 ms 8bitbench-wasm Worst-Time 158.35 ms 8bitbench-wasm Average-Time 155.98 ms 8bitbench-wasm Total-Time 530.39 ms 8bitbench-wasm Wall-Time 2404.08 ms Overall: Overall First-Score 171.40 pts Overall Worst-Score 330.65 pts Overall Average-Score 444.21 pts Overall Stdlib-Score 16.04 pts Overall MainRun-Score 2.80 pts Overall First-Time 30.24 ms Overall Worst-Time 15.70 ms Overall Average-Time 11.68 ms Overall Stdlib-Time 311.64 ms Overall MainRun-Time 1785.38 ms Overall Score 268.03 pts Overall Wall-Time 87146.46 ms ```
1 parent 3db87be commit f4bcde4

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

JetStreamDriver.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -302,11 +302,11 @@ class Driver {
302302
}
303303
}
304304

305-
const totalScore = geomeanScore(allScores);
306-
console.assert(totalScore > 0, `Invalid total score: ${totalScore}`);
305+
const overallScore = geomeanScore(allScores);
306+
console.assert(overallScore > 0, `Invalid total score: ${overallScore}`);
307307

308308
if (isInBrowser) {
309-
let summaryHtml = `<div class="score">${uiFriendlyScore(totalScore)}</div>
309+
let summaryHtml = `<div class="score">${uiFriendlyScore(overallScore)}</div>
310310
<label>Score</label>`;
311311
summaryHtml += `<div class="benchmark benchmark-done">`;
312312
for (let [category, scores] of categoryScores) {
@@ -329,20 +329,20 @@ class Driver {
329329
summaryElement.onclick = displayCategoryScores;
330330
statusElement.innerHTML = "";
331331
} else if (!JetStreamParams.dumpJSONResults) {
332-
console.log("Total:");
332+
console.log("Overall:");
333333
for (let [category, scores] of categoryScores) {
334334
console.log(
335-
shellFriendlyLabel(`Total ${category}-Score`),
335+
shellFriendlyLabel(`Overall ${category}-Score`),
336336
shellFriendlyScore(geomeanScore(scores)));
337337
}
338338
for (let [category, times] of categoryTimes) {
339339
console.log(
340-
shellFriendlyLabel(`Total ${category}-Time`),
340+
shellFriendlyLabel(`Overall ${category}-Time`),
341341
shellFriendlyDuration(geomeanScore(times)));
342342
}
343343
console.log("");
344-
console.log(shellFriendlyLabel("Total Score"), shellFriendlyScore(totalScore));
345-
console.log(shellFriendlyLabel("Total Time"), shellFriendlyDuration(totalTime));
344+
console.log(shellFriendlyLabel("Overall Score"), shellFriendlyScore(overallScore));
345+
console.log(shellFriendlyLabel("Overall Wall-Time"), shellFriendlyDuration(totalTime));
346346
console.log("");
347347
}
348348

@@ -835,8 +835,8 @@ class Benchmark {
835835

836836
allTimes() {
837837
const allTimes = this.subTimes();
838-
allTimes["Wall"] = this.wallTime;
839838
allTimes["Total"] = this.totalTime;
839+
allTimes["Wall"] = this.wallTime;
840840
return allTimes;
841841
}
842842

0 commit comments

Comments
 (0)