Skip to content

Commit d0dc094

Browse files
committed
tslint: Enable no-null-keyword
I find this rule quite useful so that we use undefined all the time. The rationale on the rule's documentation page is quite clear: https://palantir.github.io/tslint/rules/no-null-keyword/
1 parent 1244e41 commit d0dc094

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

src/backend/mi2/mi2.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,7 @@ export class MI2 extends EventEmitter implements IBackend {
544544
this.breakpoints.set(newBrk, bkptNum);
545545
resolve([true, newBrk]);
546546
} else {
547-
resolve([false, null]);
547+
resolve([false, undefined]);
548548
}
549549
}, reject);
550550
}

src/mibase.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ export class MI2DebugSession extends DebugSession {
294294
this.miDebugger.getStack(args.levels, args.threadId).then(stack => {
295295
const ret: StackFrame[] = [];
296296
stack.forEach(element => {
297-
let source = null;
297+
let source = undefined;
298298
let file = element.file;
299299
if (file) {
300300
if (this.isSSH) {

tslint.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"defaultSeverity": "error",
33
"rules": {
44
"no-var-keyword": true,
5-
"prefer-const": true
5+
"prefer-const": true,
6+
"no-null-keyword": true
67
}
78
}

0 commit comments

Comments
 (0)