Optional set title to web content (#26)

* optional set title to web content

* Bumped version

* rubocop

* Specify content

* added title to add_url method example

* Remove post install message

Author: davidenko87

README.md

@@ -68,7 +68,7 @@ transfer = @client.create_transfer(name: "My wonderful transfer", description: "
   upload.add_file_at(path: '/path/to/local/file.jpg')
   upload.add_file_at(path: '/path/to/another/local/file.jpg')
   upload.add_file(name: 'README.txt', io: StringIO.new("This is the contents of the file"))
-  upload.add_web_content(url: "https://www.the.url.you.want.to.share.com"))
+  upload.add_web_url(url: "https://www.the.url.you.want.to.share.com", title: "title of the url"))
 end
 
 transfer.shortened_url => "https://we.tl/SSBsb3ZlIHJ1Ynk="

lib/we_transfer_client/transfer_builder.rb

@@ -16,8 +16,9 @@ def add_file_at(path:)
     add_file(name: File.basename(path), io: File.open(path, 'rb'))
   end
 
-  def add_web_content(url:)
-    @items << FutureWebItem.new(url: url, title: url)
+  def add_web_url(url:, title: nil)
+    title ||= url
+    @items << FutureWebItem.new(url: url, title: title)
     true
   end
 

lib/we_transfer_client/version.rb

@@ -1,3 +1,3 @@
 class WeTransferClient
-  VERSION = '0.4.1'
+  VERSION = '0.4.2'
 end

spec/integration_spec.rb

@@ -97,7 +97,7 @@ def broken.read(*)
     client = WeTransferClient.new(api_key: ENV.fetch('WT_API_KEY'), logger: test_logger)
     transfer = client.create_transfer(name: 'My collection of web content', description: 'link collection') do |builder|
       10.times do
-        builder.add_web_content(url: 'https://www.wetransfer.com')
+        builder.add_web_url(url: 'https://www.wetransfer.com')
       end
     end
     expect(transfer).to be_kind_of(RemoteTransfer)
@@ -135,7 +135,7 @@ def broken.read(*)
       expect(add_result).to eq(true)
 
       # add url to transfer
-      add_result = builder.add_web_content(url: 'http://www.wetransfer.com')
+      add_result = builder.add_web_url(url: 'http://www.wetransfer.com', title: 'website used for file transfers')
       expect(add_result).to eq(true)
     end
 

spec/we_transfer_client/transfer_builder_spec.rb

@@ -29,12 +29,33 @@
 
   it 'should add a url' do
     transfer_builder = described_class.new
-    transfer_builder.add_web_content(url: 'https://www.wetransfer.com/')
+    transfer_builder.add_web_url(url: 'https://www.wetransfer.com/')
     expect(transfer_builder.items.count).to eq(1)
 
     item = transfer_builder.items.first
     expect(item.url).to eq('https://www.wetransfer.com/')
+    expect(item.local_identifier).to be_kind_of(String)
+  end
+
+  it 'should user url for the title when none is given' do
+    transfer_builder = described_class.new
+    transfer_builder.add_web_url(url: 'https://www.wetransfer.com/')
+    expect(transfer_builder.items.count).to eq(1)
+
+    item = transfer_builder.items.first
+
     expect(item.title).to eq('https://www.wetransfer.com/')
     expect(item.local_identifier).to be_kind_of(String)
   end
+
+  it 'should pass title as webcontent title' do
+    transfer_builder = described_class.new
+    transfer_builder.add_web_url(url: 'https://www.wetransfer.com/', title: 'awesome website for file transfering')
+    expect(transfer_builder.items.count).to eq(1)
+
+    item = transfer_builder.items.first
+    expect(item.url).to eq('https://www.wetransfer.com/')
+    expect(item.title).to eq('awesome website for file transfering')
+    expect(item.local_identifier).to be_kind_of(String)
+  end
 end

wetransfer.gemspec

@@ -27,11 +27,6 @@ Gem::Specification.new do |spec|
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
-  spec.post_install_message = %q{
-    Warning: We have changed the syntax for the create_transfer method.
-    create_transfer(title:, message:) is now create_transfer(name:, description:)
-    Please update your usage accordingly. Thank you and our apologies for the disruption.
-  }
 
   spec.add_dependency 'faraday', '~> 0.12'
   spec.add_dependency 'ks', '~> 0.0.1'