More focus in integration test

Author: arnoFleming

spec/features/client_creates_a_transfer_spec.rb

@@ -1,51 +1,45 @@
 require "spec_helper"
 
-describe "client creates a finalized transfer with 5 files" do
+describe "transfer integration" do
   around do |example|
     WebMock.allow_net_connect!
     example.run
     WebMock.disable_net_connect!
   end
 
-  it "works" do
+  it "Create a client, a transfer, it uploads files and finalizes the transfer" do
     client = WeTransfer::Client.new(api_key: ENV.fetch("WT_API_KEY"))
 
     client.create_transfer(message: "test transfer") do |transfer|
-      transfer.add_file(name: "test_file_1", size: 10)
-      transfer.add_file(name: "test_file_2", size: 10, io: StringIO.new("#" * 10))
-      # transfer.add_file(name: "test_file_3", size: 10)
-      # test_file_4 is a file of more than 1 chunk
-      transfer.add_file(name: "test_file_4", io: File.open('spec/fixtures/Japan-01.jpg'))
-      transfer.add_file(name: "test_file_5", io: File.open("Gemfile"))
+      transfer.add_file(name: "small_file", size: 80)
+      transfer.add_file(name: "small_file_with_io", size: 10, io: StringIO.new("#" * 10))
+      transfer.add_file(name: "multi_chunk_big_file", io: File.open('spec/fixtures/Japan-01.jpg'))
     end
 
     transfer = client.transfer
-    # these next expectations should check against state (that it is persisted, and the corresponding flag is truthy)
+
+    expect(transfer.url)
+      .to be_nil
+
     expect(transfer.id.nil?).to eq false
     expect(transfer.state).to eq "uploading"
     expect(transfer.files.none? { |f| f.id.nil? }).to eq true
 
-    transfer.upload_file(name: "test_file_1", io: StringIO.new("#" * 10))
-    transfer.complete_file(name: "test_file_1")
-
-    transfer.upload_file(name: "test_file_2")
-    transfer.complete_file(name: "test_file_2")
+    transfer.upload_file(name: "small_file", io: StringIO.new("#" * 80))
+    transfer.complete_file(name: "small_file")
 
-    # upload "test_file_3" using Faraday to express we aren't bound to using the SDK for uploading
-    # transfer.add_file(name: "test_file_3", size: 10)
+    transfer.upload_file(name: "small_file_with_io")
+    transfer.complete_file(name: "small_file_with_io")
 
-    transfer.upload_file(name: "test_file_4")
-    transfer.complete_file(name: "test_file_4")
+    transfer.upload_file(name: "multi_chunk_big_file")
+    transfer.complete_file(name: "multi_chunk_big_file")
 
-    transfer.upload_file(name: "test_file_5")
-    transfer.complete_file(name: "test_file_5")
+    transfer.finalize
 
     expect(transfer.state).to eq "processing"
 
-    transfer.finalize
-
-    # If the server on the other end is done, the transfer will become downloadable.
-    # But I don't feel like `sleep`ing
-    # expect(transfer.state).to eq "downloadable"
+    # Your transfer is available (after processing) at `transfer.url`
+    expect(transfer.url)
+      .to match %r|https://we.tl/t-|
   end
 end

spec/we_transfer/transfer_spec.rb

@@ -489,5 +489,7 @@
       transfer.finalize
       expect(transfer.state).to eq "processing"
     end
+
+    it "url?"
   end
 end