refactor!: Use List in CallInfoPage

Author: SMadani

CHANGELOG.md

@@ -29,6 +29,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 - Renamed `com.vonage.client.voice.Endpoint` to `CallEndpoint`
 - Renamed `com.vonage.client.voice.ncco.Endpoint` to `ConnectEndpoint`
 - Refactored `CallInfoPage` to be aligned with other HAL responses (now extends `HalPageResponse`)
+  - Now returns the embedded calls directly as a list rather than array
 - Added `get` prefix to `VideoStream` and `HlsSettings` accessors
 - `NumbersClient#listNumbers` now returns `List<OwnedNumber>` instead of `ListNumbersResponse`
 - `NumbersClient#linkNumber` now assigns the number to the application by ID

src/main/java/com/vonage/client/voice/CallInfoPage.java

@@ -17,10 +17,10 @@
 
 import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonProperty;
-import com.fasterxml.jackson.databind.util.ArrayIterator;
 import com.vonage.client.JsonableBaseObject;
 import com.vonage.client.common.HalPageResponse;
 import java.util.Iterator;
+import java.util.List;
 
 /**
  * Response from {@link VoiceClient#listCalls(CallsFilter)}.
@@ -31,7 +31,7 @@ public class CallInfoPage extends HalPageResponse implements Iterable<CallInfo>
     @JsonProperty("_embedded") private Embedded embedded;
 
     static class Embedded extends JsonableBaseObject {
-        @JsonProperty("calls") private CallInfo[] callInfos;
+        @JsonProperty("calls") private List<CallInfo> callInfos;
     }
 
     /**
@@ -62,17 +62,17 @@ public Integer getRecordIndex() {
     /**
      * Gets the call details.
      *
-     * @return The CallInfos from the embedded object as an array.
+     * @return The list of CallInfos from the embedded object.
      *
      * @since 9.0.0
      */
     @JsonIgnore
-    public CallInfo[] getCallInfos() {
+    public List<CallInfo> getCallInfos() {
         return embedded.callInfos;
     }
 
     @Override
     public Iterator<CallInfo> iterator() {
-        return new ArrayIterator<>(getCallInfos());
+        return getCallInfos().iterator();
     }
 }

src/test/java/com/vonage/client/voice/CallInfoPageTest.java

@@ -95,7 +95,7 @@ public void testBasics() {
         assertEquals("/v1/calls?page_size=10", links.getFirstUrl().toString());
         assertEquals("/v1/calls?page_size=10&record_index=20&order=asc", links.getSelfUrl().toString());
         assertEquals("/v1/calls/1452dad1b27b4e71a90fb18af2656948", links.getPrevUrl().toString());
-        assertEquals("447700900549", page.getCallInfos()[0].getTo().toLog());
+        assertEquals("447700900549", page.getCallInfos().getFirst().getTo().toLog());
         assertEquals(10, page.getPageSize());
         assertEquals(0, page.getRecordIndex());
     }