Pass scalac arguments as file (#2584)

* Add writing scalac arguments to file

* Add tests

Author: MaciejG604

build.sc

@@ -431,6 +431,8 @@ trait Core extends ScalaCliSbtModule with ScalaCliPublishModule with HasTests
          |  def workspaceDirName = "$workspaceDirName"
          |  def projectFileName = "$projectFileName"
          |  def jvmPropertiesFileName = "$jvmPropertiesFileName"
+         |  def scalacArgumentsFileName = "scalac.args.txt"
+         |  def maxScalacArgumentsCount = 5000
          |
          |  def defaultGraalVMJavaVersion = ${deps.graalVmJavaVersion}
          |  def defaultGraalVMVersion = "${deps.graalVmVersion}"

modules/build/src/main/scala/scala/build/Build.scala

@@ -472,8 +472,10 @@ object Build {
     }
   }
 
+  def projectRootDir(root: os.Path, projectName: String): os.Path =
+    root / Constants.workspaceDirName / projectName
   def classesRootDir(root: os.Path, projectName: String): os.Path =
-    root / Constants.workspaceDirName / projectName / "classes"
+    projectRootDir(root, projectName) / "classes"
   def classesDir(root: os.Path, projectName: String, scope: Scope, suffix: String = ""): os.Path =
     classesRootDir(root, projectName) / s"${scope.name}$suffix"
 
@@ -948,6 +950,8 @@ object Build {
 
     val project = Project(
       directory = inputs.workspace / Constants.workspaceDirName,
+      argsFilePath =
+        projectRootDir(inputs.workspace, inputs.projectName) / Constants.scalacArgumentsFileName,
       workspace = inputs.workspace,
       classesDir = classesDir0,
       scaladocDir = scaladocDir,
@@ -1026,14 +1030,24 @@ object Build {
 
       val projectChanged = compiler.prepareProject(project, logger)
 
-      if (compiler.usesClassDir && projectChanged && os.isDir(classesDir0)) {
-        logger.debug(s"Clearing $classesDir0")
-        os.list(classesDir0).foreach { p =>
-          logger.debug(s"Removing $p")
-          try os.remove.all(p)
+      if (projectChanged) {
+        if (compiler.usesClassDir && os.isDir(classesDir0)) {
+          logger.debug(s"Clearing $classesDir0")
+          os.list(classesDir0).foreach { p =>
+            logger.debug(s"Removing $p")
+            try os.remove.all(p)
+            catch {
+              case ex: FileSystemException =>
+                logger.debug(s"Ignoring $ex while cleaning up $p")
+            }
+          }
+        }
+        if (os.exists(project.argsFilePath)) {
+          logger.debug(s"Removing ${project.argsFilePath}")
+          try os.remove(project.argsFilePath)
           catch {
             case ex: FileSystemException =>
-              logger.debug(s"Ignoring $ex while cleaning up $p")
+              logger.debug(s"Ignoring $ex while cleaning up ${project.argsFilePath}")
           }
         }
       }
@@ -1073,18 +1087,6 @@ object Build {
       )
     }
 
-    if (compiler.usesClassDir && projectChanged && os.isDir(classesDir0)) {
-      logger.debug(s"Clearing $classesDir0")
-      os.list(classesDir0).foreach { p =>
-        logger.debug(s"Removing $p")
-        try os.remove.all(p)
-        catch {
-          case ex: FileSystemException =>
-            logger.debug(s"Ignore $ex while removing $p")
-        }
-      }
-    }
-
     buildClient.clear()
     buildClient.setGeneratedSources(scope, generatedSources)
 

modules/build/src/main/scala/scala/build/Project.scala

@@ -15,6 +15,7 @@ import scala.build.options.{ScalacOpt, Scope, ShadowingSeq}
 final case class Project(
   workspace: os.Path,
   directory: os.Path,
+  argsFilePath: os.Path,
   classesDir: os.Path,
   scaladocDir: os.Path,
   scalaCompiler: Option[ScalaCompilerParams],

modules/build/src/main/scala/scala/build/compiler/SimpleScalaCompiler.scala

@@ -2,7 +2,7 @@ package scala.build.compiler
 
 import java.io.File
 
-import scala.build.internal.Runner
+import scala.build.internal.{Constants, Runner}
 import scala.build.{Logger, Positioned, Project}
 
 /** A simple Scala compiler designed to handle scaladocs, Java projects & get `scalac` outputs.
@@ -51,6 +51,8 @@ final case class SimpleScalaCompiler(
     *   sources to be passed when running `scalac` (optional)
     * @param outputDir
     *   output directory for the compiler (optional)
+    * @param argsFileDir
+    *   output directory for the args file (optional)
     * @param cwd
     *   working directory for running the compiler
     * @param logger
@@ -67,6 +69,7 @@ final case class SimpleScalaCompiler(
     compilerClassPath: Seq[os.Path],
     sources: Seq[String],
     outputDir: Option[os.Path],
+    argsFilePath: Option[os.Path],
     cwd: os.Path,
     logger: Logger
   ): Int = {
@@ -80,7 +83,16 @@ final case class SimpleScalaCompiler(
         Seq("-cp", classPath.map(_.toString).mkString(File.pathSeparator))
       else Nil
 
-    val args = scalacOptions ++ outputDirArgs ++ classPathArgs ++ sources
+    val args = {
+      val freeArgs = scalacOptions ++ outputDirArgs ++ classPathArgs ++ sources
+
+      if (freeArgs.size > Constants.maxScalacArgumentsCount)
+        argsFilePath.fold(freeArgs) { path =>
+          os.write(path, freeArgs.mkString(System.lineSeparator()))
+          Seq(s"@$path")
+        }
+      else freeArgs
+    }
 
     val javaCommand =
       javaHomeOpt.map(SimpleJavaCompiler.javaCommand(_)).getOrElse(defaultJavaCommand)
@@ -130,6 +142,7 @@ final case class SimpleScalaCompiler(
       compilerClassPath = project.scalaCompiler.map(_.compilerClassPath).getOrElse(Nil),
       sources = project.sources.map(_.toString),
       outputDir = Some(outputDir),
+      argsFilePath = Some(project.argsFilePath),
       cwd = project.workspace,
       logger = logger
     )
@@ -176,6 +189,7 @@ final case class SimpleScalaCompiler(
           compilerClassPath = compilerClassPath,
           sources = Nil,
           outputDir = None,
+          argsFilePath = None,
           cwd = os.pwd,
           logger = logger
         )

modules/build/src/test/scala/scala/build/tests/BuildTests.scala

@@ -53,7 +53,7 @@ abstract class BuildTests(server: Boolean) extends TestUtil.ScalaCliBuildSuite {
     )
   )
 
-  def sv2 = "2.13.5"
+  def sv2 = Constants.defaultScala213Version
   val defaultOptions = baseOptions.copy(
     scalaOptions = baseOptions.scalaOptions.copy(
       scalaVersion = Some(MaybeScalaVersion(sv2)),
@@ -62,7 +62,7 @@ abstract class BuildTests(server: Boolean) extends TestUtil.ScalaCliBuildSuite {
     scriptOptions = ScriptOptions(Some(true))
   )
 
-  def sv3 = "3.0.0"
+  def sv3 = Constants.defaultScalaVersion
   val defaultScala3Options = defaultOptions.copy(
     scalaOptions = defaultOptions.scalaOptions.copy(
       scalaVersion = Some(MaybeScalaVersion(sv3)),
@@ -390,10 +390,11 @@ abstract class BuildTests(server: Boolean) extends TestUtil.ScalaCliBuildSuite {
       (root, _, maybeBuild) =>
         val expectedDiag = {
           val start = new bsp4j.Position(2, 0)
-          val end   = new bsp4j.Position(2, 0) // would have expected (2, 2) here :|
+          val end   = new bsp4j.Position(2, 2)
           val range = new bsp4j.Range(start, end)
           val d     = new bsp4j.Diagnostic(range, "Not found: zz")
           d.setSource("bloop")
+          d.setCode("6")
           d.setSeverity(bsp4j.DiagnosticSeverity.ERROR)
           val bScalaDiagnostic = new bsp4j.ScalaDiagnostic
           bScalaDiagnostic.setActions(List().asJava)
@@ -930,4 +931,24 @@ abstract class BuildTests(server: Boolean) extends TestUtil.ScalaCliBuildSuite {
       }
     }
   }
+
+  for (options <- Seq(defaultOptions, defaultScala3Options))
+    test(s"compile 12k sources for Scala ${options.scalaOptions.scalaVersion.get.asString}") {
+      val mainInput = os.rel / "main.sc" ->
+        """//> using jvm 11
+          |println("Hello from big build")
+          |""".stripMargin
+
+      val additionalInputs = 1 to 12000 map { i =>
+        os.rel / s"Foo$i.scala" ->
+          s"""object Foo$i
+             |""".stripMargin
+      }
+
+      val testInputs = TestInputs(mainInput +: additionalInputs: _*)
+
+      testInputs.withBuild(options, buildThreads, bloopConfigOpt) { (_, _, maybeBuild) =>
+        expect(maybeBuild.exists(_.success))
+      }
+    }
 }