-
Notifications
You must be signed in to change notification settings - Fork 0
New operations standards based on actuator #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dadamagouil
wants to merge
2
commits into
master
Choose a base branch
from
new-actuator-standards
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| # Operations | ||
|
|
||
| This section covers standards linked to operations. | ||
| This section covers standards related to operations. Those standards are simply the actuator standards. Keep the actuator standards simplify the alignement of all applications in VA ecosystem. | ||
|
|
||
| ## Environments | ||
|
|
||
| An API **MUST** be deployed to a QA (also called UAT) environment before being pushed to production. | ||
| An API **MUST** be deployed to a UAT environment before being pushed to production. | ||
|
|
||
| If more environments are required, an API developer **SHOULD** follow existing DNS naming conventions (internal link) to name environments. | ||
|
|
||
|
|
@@ -18,71 +18,92 @@ The team in charge of an API running in a production environment **SHOULD** ensu | |
|
|
||
| An API **SHOULD** expose an endpoint to check its health status | ||
|
|
||
| The parent path ```/health``` **SHOULD** provide some details about components (dependencies) | ||
|
|
||
| ```json | ||
| { | ||
| "name": "Va.Api.Business.MyAwesomeProduct", | ||
| "status": "up", | ||
| "dependencies": [ | ||
| { | ||
| "name": "Va.Api.Tech.Dependency1", | ||
| "version": null, | ||
| "depth": 1, | ||
| "status": "up" | ||
| "status": "UP", | ||
| "components": { | ||
| "discoveryComposite": { | ||
| "description": "", | ||
| "status": "UP", | ||
| "components": { | ||
| "discoveryClient": { | ||
| "description": "", | ||
| "status": "UP" | ||
| } | ||
| } | ||
| }, | ||
| "livenessState": { | ||
| "status": "UP" | ||
| }, | ||
| { | ||
| "name": "Va.Api.Tech.SubDependency", | ||
| "version": "4.9.0-SNAPSHOT", | ||
| "depth": 2, | ||
| "status": "up" | ||
| "readinessState": { | ||
| "status": "UP" | ||
| } | ||
| }, | ||
| "groups": [ | ||
| "liveness", | ||
| "readiness" | ||
| ] | ||
| } | ||
|
|
||
| ``` | ||
|
|
||
| The path ```/health/liveness``` **SHOULD** provide the liveness | ||
|
|
||
| ```json | ||
| { | ||
| "status": "UP" | ||
| } | ||
|
|
||
| ``` | ||
|
|
||
| The path ```/health/readiness``` **SHOULD** provide the readiness | ||
|
|
||
| ```json | ||
| { | ||
| "status": "UP" | ||
| } | ||
|
|
||
| ``` | ||
|
|
||
| Furthermore, continous integration tools **COULD** use the healthcheck endpoint to confirm that the API is running correctly. | ||
|
|
||
| ### Dependencies | ||
| ### Information | ||
|
|
||
| In non production environments, an API **SHOULD** expose an endpoint to give basic information about its run. | ||
|
|
||
| In non-production environments, an API **SHOULD** expose an endpoint to list Vaudoise library dependencies being used. | ||
| The path ```/info``` **SHOULD** provide following information | ||
|
|
||
| ```json | ||
| { | ||
| "product": "Va.XCut.Back.Actuators.Core", | ||
| "version": "1.0.0.13490", | ||
| "libraries": [ | ||
| { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Libraries are no more included ? |
||
| "name": "Va.XCut.Api.Template.Application", | ||
| "product": "Va.XCut.Api.Template", | ||
| "version": "0.0.0.13490", | ||
| "informationalVersion": "0.0.0", | ||
| "configuration": "Debug" | ||
| }, | ||
| { | ||
| "name": "Va.XCut.Back.Logger.Std", | ||
| "product": "Va.XCut.Back.Logger.Std", | ||
| "version": "1.0.0.13490", | ||
| "informationalVersion": "1.0.0-Beta01", | ||
| "configuration": "Debug" | ||
| ] | ||
| "product": "vaapi-mails", | ||
| "serviceStartTime": "2025-01-27T10:23:40Z", | ||
| "buildTime": "2025-01-16T15:30:29Z", | ||
| "serviceProcessId": 1, | ||
| "version": "1.7.0-SNAPSHOT" | ||
| } | ||
|
|
||
| ``` | ||
|
|
||
| ### Hosting | ||
| ### Metrics | ||
|
|
||
| In non production environments, an API **SHOULD** expose an endpoint to give basic information about the hosting server. | ||
| In non production environments, an API **SHOULD** expose an endpoint to give basic information about the metrics. | ||
|
|
||
| The path ```/metrics``` **SHOULD** provide following information (not exhaustive list) | ||
|
|
||
| ```json | ||
| { | ||
| "machineDomain": "VAUDOISE", | ||
| "machineName": "DEVABCDEF", | ||
| "machineOS": "Microsoft Windows 10.0.10240 ", | ||
| "machineProcessorCount": 8, | ||
| "environmentName": ".NET Core 4.6.26606.02", | ||
| "environmentArchitecture": "x64", | ||
| "serviceName": "Va.XCut.Api.Template.Application", | ||
| "serviceProcessId": 8752, | ||
| "serviceStartTime": "2018-07-05T07:29:44.4771925+02:00", | ||
| "serviceMemory": 92827648, | ||
| "serviceThreads": 21 | ||
| "names": [ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is clearly different from before. Why this change ? It feels like this is no more the example |
||
| "application.ready.time", | ||
| "application.started.time", | ||
| "disk.free", | ||
| "disk.total", | ||
| "executor.active", | ||
| "executor.completed", | ||
| "executor.pool.core", | ||
| "executor.pool.max", | ||
| ... | ||
| ] | ||
| } | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be interesting to state the difference between liveness and readiness ?