feat: Ignore disabled tracks

Author: desher

package.json

@@ -1,6 +1,6 @@
 {
   "name": "webrtc-issue-detector",
-  "version": "1.7.0",
+  "version": "1.8.0-ignore-disabled-tracks.1",
   "description": "WebRTC diagnostic tool that detects issues with network or user devices",
   "repository": "git@github.com:VLprojects/webrtc-issue-detector.git",
   "author": "Roman Kuzakov <roman.kuzakov@gmail.com>",

src/WebRTCIssueDetector.ts

@@ -67,7 +67,10 @@ class WebRTCIssueDetector {
 
     this.networkScoresCalculator = params.networkScoresCalculator ?? new DefaultNetworkScoresCalculator();
     this.compositeStatsParser = params.compositeStatsParser ?? new CompositeRTCStatsParser({
-      statsParser: new RTCStatsParser({ logger: this.logger }),
+      statsParser: new RTCStatsParser({
+        ignoreSSRCList: params.ignoreSSRCList,
+        logger: this.logger,
+      }),
     });
     this.statsReporter = params.statsReporter ?? new PeriodicWebRTCStatsReporter({
       compositeStatsParser: this.compositeStatsParser,
@@ -80,7 +83,6 @@ class WebRTCIssueDetector {
     this.statsReporter.on(PeriodicWebRTCStatsReporter.STATS_REPORT_READY_EVENT, (report: StatsReportItem) => {
       this.detectIssues({
         data: report.stats,
-        ignoreSSRCList: params.ignoreSSRCList,
       });
 
       this.calculateNetworkScores(report.stats);
@@ -135,18 +137,8 @@ class WebRTCIssueDetector {
     this.eventEmitter.emit(EventType.Issue, issues);
   }
 
-  private detectIssues({ data, ignoreSSRCList }: DetectIssuesPayload): void {
-    let issues = this.detectors.reduce<IssuePayload[]>((acc, detector) => [...acc, ...detector.detect(data)], []);
-    if (ignoreSSRCList?.length) {
-      issues = issues.filter((issue) => {
-        if (!issue.ssrc) {
-          return true;
-        }
-
-        return !ignoreSSRCList.includes(issue.ssrc);
-      });
-    }
-
+  private detectIssues({ data }: DetectIssuesPayload): void {
+    const issues = this.detectors.reduce<IssuePayload[]>((acc, detector) => [...acc, ...detector.detect(data)], []);
     if (issues.length > 0) {
       this.emitIssues(issues);
     }

src/parser/RTCStatsParser.ts

@@ -24,6 +24,7 @@ interface PrevStatsItem {
 }
 
 interface WebRTCStatsParserParams {
+  ignoreSSRCList?: number[];
   logger: Logger;
 }
 
@@ -40,9 +41,12 @@ class RTCStatsParser implements StatsParser {
     'transport',
   ]);
 
+  private readonly ignoreSSRCList: number[];
+
   private readonly logger: Logger;
 
   constructor(params: WebRTCStatsParserParams) {
+    this.ignoreSSRCList = params.ignoreSSRCList ?? [];
     this.logger = params.logger;
   }
 
@@ -64,8 +68,13 @@ class RTCStatsParser implements StatsParser {
 
     try {
       const beforeGetStats = Date.now();
-      const receiversStats = await Promise.all(pc.getReceivers().map((r) => r.getStats()));
-      const sendersStats = await Promise.all(pc.getSenders().map((r) => r.getStats()));
+
+      const recieversWithActiveTracks = pc.getReceivers().filter((r) => r.track?.enabled);
+      const sendersWithActiveTracks = pc.getSenders().filter((s) => s.track?.enabled);
+
+      const receiversStats = await Promise.all(recieversWithActiveTracks.map((r) => r.getStats()));
+      const sendersStats = await Promise.all(sendersWithActiveTracks.map((r) => r.getStats()));
+
       const stats = this.mapReportsStats([...receiversStats, ...sendersStats], info);
 
       return {
@@ -150,6 +159,11 @@ class RTCStatsParser implements StatsParser {
       return;
     }
 
+    const ssrc = statsItem.ssrc as number;
+    if (ssrc && this.ignoreSSRCList.includes(ssrc)) {
+      return;
+    }
+
     if (type === 'outbound-rtp') {
       const trackInfo = stats.get(statsItem.trackId as string)
         || stats.get(statsItem.mediaSourceId as string) || {};

src/types.ts

@@ -94,7 +94,6 @@ export type IssuePayload = {
 
 export type DetectIssuesPayload = {
   data: WebRTCStatsParsed,
-  ignoreSSRCList?: number[],
 };
 
 export type NetworkScore = number;