Apply clippy suggestions

Author: Schottkyc137

vhdl_lang/src/analysis/overloaded.rs

@@ -367,7 +367,7 @@ impl<'a> AnalyzeContext<'a> {
             return Ok(Disambiguated::Unambiguous(ent));
         } else if strict_ok_assoc_types.is_empty() {
             // Do not disambiguate away to emtpy result
-            strict_ok_assoc_types = ok_return_type.clone();
+            strict_ok_assoc_types.clone_from(&ok_return_type);
         }
 
         Ok(Disambiguated::Ambiguous(

vhdl_lang/src/ast/util.rs

@@ -210,10 +210,6 @@ pub trait HasPrimaryIdent {
     fn primary_name(&self) -> &Symbol {
         &self.primary_ident().item
     }
-    /// The position of the primary name in the secondary unit declaration
-    fn primary_pos(&self) -> &SrcPos {
-        &self.primary_ident().pos
-    }
 }
 
 impl HasPrimaryIdent for ArchitectureBody {

vhdl_lang/src/syntax/tokens/tokenstream.rs

@@ -306,8 +306,6 @@ pub trait Recover<T> {
     fn or_recover_until<F>(self, ctx: &mut ParsingContext<'_>, cond: F) -> DiagnosticResult<T>
     where
         F: Fn(Kind) -> bool;
-
-    fn log(self, msgs: &mut dyn DiagnosticHandler);
 }
 
 impl<T> Recover<T> for DiagnosticResult<T> {
@@ -329,12 +327,6 @@ impl<T> Recover<T> for DiagnosticResult<T> {
             }
         }
     }
-
-    fn log(self, msgs: &mut dyn DiagnosticHandler) {
-        if let Err(err) = self {
-            msgs.push(err)
-        }
-    }
 }
 
 #[cfg(test)]