Skip to content

Conversation

@prawilny
Copy link
Collaborator

@prawilny prawilny commented Oct 29, 2025

This change is Reviewable

It's possibly mergable only after hedronvision/bazel-compile-commands-extractor#219 lands

edit: Note that protobuf-generated code remains a problem (for both development using compile_commands.json and clang-tidy) - by default it's compiled into .o files with .pb.h and .pb.cc are deleted.

@prawilny prawilny marked this pull request as ready for review November 4, 2025 13:32
@prawilny prawilny changed the title WIP hedron_compile_commands integration for compile_commands.json Bazel hedron_compile_commands integration for compile_commands.json Nov 4, 2025
@prawilny prawilny mentioned this pull request Nov 4, 2025
@prawilny prawilny requested a review from marete November 4, 2025 14:01
@prawilny prawilny changed the title Bazel hedron_compile_commands integration for compile_commands.json Bazel tooling for compile_commands.json Nov 4, 2025
Copy link
Collaborator

@marete marete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit.

.bazelrc Outdated
# the project separately.
build --experimental_convenience_symlinks=ignore

# Allow the to opt into convenience links for tools relying on them.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: check and fix comment language.

@prawilny prawilny force-pushed the bazel-compile-commands branch from 7d8b5f0 to 101baa3 Compare November 5, 2025 12:10
@prawilny prawilny merged commit 75e25b5 into main Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants