Replace argument replacements with properties #368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise that won't work when including this from another xacro where those arguments aren't available.
Consider this simplified URDF:
The
sim_ignitionparameter is passed to theur_robot_macro, as one might expect it. However, with thehumblebranch version this will fail withInside the macro was read from an argument, that is defined outside of the macro file. This only coincidently works as long as we use it in a xacro structure where this argument is defined.
This PR reads the value not from the global argument but from the macro parameter which gets stored into a property.
The test URDF from above works fine with the changes from this branch.