Merge pull request #1484 from Unity-Technologies/mono-paraminfo-getattrs-inherit-ignore

Ignore inherit param for ParameterInfo.GetCustomAttributes

Author: bholmes

mcs/class/corlib/System.Reflection/RuntimeParameterInfo.cs

@@ -192,14 +192,20 @@ int MetadataToken {
 		override
 		object[] GetCustomAttributes (bool inherit)
 		{
-			return MonoCustomAttrs.GetCustomAttributes (this, inherit);
+			// It is documented that the inherit flag is ignored.
+			// Attribute.GetCustomAttributes is to be used to search
+			// inheritance chain.
+			return MonoCustomAttrs.GetCustomAttributes (this, false);
 		}
 
 		public
 		override
 		object[] GetCustomAttributes (Type attributeType, bool inherit)
 		{
-			return MonoCustomAttrs.GetCustomAttributes (this, attributeType, inherit);
+			// It is documented that the inherit flag is ignored.
+			// Attribute.GetCustomAttributes is to be used to search
+			// inheritance chain.
+			return MonoCustomAttrs.GetCustomAttributes (this, attributeType, false);
 		}
 
 		internal object GetDefaultValueImpl (ParameterInfo pinfo)

mcs/class/corlib/System/MonoCustomAttrs.cs

@@ -183,9 +183,6 @@ internal static object[] GetCustomAttributes (ICustomAttributeProvider obj, Type
 			if (inherit && GetBase (obj) == null)
 				inherit = false;
 
-			if (obj is RuntimeParameterInfo)
-				inherit = false;
-
 			// if AttributeType is sealed, and Inherited is set to false, then 
 			// there's no use in scanning base types 
 			if ((attributeType != null && attributeType.IsSealed) && inherit) {