Deprecated actions (#6077)

* Upgrade git up actions versions to fix deprecation warnings

Sample deprecation warnings this fixes:
https://github.com/Unity-Technologies/ml-agents/actions/runs/8189380401
https://github.com/Unity-Technologies/ml-agents/actions/runs/8189380425
https://github.com/Unity-Technologies/ml-agents/actions/runs/8189380389

* Give artifacts unique names

This is a required change for upload-artifact v4: https://github.com/actions/upload-artifact/blob/ef09cdac3e2d3e60d8ccadda691f4f1cec5035cb/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact

* Migrate away from set-ouput

Following the example on the migration guide: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

* Upgrade some more deprecated actions

Sample deprecation warnings:
https://github.com/Unity-Technologies/ml-agents/actions/runs/8191144402

Author: alex-mccarthy-unity

.github/workflows/colab.yml

@@ -27,16 +27,16 @@ jobs:
       matrix:
         notebook_path: [Colab_UnityEnvironment_1_Run.ipynb, Colab_UnityEnvironment_2_Train.ipynb, Colab_UnityEnvironment_3_SideChannel.ipynb]
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Set up Python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v5
       with:
         python-version: 3.10.12
-    - uses: actions/setup-dotnet@v1
+    - uses: actions/setup-dotnet@v4
       with:
         dotnet-version: '6.0.x'
     - name: Cache pip
-      uses: actions/cache@v2
+      uses: actions/cache@v4
       with:
         # This path is specific to Ubuntu
         path: ~/.cache/pip
@@ -56,9 +56,9 @@ jobs:
     - name: Execute notebook
       run: jupyter nbconvert --to notebook --execute --log-level=DEBUG --ExecutePreprocessor.kernel_name=python3 --output output-${{ matrix.notebook_path }} colab/${{ matrix.notebook_path }}
     - name: Upload colab results
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
-        name: artifacts
+        name: artifacts-${{ matrix.notebook_path }}
         path: |
           colab/output-${{ matrix.notebook_path }}
       # Use always() to always run this step to publish execution results when there are failures

.github/workflows/lock.yml

@@ -12,7 +12,7 @@ jobs:
         issues: write
         pull-requests: write
     steps:
-      - uses: actions/stale@v5
+      - uses: actions/stale@v9
         with:
           days-before-issue-stale: 30
           days-before-issue-close: 14

.github/workflows/nightly.yml

@@ -9,9 +9,11 @@ jobs:
   markdown-link-check-full:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - uses: actions/setup-python@v2
-    - uses: actions/setup-node@v2
+    - uses: actions/checkout@v4
+    - uses: actions/setup-python@v5
+      with:
+        python-version: 3.10.12
+    - uses: actions/setup-node@v4
       with:
         node-version: '12'
     - name: Install manual dependencies
@@ -26,7 +28,7 @@ jobs:
     runs-on: ubuntu-latest
 #   TODO: Re-use pytest workflow once https://github.com/github/roadmap/issues/257 is done.
 #    steps:
-#    - uses: actions/checkout@v2
+#    - uses: actions/checkout@v4
 #    - uses: ./.github/workflows/pytest.yml
 #      with:
 #        # Run all tests.
@@ -42,13 +44,13 @@ jobs:
           - python-version: 3.10.12
             pip_constraints: test_constraints_version.txt
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Set up Python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v5
       with:
         python-version: ${{ matrix.python-version }}
     - name: Cache pip
-      uses: actions/cache@v2
+      uses: actions/cache@v4
       with:
         # This path is specific to Ubuntu
         path: ~/.cache/pip
@@ -77,7 +79,7 @@ jobs:
         --cov-report=html --junitxml=junit/test-results-${{ matrix.python-version }}.xml \
         -p no:warnings -v -n 8
     - name: Upload pytest test results
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: artifacts-${{ matrix.python-version }}
         path: |

.github/workflows/pre-commit.yml

@@ -13,8 +13,8 @@ jobs:
   pre-commit:
     runs-on: ubuntu-20.04
     steps:
-    - uses: actions/checkout@v2
-    - uses: actions/setup-python@v2
+    - uses: actions/checkout@v4
+    - uses: actions/setup-python@v5
       with:
         python-version: 3.10.x
     - uses: ruby/setup-ruby@v1
@@ -23,7 +23,7 @@ jobs:
       with:
         ruby-version: '2.7'
         bundler-cache: true # runs 'bundle install' and caches installed gems automatically
-    - uses: actions/setup-dotnet@v3
+    - uses: actions/setup-dotnet@v4
       with:
         dotnet-version: '7.0.100'
     - name: Install manual dependencies
@@ -36,9 +36,11 @@ jobs:
   markdown-link-check:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - uses: actions/setup-python@v2
-    - uses: actions/setup-node@v2
+    - uses: actions/checkout@v4
+    - uses: actions/setup-python@v5
+      with:
+        python-version: 3.10.x
+    - uses: actions/setup-node@v4
       with:
         node-version: '12'
     - name: Install manual dependencies
@@ -53,6 +55,8 @@ jobs:
   validate-meta-files:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - uses: actions/setup-python@v2
+    - uses: actions/checkout@v4
+    - uses: actions/setup-python@v5
+      with:
+        python-version: 3.10.x
     - run: python utils/validate_meta_files.py

.github/workflows/publish_docs.yaml

@@ -9,11 +9,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
         with:
           token: ${{ secrets.PUBLIC_GH_TOKEN }}
       - name: Setup Python 3.10
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v5
         with:
           python-version: 3.10
       - name: Publish docs

.github/workflows/publish_pypi.yaml

@@ -19,7 +19,7 @@ jobs:
     steps:
     - uses: actions/checkout@main
     - name: Set up Python 3.10
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v5
       with:
         python-version: 3.10.x
     - name: Install dependencies

.github/workflows/publish_pypi_python_api.yaml

@@ -17,9 +17,9 @@ jobs:
             package-path: [ml-agents-envs]
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Set up Python 3.10
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v5
       with:
         python-version: 3.10.x
     - name: Install dependencies

.github/workflows/pytest.yml

@@ -42,13 +42,13 @@ jobs:
           - python-version: 3.10.12
             pip_constraints: test_constraints_version.txt
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Set up Python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v5
       with:
         python-version: ${{ matrix.python-version }}
     - name: Cache pip
-      uses: actions/cache@v2
+      uses: actions/cache@v4
       with:
         # This path is specific to Ubuntu
         path: ~/.cache/pip
@@ -75,17 +75,17 @@ jobs:
       id: pytest_marker
       run: |
         if [ "${{ github.event.inputs.pytest_markers }}" != "" ]; then
-          echo "::set-output name=markers::${{ github.event.inputs.pytest_markers }}"
+          echo "markers=${{ github.event.inputs.pytest_markers }}" >> $GITHUB_OUTPUT
         else
-          echo "::set-output name=markers::not slow"
+          echo "markers=not slow" >> $GITHUB_OUTPUT
         fi
     - name: Run pytest
       run: |
         pytest --cov=ml-agents --cov=ml-agents-envs \
         --cov-report=html --junitxml=junit/test-results-${{ matrix.python-version }}.xml \
         -p no:warnings -v -m "${{ steps.pytest_marker.outputs.markers }}" -n 8
     - name: Upload pytest test results
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: artifacts-${{ matrix.python-version }}
         path: |

.github/workflows/validate_catalog.yaml

@@ -14,7 +14,7 @@ jobs:
     runs-on: [ubuntu-latest]
     steps:
       - id: 'Checkout'
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - id: 'Validate'
         uses: 'RoadieHQ/backstage-entity-validator@v0.3.2'