Unity 2023.3.0a5 C# reference source code

Author: Unity Technologies

Editor/Mono/BuildPipeline/NamedBuildTarget.cs

@@ -27,6 +27,7 @@ namespace UnityEditor.Build
             "CloudRendering",
             "LinuxHeadlessSimulation",
             "Lumin",
+            // This should have been "GameCoreXboxSeries"
             "GameCoreScarlett",
             "GameCoreXboxOne",
             "PS5",
@@ -41,6 +42,7 @@ namespace UnityEditor.Build
         public static readonly NamedBuildTarget Android = new NamedBuildTarget("Android");
         public static readonly NamedBuildTarget WebGL = new NamedBuildTarget("WebGL");
         public static readonly NamedBuildTarget WindowsStoreApps = new NamedBuildTarget("Windows Store Apps");
+        // NDA platforms should not have been added here into the public API
         public static readonly NamedBuildTarget PS4 = new NamedBuildTarget("PS4");
         public static readonly NamedBuildTarget PS5 = new NamedBuildTarget("PS5");
         public static readonly NamedBuildTarget XboxOne = new NamedBuildTarget("XboxOne");

Editor/Mono/ImportSettings/DesktopPluginImporterExtension.cs

@@ -153,6 +153,9 @@ internal override void OnGUI(PluginImporterInspector inspector)
         private readonly DesktopSingleCPUProperty m_LinuxManaged;
         private readonly DesktopSingleCPUProperty m_MacOSManaged;
 
+        private Property[] nativeProperties = null;
+        private Property[] managedProperties = null;
+
         public DesktopPluginImporterExtension()
             : base(null)
         {
@@ -169,12 +172,16 @@ public DesktopPluginImporterExtension()
             m_LinuxManaged = new DesktopSingleCPUProperty(EditorGUIUtility.TrTextContent("Linux x64"),BuildTarget.StandaloneLinux64);
             m_MacOSManaged = new DesktopSingleCPUProperty(EditorGUIUtility.TrTextContent("macOS 64-bit"),BuildTarget.StandaloneOSX);
 
-            properties = new Property[]
+            nativeProperties = new Property[]
             {
                 m_Windows32,
                 m_Windows64,
                 m_Linux,
                 m_MacOS,
+            };
+
+            managedProperties = new Property[]
+            {
                 m_Windows32Managed,
                 m_Windows64Managed,
                 m_LinuxManaged,
@@ -208,6 +215,11 @@ private bool IsUsableOnLinux(PluginImporter imp)
             return IsLinuxLibrary(imp.assetPath) || IsCppPluginFile(imp.assetPath);
         }
 
+        protected override Property[] GetPropertiesForInspector(PluginImporterInspector inspector)
+        {
+            return inspector.importer.isNativePlugin ? nativeProperties : managedProperties;
+        }
+
         public override void OnPlatformSettingsGUI(PluginImporterInspector inspector)
         {
             PluginImporter imp = inspector.importer;
@@ -257,7 +269,7 @@ public override void OnPlatformSettingsGUI(PluginImporterInspector inspector)
 
         public void ValidateSingleCPUTargets(PluginImporterInspector inspector)
         {
-            var singleCPUTargets = properties.OfType<DesktopSingleCPUProperty>();
+            var singleCPUTargets = GetPropertiesForInspector(inspector).OfType<DesktopSingleCPUProperty>();
 
             foreach (var target in singleCPUTargets)
             {

Editor/Mono/Inspector/AudioSourceInspector.cs

@@ -5,6 +5,7 @@
 using UnityEngine;
 using System.Collections.Generic;
 using System.Linq;
+using UnityEngine.Audio;
 
 namespace UnityEditor
 {
@@ -392,7 +393,17 @@ public override void OnInspectorGUI()
             EditorGUILayout.Space();
             EditorGUILayout.Slider(m_Volume, 0f, 1.0f, Styles.volumeLabel);
             EditorGUILayout.Space();
-            EditorGUILayout.Slider(m_Pitch, -3.0f, 3.0f, Styles.pitchLabel);
+
+            var resource = m_AudioResource.objectReferenceValue as AudioResource;
+            if (resource is AudioRandomContainer)
+                {
+                    EditorGUILayout.Slider(m_Pitch, EPSILON, 3.0f, Styles.pitchLabel);
+
+                }
+                else
+                {
+                    EditorGUILayout.Slider(m_Pitch, -3.0f, 3.0f, Styles.pitchLabel);
+                }
 
             EditorGUILayout.Space();
 

Editor/Mono/Inspector/LightProbeGroupInspector.cs

@@ -717,21 +717,7 @@ public override void OnInspectorGUI()
 
             if (srpHasAlternativeToLegacyProbes)
             {
-                GUIStyle helpboxStyle = new GUIStyle(EditorStyles.helpBox)
-                {
-                    wordWrap = true,
-                    alignment = TextAnchor.MiddleLeft,
-                    richText = true,
-                    padding = new RectOffset(36, 4, 4, 4)
-                };
-
-                GUIContent content = new GUIContent(SupportedRenderingFeatures.active.overridesLightProbeSystemWarningMessage);
-                float height = helpboxStyle.CalcHeight(content, EditorGUIUtility.currentViewWidth - helpboxStyle.padding.horizontal);
-
-                GUI.Box(GUILayoutUtility.GetRect(content, helpboxStyle, GUILayout.Height(height)), content, helpboxStyle);
-                Rect r = GUILayoutUtility.GetLastRect();
-
-                GUI.Label(new Rect(r.x + 4, r.y + height / 2 - 16, 32, 32), EditorGUIUtility.IconContent("console.warnicon"));
+                EditorGUILayout.HelpBox(SupportedRenderingFeatures.active.overridesLightProbeSystemWarningMessage, MessageType.Warning, true);
             }
             else
             {

Editor/Mono/Inspector/PlayerSettingsEditor/PlayerSettingsEditor.cs

@@ -2537,7 +2537,7 @@ private void OtherSectionIdentificationGUI(BuildPlatform platform, ISettingEdito
                     }
                 }
 
-                PlayerSettingsEditor.ShowBuildNumberUI(m_BuildNumber, BuildTargetGroup.Standalone, "Build", "'CFBundleVersion'");
+                PlayerSettingsEditor.ShowBuildNumberUI(m_BuildNumber, NamedBuildTarget.Standalone, "Build", "'CFBundleVersion'");
 
                 EditorGUILayout.PropertyField(m_MacAppStoreCategory, SettingsContent.macAppStoreCategory);
                 EditorGUILayout.PropertyField(m_UseMacAppStoreValidation, SettingsContent.useMacAppStoreValidation);
@@ -2647,13 +2647,11 @@ string GetSanitizedApplicationIdentifier()
             }
         }
 
-        internal static void ShowBuildNumberUI(SerializedProperty prop, BuildTargetGroup targetGroup, string label, string tooltip)
+        internal static void ShowBuildNumberUI(SerializedProperty prop, NamedBuildTarget buildTarget, string label, string tooltip)
         {
-            var buildTargetGroup = BuildPipeline.GetBuildTargetGroupName(targetGroup);
-
             if (!prop.serializedObject.isEditingMultipleObjects)
             {
-                prop.TryGetMapEntry(buildTargetGroup, out var entry);
+                prop.TryGetMapEntry(buildTarget.TargetName, out var entry);
 
                 if (entry != null)
                 {

Editor/Mono/Inspector/TimeManagerInspector.cs

@@ -61,11 +61,14 @@ static void DrawFixedTimeAsFloat(SerializedProperty prop)
             var fixedTime = (float)new RationalTime(prop.longValue, m_FixedTimeTicksPerSecond).ToDouble(); // Convert a tick count to a float
             using (var c = new EditorGUI.ChangeCheckScope())
             {
-                fixedTime = EditorGUILayout.FloatField(Content.fixedTimestepLabel, fixedTime);
+                var maxFixedTime = MathF.Max(fixedTime, MinFixedTimeStep);
+                var roundedTime = Math.Round(maxFixedTime, 4, MidpointRounding.AwayFromZero);
+                fixedTime = EditorGUILayout.FloatField(Content.fixedTimestepLabel, (float)roundedTime);
+
                 if (c.changed)
                 {
                     var newCount = RationalTime
-                        .FromDouble(MathF.Max(fixedTime, MinFixedTimeStep), m_FixedTimeTicksPerSecond)
+                        .FromDouble(fixedTime, m_FixedTimeTicksPerSecond)
                         .Count; // convert it back to a count to store in the property
                     prop.longValue = newCount;
                 }

Editor/Mono/InternalEditorUtility.bindings.cs

@@ -856,7 +856,7 @@ internal static bool RunningUnderWindows8(bool orHigher = true)
 
         [StaticAccessor("UnityExtensions::Get()", StaticAccessorType.Dot)]
         [NativeMethod("IsCompatibleWithEditor")]
-        extern internal static bool IsUnityExtensionCompatibleWithEditor(BuildTargetGroup targetGroup, BuildTarget target, string path);
+        extern internal static bool IsUnityExtensionCompatibleWithEditor(BuildTarget target, string path);
 
         [FreeFunction(IsThreadSafe = true)]
         extern public static bool CurrentThreadIsMainThread();

Editor/Mono/Modules/DefaultPluginImporterExtension.cs

@@ -89,6 +89,11 @@ public DefaultPluginImporterExtension(Property[] properties)
             this.properties = properties;
         }
 
+        protected virtual Property[] GetPropertiesForInspector(PluginImporterInspector inspector)
+        {
+            return properties;
+        }
+
         public virtual void ResetValues(PluginImporterInspector inspector)
         {
             hasModified = false;
@@ -104,7 +109,7 @@ public virtual void Apply(PluginImporterInspector inspector)
         {
             if (!propertiesRefreshed) return;
 
-            foreach (var p in properties)
+            foreach (var p in GetPropertiesForInspector(inspector))
             {
                 p.Apply(inspector);
             }
@@ -126,7 +131,7 @@ public virtual void OnPlatformSettingsGUI(PluginImporterInspector inspector)
             if (!propertiesRefreshed) RefreshProperties(inspector);
 
             EditorGUI.BeginChangeCheck();
-            foreach (var p in properties)
+            foreach (var p in GetPropertiesForInspector(inspector))
             {
                 // skip CPU property for things that aren't native libs
                 if (p.key == cpuKey && !inspector.importer.isNativePlugin)
@@ -138,7 +143,7 @@ public virtual void OnPlatformSettingsGUI(PluginImporterInspector inspector)
 
         protected virtual void RefreshProperties(PluginImporterInspector inspector)
         {
-            foreach (var p in properties)
+            foreach (var p in GetPropertiesForInspector(inspector))
             {
                 p.Reset(inspector);
             }

Editor/Mono/SerializedProperty.bindings.cs

@@ -270,21 +270,26 @@ public SerializedProperty GetArrayElementAtIndex(int index)
 
         internal void SetToValueOfTarget(UnityObject target)
         {
-            SerializedProperty targetProperty = new SerializedObject(target).FindProperty(propertyPath);
-            if (targetProperty == null)
+            using (SerializedObject targetObject = new SerializedObject(target))
             {
-                Debug.LogError(target.name + " does not have the property " + propertyPath);
-                return;
-            }
+                using (SerializedProperty targetProperty = targetObject.FindProperty(propertyPath))
+                {
+                    if (targetProperty == null)
+                    {
+                        Debug.LogError(target.name + " does not have the property " + propertyPath);
+                        return;
+                    }
 
-            try
-            {
-                boxedValue = targetProperty.boxedValue;
-            }
-            catch (NotSupportedException ex)
-            {
-                // Previous implementation silently did nothing for unsupported types, now moving towards more strict error handling with this warning
-                Debug.LogWarning(ex.Message);
+                    try
+                    {
+                        boxedValue = targetProperty.boxedValue;
+                    }
+                    catch (NotSupportedException ex)
+                    {
+                        // Previous implementation silently did nothing for unsupported types, now moving towards more strict error handling with this warning
+                        Debug.LogWarning(ex.Message);
+                    }
+                }
             }
         }
 

Editor/Mono/UIElements/EditorMenuExtensions.cs

@@ -20,13 +20,21 @@ public enum DropdownMenuSearch
         Always
     }
 
+    public enum DropdownMenuLayout
+    {
+        Short,
+        Medium,
+        Long
+    }
+
     public class DropdownMenuDescriptor
     {
         public bool allowSubmenus { get; set; } = true;
         public bool autoClose { get; set; } = true;
         public bool expansion { get; set; } = true;
         public bool parseShortcuts { get; set; } = true;
         public DropdownMenuSearch search { get; set; } = DropdownMenuSearch.Auto;
+        public DropdownMenuLayout layout { get; set; } = DropdownMenuLayout.Long;
         public string title { get; set; } = null;
     }
 
@@ -49,7 +57,7 @@ public static class EditorMenuExtensions
         internal static readonly string searchCategoryUssClassName = GenericDropdownMenu.ussClassName + "__search-category";
         internal static readonly string shortcutUssClassName = GenericDropdownMenu.ussClassName + "__shortcut";
 
-        static float maxMenuHeight => Screen.currentResolution.height / (Screen.dpi / 96.0f) * 0.75f;
+        static float maxMenuHeight => Screen.currentResolution.height / (Screen.dpi / 96.0f);
 
         internal static bool isEditorContextMenuActive => s_ActiveMenus.Count > 0;
 
@@ -102,7 +110,6 @@ void Host(GenericDropdownMenu menu)
                 menu.customFocusHandling = true;
 
                 menu.innerContainer.style.maxWidth = k_MaxMenuWidth;
-                menu.outerContainer.style.maxHeight = maxMenuHeight;
                 menu.outerContainer.RegisterCallback<GeometryChangedEvent>(e =>
                 {
                     maxSize = minSize= menu.outerContainer.worldBound.size;
@@ -465,7 +472,7 @@ void ResetHighlighting(GenericDropdownMenu.MenuItem root)
                 var menu = search.userData as GenericDropdownMenu;
                 var newValue = Regex.Replace(e.newValue, "[^\\w ]+", "");
                 search.SetValueWithoutNotify(newValue);
-                
+
                 ResetHighlighting(menu.root);
 
                 if (string.IsNullOrWhiteSpace(menu.current.name))
@@ -810,6 +817,23 @@ internal static void ApplyDescriptor(this GenericDropdownMenu menu, DropdownMenu
             if (desc.expansion)
                 menu.MakeExpandable();
 
+
+            var factor = 0f;
+            switch (desc.layout)
+            {
+                case DropdownMenuLayout.Short:
+                    factor = 0.25f;
+                    break;
+                case DropdownMenuLayout.Medium:
+                    factor = 0.5f;
+                    break;
+                case DropdownMenuLayout.Long:
+                default:
+                    factor = 0.75f;
+                    break;
+            }
+            menu.outerContainer.style.maxHeight = maxMenuHeight * factor;
+
             menu.root.name = desc.title;
             menu.allowBackButton = !desc.expansion;
             menu.autoClose = desc.autoClose;