Unity 2023.3.0a8 C# reference source code

Author: Unity Technologies

Editor/Mono/Animation/TransitionPreview.cs

@@ -269,7 +269,7 @@ private void ResampleTransition(AnimatorStateTransition transition, AvatarMask l
             AnimatorStateInfo currentState = m_AvatarPreview.Animator.GetCurrentAnimatorStateInfo(m_LayerIndex);
             m_LeftStateWeightA = currentState.normalizedTime;
             m_LeftStateTimeA = currentTime;
-            while (!hasFinished && currentTime < maxDuration)
+            while (!hasFinished)
             {
                 m_AvatarPreview.Animator.Update(stepTime);
 
@@ -284,7 +284,7 @@ private void ResampleTransition(AnimatorStateTransition transition, AvatarMask l
                     hasStarted = true;
                 }
 
-                if (hasTransitioned && currentTime >= maxDuration)
+                if (hasTransitioned || currentTime >= maxDuration)
                 {
                     hasFinished = true;
                 }
@@ -303,7 +303,7 @@ private void ResampleTransition(AnimatorStateTransition transition, AvatarMask l
                     m_LeftStateTimeB = currentTime;
                 }
 
-                if (hasTransitioned)
+                if (hasTransitioned || hasFinished)
                 {
                     m_RightStateWeightB = currentState.normalizedTime;
                     m_RightStateTimeB = currentTime;
@@ -329,6 +329,11 @@ private void ResampleTransition(AnimatorStateTransition transition, AvatarMask l
             float leftDuration =  (m_LeftStateTimeB - m_LeftStateTimeA) / (m_LeftStateWeightB - m_LeftStateWeightA);
             float rightDuration = (m_RightStateTimeB - m_RightStateTimeA) / (m_RightStateWeightB - m_RightStateWeightA);
 
+            // Ensure step times make sense based on these timings
+            // If step time is too small, the samping will take too long
+            currentStateStepTime = Mathf.Max(currentStateStepTime, leftDuration / 600.0f);
+            nextStateStepTime = Mathf.Max(nextStateStepTime, rightDuration / 600.0f);
+
             if (m_MustSampleMotions)
             {
                 // Do this as infrequently as possible

Editor/Mono/AssetPreviewUpdater.cs

@@ -2,18 +2,14 @@
 // Copyright (c) Unity Technologies. For terms of use, see
 // https://unity3d.com/legal/licenses/Unity_Reference_Only_License
 
-using System;
 using UnityEngine;
 using UnityEngine.Rendering;
 using UnityEngine.Scripting;
-using Object = UnityEngine.Object;
 
 namespace UnityEditor
 {
     internal static class AssetPreviewUpdater
     {
-        static readonly Type[] s_InspectorsRequireFullPipelineInitialization = new[] { typeof(MaterialEditor), typeof(ModelInspector), typeof(GameObjectInspector) };
-
         [RequiredByNativeCode]
         public static Texture2D CreatePreviewForAsset(Object obj, Object[] subAssets, string assetPath)
         {
@@ -37,30 +33,20 @@ public static Texture2D CreatePreview(Object obj, Object[] subAssets, string ass
             if (info.DeclaringType == typeof(Editor))
                 return null;
 
-
             var editor = Editor.CreateEditor(obj);
-
             if (editor == null)
                 return null;
 
             //Check that Render Pipeline is ready
+            //Beware: AssetImportWorkers have their own Render Pipeline instance. Render Pipeline will be separately created for each one of them.
             var pipelineWasNotInitialized = !RenderPipelineManager.pipelineSwitchCompleted;
 
-            //We keep this call to initialize Render Pipeline when Render Pipeline is not ready
-            var tex = editor.RenderStaticPreview(assetPath, subAssets, width, height);
+            //We always keep this call to initialize Render Pipeline when Render Pipeline was not ready
+            var previewTexture = editor.RenderStaticPreview(assetPath, subAssets, width, height);
 
-            //If Render Pipeline was not created before we will ignore the results and mark it dirty.
-            if (pipelineWasNotInitialized)
-            {
-                for (int i = 0; i < s_InspectorsRequireFullPipelineInitialization.Length; i++)
-                {
-                    if (type != s_InspectorsRequireFullPipelineInitialization[i])
-                        continue;
-                    EditorUtility.SetDirty(obj);
-                    Object.DestroyImmediate(editor);
-                    return null;
-                }
-            }
+            //If after render our Render Pipeline is initialized we re-render to have a valid result
+            if (pipelineWasNotInitialized && RenderPipelineManager.pipelineSwitchCompleted)
+                previewTexture = editor.RenderStaticPreview(assetPath, subAssets, width, height);
 
             // For debugging we write the preview to a file (keep)
             //{
@@ -71,8 +57,7 @@ public static Texture2D CreatePreview(Object obj, Object[] subAssets, string ass
             //}
 
             Object.DestroyImmediate(editor);
-
-            return tex;
+            return previewTexture;
         }
     }
 }

Editor/Mono/Audio/AudioContainerWindow.cs

@@ -310,6 +310,17 @@ void OneTimeEditorApplicationUpdate()
         EditorApplication.update -= OneTimeEditorApplicationUpdate;
     }
 
+    static void InsertUnitFieldForFloatField(VisualElement field, string unit)
+    {
+        var floatInput = UIToolkitUtilities.GetChildByName<VisualElement>(field, "unity-text-input");
+        var unitTextElement = new TextElement
+        {
+            name = "numeric-field-unit-label",
+            text = unit
+        };
+        floatInput.Add(unitTextElement);
+    }
+
     #region Preview
 
     void InitializePreviewElements()
@@ -406,14 +417,18 @@ void InitializeVolumeElements()
         var volumeRandomizationMinField = UIToolkitUtilities.GetChildByName<FloatField>(m_VolumeRandomizationRangeField, "unity-x-input");
         var volumeRandomizationMaxField = UIToolkitUtilities.GetChildByName<FloatField>(m_VolumeRandomizationRangeField, "unity-y-input");
 
-        m_VolumeField.formatString = "0.# dB";
+        m_VolumeField.formatString = "0.#";
+        InsertUnitFieldForFloatField(m_VolumeField, "dB");
         m_VolumeField.isDelayed = true;
         volumeRandomizationMinField.isDelayed = true;
         volumeRandomizationMinField.label = "";
-        volumeRandomizationMinField.formatString = "0.# dB";
+        volumeRandomizationMinField.formatString = "0.#";
+        InsertUnitFieldForFloatField(volumeRandomizationMinField, "dB");
         volumeRandomizationMaxField.isDelayed = true;
         volumeRandomizationMaxField.label = "";
-        volumeRandomizationMaxField.formatString = "0.# dB";
+        volumeRandomizationMaxField.formatString = "0.#";
+        InsertUnitFieldForFloatField(volumeRandomizationMaxField, "dB");
+
     }
 
     void SubscribeToVolumeCallbacksAndEvents()
@@ -508,14 +523,17 @@ void InitializePitchElements()
         var pitchRandomizationMinField = UIToolkitUtilities.GetChildByName<FloatField>(m_PitchRandomizationRangeField, "unity-x-input");
         var pitchRandomizationMaxField = UIToolkitUtilities.GetChildByName<FloatField>(m_PitchRandomizationRangeField, "unity-y-input");
 
-        m_PitchField.formatString = "0 ct";
+        m_PitchField.formatString = "0";
+        InsertUnitFieldForFloatField(m_PitchField, "ct");
         m_PitchField.isDelayed = true;
         pitchRandomizationMinField.isDelayed = true;
         pitchRandomizationMinField.label = "";
-        pitchRandomizationMinField.formatString = "0 ct";
+        pitchRandomizationMinField.formatString = "0";
+        InsertUnitFieldForFloatField(pitchRandomizationMinField, "ct");
         pitchRandomizationMaxField.isDelayed = true;
         pitchRandomizationMaxField.label = "";
-        pitchRandomizationMaxField.formatString = "0 ct";
+        pitchRandomizationMaxField.formatString = "0";
+        InsertUnitFieldForFloatField(pitchRandomizationMaxField, "ct");
     }
 
     void SubscribeToPitchCallbacksAndEvents()
@@ -653,7 +671,10 @@ static void UpdateListElementName(Object element, Object clip = null)
 
     static VisualElement OnMakeListItem()
     {
-        return UIToolkitUtilities.LoadUxml("UXML/Audio/AudioContainerElement.uxml").Instantiate();
+        var element = UIToolkitUtilities.LoadUxml("UXML/Audio/AudioContainerElement.uxml").Instantiate();
+        var volumeField = UIToolkitUtilities.GetChildByName<FloatField>(element, "volume-field");
+        InsertUnitFieldForFloatField(volumeField, "dB");
+        return element;
     }
 
     void OnBindListItem(VisualElement element, int index)
@@ -665,7 +686,7 @@ void OnBindListItem(VisualElement element, int index)
         var enabledToggle = UIToolkitUtilities.GetChildByName<Toggle>(element, "enabled-toggle");
         var audioClipField = UIToolkitUtilities.GetChildByName<AudioContainerElementClipField>(element, "audio-clip-field");
         var volumeField = UIToolkitUtilities.GetChildByName<FloatField>(element, "volume-field");
-        volumeField.formatString = "0.# dB";
+        volumeField.formatString = "0.#";
 
         audioClipField.objectType = typeof(AudioClip);
 
@@ -996,14 +1017,18 @@ void InitializeAutomaticTriggerElements()
         m_AutomaticTriggerModeLabel = UIToolkitUtilities.GetChildByName<Label>(m_ContainerRootVisualElement, "automatic-trigger-mode-label");
         m_LoopLabel = UIToolkitUtilities.GetChildByName<Label>(m_ContainerRootVisualElement, "loop-label");
 
-        m_TimeField.formatString = "0.00 s";
+        m_TimeField.formatString = "0.00";
+        InsertUnitFieldForFloatField(m_TimeField, "s");
         m_TimeField.isDelayed = true;
         timeRandomizationMinField.isDelayed = true;
         timeRandomizationMinField.label = "";
         timeRandomizationMinField.formatString = "0.#";
+        InsertUnitFieldForFloatField(timeRandomizationMinField, "s");
         timeRandomizationMaxField.isDelayed = true;
         timeRandomizationMaxField.label = "";
         timeRandomizationMaxField.formatString = "0.#";
+        InsertUnitFieldForFloatField(timeRandomizationMaxField, "s");
+
         m_CountField.formatString = "0.#";
         m_CountField.isDelayed = true;
         countRandomizationMinField.isDelayed = true;
@@ -1151,6 +1176,11 @@ void OnCountRandomizationButtonClicked()
 
     void OnUndoRedoPerformed()
     {
+        if (m_ContainerRootVisualElement == null
+            || m_ContainerRootVisualElement.style.display == DisplayStyle.None
+            || State.AudioContainer == null)
+            return;
+
         if (m_CachedElements.Count != State.AudioContainer.elements.Length)
         {
             // Force a list rebuild when the list size has increased or it will not render correctly

Editor/Mono/Audio/Mixer/GUI/AudioMixerWindow.cs

@@ -238,8 +238,14 @@ static List<AudioMixerController> FindAllAudioMixerControllers()
             foreach (var prop in AssetDatabase.FindAllAssets(new SearchFilter() { classNames = new[] { "AudioMixerController" } }))
             {
                 var controller = prop.pptrValue as AudioMixerController;
+
                 if (controller)
-                    result.Add(controller);
+                {
+                    if (controller.IsInitialized())
+                        result.Add(controller);
+                    else
+                        Debug.LogError($"Can not display audio mixer window for '{controller.name}' as it has not been properly initialized. The mixer asset is possibly corrupted.");
+                }
             }
             return result;
         }
@@ -341,6 +347,12 @@ public void UndoRedoPerformed(in UndoRedoInfo info)
 
         void OnMixerControllerChanged()
         {
+            if (m_Controller != null && !m_Controller.IsInitialized())
+            {
+                Debug.LogError($"Can not display audio mixer window for '{m_Controller.name}' as it has not been properly initialized. The mixer asset is possibly corrupted.");
+                return;
+            }
+
             if (m_Controller)
                 m_Controller.ClearEventHandlers();
 
@@ -369,9 +381,15 @@ void DetectControllerChange()
             AudioMixerController oldController = m_Controller;
             if (Selection.activeObject is AudioMixerController)
                 m_Controller = Selection.activeObject as AudioMixerController;
+
             if (m_Controller != oldController)
             {
-                OnMixerControllerChanged();
+                if (m_Controller.IsInitialized())
+                    OnMixerControllerChanged();
+                else
+                {
+                    Debug.LogError($"Can not display audio mixer window for '{m_Controller.name}' as it has not been properly initialized. The mixer asset is possibly corrupted.");
+                }
             }
         }
 

Editor/Mono/Audio/UIElements/AudioRandomRangeSliderTracker.cs

@@ -20,12 +20,7 @@ class AudioRandomRangeSliderTracker : VisualElement
     Slider m_ParentSlider;
     float m_PreviousWidth;
     Vector2 m_Range = Vector2.zero;
-
-    public AudioRandomRangeSliderTracker()
-    {
-        RegisterCallback<GeometryChangedEvent>(OnGeometryChanged);
-    }
-
+    
     internal static AudioRandomRangeSliderTracker Create(Slider parentSlider, Vector2 range)
     {
         var dragContainer = UIToolkitUtilities.GetChildByName<VisualElement>(parentSlider, "unity-drag-container");
@@ -36,41 +31,45 @@ internal static AudioRandomRangeSliderTracker Create(Slider parentSlider, Vector
         dragContainer.Insert(insertionIndex, templateContainer);
         var rangeTracker = UIToolkitUtilities.GetChildAtIndex<AudioRandomRangeSliderTracker>(templateContainer, 0);
         rangeTracker.m_ParentSlider = parentSlider;
+        rangeTracker.m_ParentSlider.RegisterCallback<GeometryChangedEvent>(OnGeometryChanged);
         rangeTracker.SetRange(range);
         return rangeTracker;
     }
 
     internal void SetRange(Vector2 range)
     {
         m_Range = range;
+        var minValue = m_ParentSlider.value - Math.Abs(m_Range.x);
+        minValue = Mathf.Clamp(minValue, m_ParentSlider.lowValue, m_ParentSlider.highValue);
+        var maxValue = m_ParentSlider.value + Mathf.Abs(m_Range.y);
+        maxValue = Mathf.Clamp(maxValue, m_ParentSlider.lowValue, m_ParentSlider.highValue);
 
-        if (Mathf.Approximately(parent.contentRect.width, 0) || m_Range == Vector2.zero)
+        if (Mathf.Approximately(parent.contentRect.width, 0) || m_Range == Vector2.zero || Mathf.Approximately(minValue ,maxValue))
         {
-            style.visibility = Visibility.Hidden;
+            style.display = DisplayStyle.None;
             return;
         }
 
-        var minValue = m_ParentSlider.value - Math.Abs(m_Range.x);
-        minValue = Mathf.Clamp(minValue, m_ParentSlider.lowValue, m_ParentSlider.highValue);
-        var maxValue = m_ParentSlider.value + Mathf.Abs(m_Range.y);
-        maxValue = Mathf.Clamp(maxValue, m_ParentSlider.lowValue, m_ParentSlider.highValue);
         var minValueDelta = minValue - m_ParentSlider.lowValue;
         var maxValueDelta = maxValue - m_ParentSlider.lowValue;
-        var minValueFraction = minValueDelta / m_ParentSlider.range;
-        var maxValueFraction = maxValueDelta / m_ParentSlider.range;
-        style.marginLeft = minValueFraction * parent.contentRect.width;
-        style.marginRight = parent.contentRect.width - (maxValueFraction * parent.contentRect.width);
-        style.visibility = Visibility.Visible;
+
+        var pxPerVal = parent.contentRect.width / m_ParentSlider.range;
+        var translate = style.translate.value;
+        translate.x = pxPerVal * minValueDelta;
+        style.translate = translate;
+        style.width = (maxValueDelta - minValueDelta) * pxPerVal;
+        style.display = DisplayStyle.Flex;
     }
 
-    void OnGeometryChanged(GeometryChangedEvent evt)
+    static void OnGeometryChanged(GeometryChangedEvent evt)
     {
-        if (Mathf.Approximately(m_PreviousWidth, parent.contentRect.width))
+        var sliderTracker = UIToolkitUtilities.GetChildByClassName<AudioRandomRangeSliderTracker>(evt.elementTarget, "unity-audio-random-range-slider-tracker");
+        if (Mathf.Approximately(sliderTracker.m_PreviousWidth, sliderTracker.parent.contentRect.width))
         {
             return;
         }
 
-        m_PreviousWidth = parent.contentRect.width;
-        SetRange(m_Range);
+        sliderTracker.m_PreviousWidth = sliderTracker.parent.contentRect.width;
+        sliderTracker.SetRange(sliderTracker.m_Range);
     }
 }

Editor/Mono/Camera/EditorCameraUtils.bindings.cs

@@ -2,6 +2,9 @@
 // Copyright (c) Unity Technologies. For terms of use, see
 // https://unity3d.com/legal/licenses/Unity_Reference_Only_License
 
+using System;
+using Unity.Collections;
+using Unity.Collections.LowLevel.Unsafe;
 using UnityEngine;
 using UnityEngine.Bindings;
 using UnityEngine.Internal;
@@ -16,7 +19,19 @@ public static class EditorCameraUtils
         public static bool RenderToCubemap(this Camera camera, Texture target, int faceMask, StaticEditorFlags culledFlags)
             => RenderToCubemapImpl(camera, target, faceMask, culledFlags) == 1;
 
+        public static unsafe void GetRenderersFilteringResults(ReadOnlySpan<int> rendererIDs, Span<bool> results)
+        {
+            if (rendererIDs.Length != results.Length)
+                throw new ArgumentException("rendererIDs and results NativeArrays don't match in length.");
+
+            GetRenderersFilteringResultsImpl(rendererIDs, results);
+        }
+
         [FreeFunction("EditorCameraUtilsScripting::RenderToCubemap")]
         static extern int RenderToCubemapImpl(Camera camera, Texture target, [DefaultValue("63")] int faceMask, StaticEditorFlags culledFlags);
+
+        [FreeFunction("EditorCameraUtilsScripting::GetRenderersFilteringResults")]
+        static extern unsafe void GetRenderersFilteringResultsImpl(ReadOnlySpan<int> rendererIDs, Span<bool> results);
+
     }
 }

Editor/Mono/EditorApplication.cs

@@ -267,7 +267,7 @@ public static event Action<PlayModeStateChange> playModeStateChanged
         [Obsolete("Use EditorApplication.playModeStateChanged and/or EditorApplication.pauseStateChanged")]
         public static CallbackFunction playmodeStateChanged;
 
-        // Global key up/down event that was not handled by anyone
+        // Global key up/down or mouse up/down/drag events that were not handled by anyone
         internal static CallbackFunction globalEventHandler;
 
         // Returns true when the pressed keys are defined in the Trigger

Editor/Mono/EditorGUI.cs

@@ -6605,7 +6605,7 @@ public static void HelpBox(Rect position, GUIContent content)
             if (content.image != null)
             {
                 var labelRect = position;
-                int iconSize = content.image.width + EditorStyles.helpBox.padding.right;
+                int iconSize = (int) (content.image.width / EditorGUIUtility.pixelsPerPoint) + EditorStyles.helpBox.padding.right;
                 labelRect.x += iconSize;
                 labelRect.width -= iconSize;
 

Editor/Mono/EditorWindow.cs

@@ -437,8 +437,7 @@ static public EditorWindow mouseOverWindow
                     return null;
             }
         }
-
-
+        
         internal int GetNumTabs()
         {
             DockArea da = m_Parent as DockArea;