Re-factored some common code in MotionBlur.Render to single utility function

Author: JoJo2nd

PostProcessing/Runtime/Effects/MotionBlur.cs

@@ -58,6 +58,22 @@ public override DepthTextureMode GetCameraFlags()
             return DepthTextureMode.Depth | DepthTextureMode.MotionVectors;
         }
 
+        private void CreateTemporaryRT(PostProcessRenderContext context, int nameID, int width, int height, RenderTextureFormat RTFormat)
+        {
+#if !UNITY_2019_1_OR_NEWER
+            bool useDynamicRes = context.camera.allowDynamicResolution;
+#endif
+            var rtDesc = context.GetDescriptor(0, RTFormat, RenderTextureReadWrite.Linear);
+            rtDesc.width = width;
+            rtDesc.height = height;
+            var cmd = context.command;
+#if UNITY_2019_1_OR_NEWER
+            cmd.GetTemporaryRT(nameID, rtDesc, FilterMode.Point);
+#else
+            cmd.GetTemporaryRT(nameID, rtDesc.width, rtDesc.height, rtDesc.depthBufferBits, FilterMode.Point, rtDesc.colorFormat, RenderTextureReadWrite.Linear, rtDesc.msaaSamples, rtDesc.enableRandomWrite, rtDesc.memoryless, useDynamicRes);
+#endif
+        }
+
         public override void Render(PostProcessRenderContext context)
         {
             var cmd = context.command;
@@ -74,9 +90,6 @@ public override void Render(PostProcessRenderContext context)
             var packedRTFormat = RenderTextureFormat.ARGB2101010.IsSupported()
                 ? RenderTextureFormat.ARGB2101010
                 : RenderTextureFormat.ARGB32;
-#if !UNITY_2019_1_OR_NEWER
-            bool useDynamicRes = context.camera.allowDynamicResolution;
-#endif
 
             var sheet = context.propertySheets.Get(context.resources.shaders.motionBlur);
             cmd.BeginSample("MotionBlur");
@@ -95,49 +108,23 @@ public override void Render(PostProcessRenderContext context)
             sheet.properties.SetFloat(ShaderIDs.RcpMaxBlurRadius, 1f / maxBlurPixels);
 
             int vbuffer = ShaderIDs.VelocityTex;
-            var rtDesc = context.GetDescriptor(0, packedRTFormat, RenderTextureReadWrite.Linear);
-#if UNITY_2019_1_OR_NEWER
-            cmd.GetTemporaryRT(vbuffer, rtDesc, FilterMode.Point);
-#else
-            cmd.GetTemporaryRT(vbuffer, rtDesc.width, rtDesc.height, rtDesc.depthBufferBits, FilterMode.Point, rtDesc.colorFormat, RenderTextureReadWrite.Linear, rtDesc.msaaSamples, rtDesc.enableRandomWrite, rtDesc.memoryless, useDynamicRes);
-#endif
+            CreateTemporaryRT(context, vbuffer, context.width, context.height, packedRTFormat);
             cmd.BlitFullscreenTriangle(BuiltinRenderTextureType.None, vbuffer, sheet, (int)Pass.VelocitySetup);
 
             // Pass 2 - First TileMax filter (1/2 downsize)
             int tile2 = ShaderIDs.Tile2RT;
-            rtDesc = context.GetDescriptor(0, vectorRTFormat, RenderTextureReadWrite.Linear);
-            rtDesc.width = context.width / 2;
-            rtDesc.height = context.height / 2;
-#if UNITY_2019_1_OR_NEWER
-            cmd.GetTemporaryRT(tile2, rtDesc, FilterMode.Point);
-#else
-            cmd.GetTemporaryRT(tile2, rtDesc.width, rtDesc.height, rtDesc.depthBufferBits, FilterMode.Point, rtDesc.colorFormat, RenderTextureReadWrite.Linear, rtDesc.msaaSamples, rtDesc.enableRandomWrite, rtDesc.memoryless, useDynamicRes);
-#endif
+            CreateTemporaryRT(context, tile2, context.width / 2, context.height / 2, vectorRTFormat);
             cmd.BlitFullscreenTriangle(vbuffer, tile2, sheet, (int)Pass.TileMax1);
 
             // Pass 3 - Second TileMax filter (1/2 downsize)
             int tile4 = ShaderIDs.Tile4RT;
-            rtDesc = context.GetDescriptor(0, vectorRTFormat, RenderTextureReadWrite.Linear);
-            rtDesc.width = context.width / 4;
-            rtDesc.height = context.height / 4;
-#if UNITY_2019_1_OR_NEWER
-            cmd.GetTemporaryRT(tile4, rtDesc, FilterMode.Point);
-#else
-            cmd.GetTemporaryRT(tile4, rtDesc.width, rtDesc.height, rtDesc.depthBufferBits, FilterMode.Point, rtDesc.colorFormat, RenderTextureReadWrite.Linear, rtDesc.msaaSamples, rtDesc.enableRandomWrite, rtDesc.memoryless, useDynamicRes);
-#endif
+            CreateTemporaryRT(context, tile4, context.width / 4, context.height / 4, vectorRTFormat);
             cmd.BlitFullscreenTriangle(tile2, tile4, sheet, (int)Pass.TileMax2);
             cmd.ReleaseTemporaryRT(tile2);
 
             // Pass 4 - Third TileMax filter (1/2 downsize)
             int tile8 = ShaderIDs.Tile8RT;
-            rtDesc = context.GetDescriptor(0, vectorRTFormat, RenderTextureReadWrite.Linear);
-            rtDesc.width = context.width / 8;
-            rtDesc.height = context.height / 8;
-#if UNITY_2019_1_OR_NEWER
-            cmd.GetTemporaryRT(tile8, rtDesc, FilterMode.Point);
-#else
-            cmd.GetTemporaryRT(tile8, rtDesc.width, rtDesc.height, rtDesc.depthBufferBits, FilterMode.Point, rtDesc.colorFormat, RenderTextureReadWrite.Linear, rtDesc.msaaSamples, rtDesc.enableRandomWrite, rtDesc.memoryless, useDynamicRes);
-#endif
+            CreateTemporaryRT(context, tile8, context.width / 8, context.height / 8, vectorRTFormat);
             cmd.BlitFullscreenTriangle(tile4, tile8, sheet, (int)Pass.TileMax2);
             cmd.ReleaseTemporaryRT(tile4);
 
@@ -147,29 +134,13 @@ public override void Render(PostProcessRenderContext context)
             sheet.properties.SetFloat(ShaderIDs.TileMaxLoop, (int)(tileSize / 8f));
 
             int tile = ShaderIDs.TileVRT;
-            rtDesc = context.GetDescriptor(0, vectorRTFormat, RenderTextureReadWrite.Linear);
-            rtDesc.width = context.width / tileSize;
-            rtDesc.height = context.height / tileSize;
-#if UNITY_2019_1_OR_NEWER
-            cmd.GetTemporaryRT(tile, rtDesc, FilterMode.Point);
-#else
-            cmd.GetTemporaryRT(tile, rtDesc.width, rtDesc.height, rtDesc.depthBufferBits, FilterMode.Point, rtDesc.colorFormat, RenderTextureReadWrite.Linear, rtDesc.msaaSamples, rtDesc.enableRandomWrite, rtDesc.memoryless, useDynamicRes);
-#endif
+            CreateTemporaryRT(context, tile, context.width / tileSize, context.height / tileSize, vectorRTFormat);
             cmd.BlitFullscreenTriangle(tile8, tile, sheet, (int)Pass.TileMaxV);
             cmd.ReleaseTemporaryRT(tile8);
 
             // Pass 6 - NeighborMax filter
-            rtDesc = context.GetDescriptor(0, vectorRTFormat, RenderTextureReadWrite.Linear);
             int neighborMax = ShaderIDs.NeighborMaxTex;
-            int neighborMaxWidth = context.width / tileSize;
-            int neighborMaxHeight = context.height / tileSize;
-            rtDesc.width = neighborMaxWidth;
-            rtDesc.height = neighborMaxHeight; 
-#if UNITY_2019_1_OR_NEWER
-            cmd.GetTemporaryRT(neighborMax, rtDesc, FilterMode.Point);
-#else
-            cmd.GetTemporaryRT(neighborMax, rtDesc.width, rtDesc.height, rtDesc.depthBufferBits, FilterMode.Point, rtDesc.colorFormat, RenderTextureReadWrite.Linear, rtDesc.msaaSamples, rtDesc.enableRandomWrite, rtDesc.memoryless, useDynamicRes);
-#endif
+            CreateTemporaryRT(context, neighborMax, context.width / tileSize, context.height / tileSize, vectorRTFormat);
             cmd.BlitFullscreenTriangle(tile, neighborMax, sheet, (int)Pass.NeighborMax);
             cmd.ReleaseTemporaryRT(tile);