Initial support across most effects.

JoJo2nd · JoJo2nd · commit 49af5e0f3065 · 2019-07-12T09:59:31.000+01:00
+ SMAA not tested.
 + TAA uses dynamically sized buffers but doesn't work correctly.
 + Any pass that uses texel size in the shader is incorrect (texel size calculation is wrong in native side)
 + Need to double check MotionBlur
diff --git a/PostProcessing/Runtime/Effects/MotionBlur.cs b/PostProcessing/Runtime/Effects/MotionBlur.cs
@@ -92,27 +92,33 @@ public override void Render(PostProcessRenderContext context)
             sheet.properties.SetFloat(ShaderIDs.RcpMaxBlurRadius, 1f / maxBlurPixels);
 
             int vbuffer = ShaderIDs.VelocityTex;
-            cmd.GetTemporaryRT(vbuffer, context.width, context.height, 0, FilterMode.Point,
-                packedRTFormat, RenderTextureReadWrite.Linear);
+            var rtDesc = context.GetDescriptor(0, packedRTFormat, RenderTextureReadWrite.Linear);
+            cmd.GetTemporaryRT(vbuffer, rtDesc, FilterMode.Point);
             cmd.BlitFullscreenTriangle(BuiltinRenderTextureType.None, vbuffer, sheet, (int)Pass.VelocitySetup);
 
             // Pass 2 - First TileMax filter (1/2 downsize)
             int tile2 = ShaderIDs.Tile2RT;
-            cmd.GetTemporaryRT(tile2, context.width / 2, context.height / 2, 0, FilterMode.Point,
-                vectorRTFormat, RenderTextureReadWrite.Linear);
+            rtDesc = context.GetDescriptor(0, vectorRTFormat, RenderTextureReadWrite.Linear);
+            rtDesc.width = context.width / 2;
+            rtDesc.height = context.height / 2;
+            cmd.GetTemporaryRT(tile2, rtDesc, FilterMode.Point);
             cmd.BlitFullscreenTriangle(vbuffer, tile2, sheet, (int)Pass.TileMax1);
 
             // Pass 3 - Second TileMax filter (1/2 downsize)
             int tile4 = ShaderIDs.Tile4RT;
-            cmd.GetTemporaryRT(tile4, context.width / 4, context.height / 4, 0, FilterMode.Point,
-                vectorRTFormat, RenderTextureReadWrite.Linear);
+            rtDesc = context.GetDescriptor(0, vectorRTFormat, RenderTextureReadWrite.Linear);
+            rtDesc.width = context.width / 4;
+            rtDesc.height = context.height / 4;
+            cmd.GetTemporaryRT(tile4, rtDesc, FilterMode.Point);
             cmd.BlitFullscreenTriangle(tile2, tile4, sheet, (int)Pass.TileMax2);
             cmd.ReleaseTemporaryRT(tile2);
 
             // Pass 4 - Third TileMax filter (1/2 downsize)
             int tile8 = ShaderIDs.Tile8RT;
-            cmd.GetTemporaryRT(tile8, context.width / 8, context.height / 8, 0, FilterMode.Point,
-                vectorRTFormat, RenderTextureReadWrite.Linear);
+            rtDesc = context.GetDescriptor(0, vectorRTFormat, RenderTextureReadWrite.Linear);
+            rtDesc.width = context.width / 8;
+            rtDesc.height = context.height / 8;
+            cmd.GetTemporaryRT(tile8, rtDesc, FilterMode.Point);
             cmd.BlitFullscreenTriangle(tile4, tile8, sheet, (int)Pass.TileMax2);
             cmd.ReleaseTemporaryRT(tile4);
 
@@ -122,17 +128,21 @@ public override void Render(PostProcessRenderContext context)
             sheet.properties.SetFloat(ShaderIDs.TileMaxLoop, (int)(tileSize / 8f));
 
             int tile = ShaderIDs.TileVRT;
-            cmd.GetTemporaryRT(tile, context.width / tileSize, context.height / tileSize, 0,
-                FilterMode.Point, vectorRTFormat, RenderTextureReadWrite.Linear);
+            rtDesc = context.GetDescriptor(0, vectorRTFormat, RenderTextureReadWrite.Linear);
+            rtDesc.width = context.width / tileSize;
+            rtDesc.height = context.height / tileSize;
+            cmd.GetTemporaryRT(tile, rtDesc, FilterMode.Point);
             cmd.BlitFullscreenTriangle(tile8, tile, sheet, (int)Pass.TileMaxV);
             cmd.ReleaseTemporaryRT(tile8);
 
             // Pass 6 - NeighborMax filter
+            rtDesc = context.GetDescriptor(0, vectorRTFormat, RenderTextureReadWrite.Linear);
             int neighborMax = ShaderIDs.NeighborMaxTex;
             int neighborMaxWidth = context.width / tileSize;
             int neighborMaxHeight = context.height / tileSize;
-            cmd.GetTemporaryRT(neighborMax, neighborMaxWidth, neighborMaxHeight, 0,
-                FilterMode.Point, vectorRTFormat, RenderTextureReadWrite.Linear);
+            rtDesc.width = neighborMaxWidth;
+            rtDesc.height = neighborMaxHeight; 
+            cmd.GetTemporaryRT(neighborMax, rtDesc, FilterMode.Point);
             cmd.BlitFullscreenTriangle(tile, neighborMax, sheet, (int)Pass.NeighborMax);
             cmd.ReleaseTemporaryRT(tile);
 
diff --git a/PostProcessing/Runtime/Effects/MultiScaleVO.cs b/PostProcessing/Runtime/Effects/MultiScaleVO.cs
@@ -42,6 +42,9 @@ enum Pass
 
         readonly int[] m_Widths = new int[7];
         readonly int[] m_Heights = new int[7];
+        // Scaled dimensions used with dynamic resolution
+        readonly int[] m_ScaledWidths = new int[7];
+        readonly int[] m_ScaledHeights = new int[7];
 
         AmbientOcclusion m_Settings;
         PropertySheet m_PropertySheet;
@@ -79,8 +82,8 @@ void Alloc(CommandBuffer cmd, int id, MipLevel size, RenderTextureFormat format,
             int sizeId = (int)size;
             cmd.GetTemporaryRT(id, new RenderTextureDescriptor
             {
-                width = m_Widths[sizeId],
-                height = m_Heights[sizeId],
+                width = m_ScaledWidths[sizeId],
+                height = m_ScaledHeights[sizeId],
                 colorFormat = format,
                 depthBufferBits = 0,
                 volumeDepth = 1,
@@ -97,8 +100,8 @@ void AllocArray(CommandBuffer cmd, int id, MipLevel size, RenderTextureFormat fo
             int sizeId = (int)size;
             cmd.GetTemporaryRT(id, new RenderTextureDescriptor
             {
-                width = m_Widths[sizeId],
-                height = m_Heights[sizeId],
+                width = m_ScaledWidths[sizeId],
+                height = m_ScaledHeights[sizeId],
                 colorFormat = format,
                 depthBufferBits = 0,
                 volumeDepth = 16,
@@ -135,26 +138,30 @@ float CalculateTanHalfFovHeight(Camera camera)
 
         Vector2 GetSize(MipLevel mip)
         {
-            return new Vector2(m_Widths[(int)mip], m_Heights[(int)mip]);
+            return new Vector2(m_ScaledWidths[(int)mip], m_ScaledHeights[(int)mip]);
         }
 
         Vector3 GetSizeArray(MipLevel mip)
         {
-            return new Vector3(m_Widths[(int)mip], m_Heights[(int)mip], 16);
+            return new Vector3(m_ScaledWidths[(int)mip], m_ScaledHeights[(int)mip], 16);
         }
 
         public void GenerateAOMap(CommandBuffer cmd, Camera camera, RenderTargetIdentifier destination, RenderTargetIdentifier? depthMap, bool invert, bool isMSAA)
         {
-            // Base size
+            // Base size          
             m_Widths[0] = camera.pixelWidth * (RuntimeUtilities.isSinglePassStereoEnabled ? 2 : 1);
             m_Heights[0] = camera.pixelHeight;
-
+            m_ScaledWidths[0] = camera.scaledPixelWidth * (RuntimeUtilities.isSinglePassStereoEnabled ? 2 : 1);
+            m_ScaledHeights[0] = camera.scaledPixelHeight;
+            
             // L1 -> L6 sizes
             for (int i = 1; i < 7; i++)
             {
                 int div = 1 << i;
                 m_Widths[i]  = (m_Widths[0]  + (div - 1)) / div;
                 m_Heights[i] = (m_Heights[0] + (div - 1)) / div;
+                m_ScaledWidths[i]  = (m_ScaledWidths[0]  + (div - 1)) / div;
+                m_ScaledHeights[i] = (m_ScaledHeights[0] + (div - 1)) / div;
             }
 
             // Allocate temporary textures
@@ -179,7 +186,7 @@ public void GenerateAOMap(CommandBuffer cmd, Camera camera, RenderTargetIdentifi
         }
 
         void PushAllocCommands(CommandBuffer cmd, bool isMSAA)
-        {
+        { 
             if(isMSAA)
             {
                 Alloc(cmd, ShaderIDs.LinearDepth, MipLevel.Original, RenderTextureFormat.RGHalf, true);
@@ -266,7 +273,7 @@ void PushDownsampleCommands(CommandBuffer cmd, Camera camera, RenderTargetIdenti
             cmd.SetComputeVectorParam(cs, "ZBufferParams", CalculateZBufferParams(camera));
             cmd.SetComputeTextureParam(cs, kernel, "Depth", depthMapId);
 
-            cmd.DispatchCompute(cs, kernel, m_Widths[(int)MipLevel.L4], m_Heights[(int)MipLevel.L4], 1);
+            cmd.DispatchCompute(cs, kernel, m_ScaledWidths[(int)MipLevel.L4], m_ScaledHeights[(int)MipLevel.L4], 1);
 
             if (needDepthMapRelease)
                 Release(cmd, ShaderIDs.DepthCopy);
@@ -281,7 +288,7 @@ void PushDownsampleCommands(CommandBuffer cmd, Camera camera, RenderTargetIdenti
             cmd.SetComputeTextureParam(cs, kernel, "DS8xAtlas", ShaderIDs.TiledDepth3);
             cmd.SetComputeTextureParam(cs, kernel, "DS16xAtlas", ShaderIDs.TiledDepth4);
 
-            cmd.DispatchCompute(cs, kernel, m_Widths[(int)MipLevel.L6], m_Heights[(int)MipLevel.L6], 1);
+            cmd.DispatchCompute(cs, kernel, m_ScaledWidths[(int)MipLevel.L6], m_ScaledHeights[(int)MipLevel.L6], 1);
         }
 
         void PushRenderCommands(CommandBuffer cmd, int source, int destination, Vector3 sourceSize, float tanHalfFovH, bool isMSAA)
@@ -451,15 +458,17 @@ void PreparePropertySheet(PostProcessRenderContext context)
 
         void CheckAOTexture(PostProcessRenderContext context)
         {
-            if (m_AmbientOnlyAO == null || !m_AmbientOnlyAO.IsCreated() || m_AmbientOnlyAO.width != context.width || m_AmbientOnlyAO.height != context.height)
+            if (m_AmbientOnlyAO == null || !m_AmbientOnlyAO.IsCreated() || m_AmbientOnlyAO.width != context.width || m_AmbientOnlyAO.height != context.height ||
+                m_AmbientOnlyAO.useDynamicScale != context.camera.allowDynamicResolution)
             {
                 RuntimeUtilities.Destroy(m_AmbientOnlyAO);
 
                 m_AmbientOnlyAO = new RenderTexture(context.width, context.height, 0, RenderTextureFormat.R8, RenderTextureReadWrite.Linear)
                 {
                     hideFlags = HideFlags.DontSave,
                     filterMode = FilterMode.Point,
-                    enableRandomWrite = true
+                    enableRandomWrite = true,
+                    useDynamicScale = context.camera.allowDynamicResolution
                 };
                 m_AmbientOnlyAO.Create();
             }
diff --git a/PostProcessing/Runtime/Effects/SubpixelMorphologicalAntialiasing.cs b/PostProcessing/Runtime/Effects/SubpixelMorphologicalAntialiasing.cs
@@ -63,8 +63,8 @@ internal void Render(PostProcessRenderContext context)
             var cmd = context.command;
             cmd.BeginSample("SubpixelMorphologicalAntialiasing");
 
-            cmd.GetTemporaryRT(ShaderIDs.SMAA_Flip, context.width, context.height, 0, FilterMode.Bilinear, context.sourceFormat, RenderTextureReadWrite.Linear);
-            cmd.GetTemporaryRT(ShaderIDs.SMAA_Flop, context.width, context.height, 0, FilterMode.Bilinear, context.sourceFormat, RenderTextureReadWrite.Linear);
+            cmd.GetTemporaryRT(ShaderIDs.SMAA_Flip, context.width, context.height, 0, FilterMode.Bilinear, context.sourceFormat, RenderTextureReadWrite.Linear, 1, false, RenderTextureMemoryless.None, context.camera.allowDynamicResolution);
+            cmd.GetTemporaryRT(ShaderIDs.SMAA_Flop, context.width, context.height, 0, FilterMode.Bilinear, context.sourceFormat, RenderTextureReadWrite.Linear, 1, false, RenderTextureMemoryless.None, context.camera.allowDynamicResolution);
 
             cmd.BlitFullscreenTriangle(context.source, ShaderIDs.SMAA_Flip, sheet, (int)Pass.EdgeDetection + (int)quality, true);
             cmd.BlitFullscreenTriangle(ShaderIDs.SMAA_Flip, ShaderIDs.SMAA_Flop, sheet, (int)Pass.BlendWeights + (int)quality);
diff --git a/PostProcessing/Runtime/PostProcessLayer.cs b/PostProcessing/Runtime/PostProcessLayer.cs
@@ -244,7 +244,7 @@ void InitLegacy()
         [ImageEffectUsesCommandBuffer]
         void OnRenderImage(RenderTexture src, RenderTexture dst)
         {
-            if (finalBlitToCameraTarget)
+            if (finalBlitToCameraTarget && (m_Camera.allowDynamicResolution && ScalableBufferManager.heightScaleFactor == 1.0 && ScalableBufferManager.widthScaleFactor == 1.0))
                 RenderTexture.active = dst; // silence warning
             else
                 Graphics.Blit(src, dst);
@@ -607,7 +607,7 @@ void BuildCommandBuffers()
             context.destination = cameraTarget;
 
 #if UNITY_2019_1_OR_NEWER
-            if (finalBlitToCameraTarget && !RuntimeUtilities.scriptableRenderPipelineActive)
+            if (finalBlitToCameraTarget && !RuntimeUtilities.scriptableRenderPipelineActive && (!m_Camera.allowDynamicResolution || (ScalableBufferManager.heightScaleFactor == 1.0 && ScalableBufferManager.widthScaleFactor == 1.0)))
             {
                 if (m_Camera.targetTexture)
                 {
diff --git a/PostProcessing/Runtime/PostProcessRenderContext.cs b/PostProcessing/Runtime/PostProcessRenderContext.cs
@@ -322,7 +322,7 @@ public void PushDebugOverlay(CommandBuffer cmd, RenderTargetIdentifier source, P
         // size usages explicit
 #if UNITY_2017_2_OR_NEWER
         RenderTextureDescriptor m_sourceDescriptor;
-        RenderTextureDescriptor GetDescriptor(int depthBufferBits = 0, RenderTextureFormat colorFormat = RenderTextureFormat.Default, RenderTextureReadWrite readWrite = RenderTextureReadWrite.Default)
+        public RenderTextureDescriptor GetDescriptor(int depthBufferBits = 0, RenderTextureFormat colorFormat = RenderTextureFormat.Default, RenderTextureReadWrite readWrite = RenderTextureReadWrite.Default)
         {
             var modifiedDesc = new RenderTextureDescriptor(m_sourceDescriptor.width, m_sourceDescriptor.height,
                                                                                 m_sourceDescriptor.colorFormat, depthBufferBits);
@@ -337,6 +337,11 @@ RenderTextureDescriptor GetDescriptor(int depthBufferBits = 0, RenderTextureForm
             modifiedDesc.enableRandomWrite = m_sourceDescriptor.enableRandomWrite;
             modifiedDesc.shadowSamplingMode = m_sourceDescriptor.shadowSamplingMode;
 
+#if UNITY_2019_1_OR_NEWER     
+            if (m_Camera.allowDynamicResolution)           
+                modifiedDesc.useDynamicScale = true;
+#endif
+
             if (colorFormat != RenderTextureFormat.Default)
                 modifiedDesc.colorFormat = colorFormat;
 
@@ -380,8 +385,12 @@ public void GetScreenSpaceTemporaryRT(CommandBuffer cmd, int nameID,
             //intermediates in VR are unchanged
             if (stereoActive && desc.dimension == Rendering.TextureDimension.Tex2DArray)
                desc.dimension = Rendering.TextureDimension.Tex2D;
-          
+            
+#if UNITY_2019_1_OR_NEWER
             cmd.GetTemporaryRT(nameID, desc, filter);
+#else
+            cmd.GetTemporaryRT(nameID, desc.width, desc.height, desc.depthBufferBits, filter, desc.colorFormat, readWrite, desc.msaaSamples, desc.enableRandomWrite, desc.memoryless, m_Camera.allowDynamicResolution);
+#endif
 #else
             int actualWidth = width;
             int actualHeight = height;

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ void InitLegacy()`
`244`	`244`	`[ImageEffectUsesCommandBuffer]`
`245`	`245`	`void OnRenderImage(RenderTexture src, RenderTexture dst)`
`246`	`246`	`{`
`247`		`- if (finalBlitToCameraTarget)`
	`247`	`+ if (finalBlitToCameraTarget && (m_Camera.allowDynamicResolution && ScalableBufferManager.heightScaleFactor == 1.0 && ScalableBufferManager.widthScaleFactor == 1.0))`
`248`	`248`	`RenderTexture.active = dst; // silence warning`
`249`	`249`	`else`
`250`	`250`	`Graphics.Blit(src, dst);`
`@@ -607,7 +607,7 @@ void BuildCommandBuffers()`
`607`	`607`	`context.destination = cameraTarget;`
`608`	`608`
`609`	`609`	`#if UNITY_2019_1_OR_NEWER`
`610`		`- if (finalBlitToCameraTarget && !RuntimeUtilities.scriptableRenderPipelineActive)`
	`610`	`+ if (finalBlitToCameraTarget && !RuntimeUtilities.scriptableRenderPipelineActive && (!m_Camera.allowDynamicResolution \|\| (ScalableBufferManager.heightScaleFactor == 1.0 && ScalableBufferManager.widthScaleFactor == 1.0)))`
`611`	`611`	`{`
`612`	`612`	`if (m_Camera.targetTexture)`
`613`	`613`	`{`