NEW: Duplication via control (win) or command (mac) and "D" key (ISX-1542) (#1767)

* implemented duplication via control (win) or command (mac) key

* use control not only for windows

* minor refactoring and added changelog

Author: ritamerkl

Packages/com.unity.inputsystem/CHANGELOG.md

@@ -21,6 +21,7 @@ however, it has to be formatted properly to pass verification tests.
 
 ### Added
 - Support for [Game rotation vector](https://developer.android.com/reference/android/hardware/Sensor#TYPE_GAME_ROTATION_VECTOR) sensor on Android
+- Duplicate Input Action Items in the new Input Action Asset Editor with Ctrl+D (Windows) or Cmd+D (Mac)
 
 ### Fixed
 - Partially fixed case ISX-1357 (Investigate performance regressing over time).  A sample showed that leaving an InputActionMap enabled could lead to an internal list of listeners growing.  This leads to slow-down, so we now warn if we think this is happening.

Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/ActionMapsView.cs

@@ -119,6 +119,8 @@ private void OnKeyDownEvent(KeyDownEvent e)
                 OnKeyDownEventForRename();
             else if (e.keyCode == KeyCode.Delete)
                 OnKeyDownEventForDelete();
+            else if (IsDuplicateShortcutPressed(e))
+                OnKeyDownEventForDuplicate();
         }
 
         private void OnKeyDownEventForRename()
@@ -133,6 +135,11 @@ private void OnKeyDownEventForDelete()
             item.DeleteItem();
         }
 
+        private void OnKeyDownEventForDuplicate()
+        {
+            ((InputActionMapsTreeViewItem)m_ListView.GetRootElementForIndex(m_ListView.selectedIndex))?.DuplicateItem();
+        }
+
         private readonly CollectionViewSelectionChangeFilter m_ListViewSelectionChangeFilter;
         private bool m_EnterRenamingMode;
         private readonly VisualElement m_Root;

Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/ActionsTreeView.cs

@@ -252,6 +252,8 @@ private void OnKeyDownEvent(KeyDownEvent e)
                 OnKeyDownEventForRename();
             else if (e.keyCode == KeyCode.Delete)
                 OnKeyDownEventForDelete();
+            else if (IsDuplicateShortcutPressed(e))
+                OnKeyDownEventForDuplicate();
         }
 
         private void OnKeyDownEventForRename()
@@ -268,6 +270,11 @@ private void OnKeyDownEventForDelete()
             item?.DeleteItem();
         }
 
+        private void OnKeyDownEventForDuplicate()
+        {
+            m_ActionsTreeView.GetRootElementForIndex(m_ActionsTreeView.selectedIndex)?.Q<InputActionsTreeViewItem>()?.DuplicateItem();
+        }
+
         internal class ViewState
         {
             public List<TreeViewItemData<ActionOrBindingData>> treeViewData;

Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/ViewBase.cs

@@ -1,6 +1,7 @@
 #if UNITY_EDITOR && UNITY_INPUT_SYSTEM_PROJECT_WIDE_ACTIONS
 using System;
 using System.Collections.Generic;
+using UnityEngine.UIElements;
 
 namespace UnityEngine.InputSystem.Editor
 {
@@ -33,7 +34,8 @@ public void UpdateView(InputActionsEditorState state)
         {
             if (m_ViewStateSelector == null)
             {
-                Debug.LogWarning($"View '{GetType().Name}' has no selector and will not render. Create a selector for the " +
+                Debug.LogWarning(
+                    $"View '{GetType().Name}' has no selector and will not render. Create a selector for the " +
                     $"view using the CreateSelector method.");
                 return;
             }
@@ -111,6 +113,16 @@ protected void CreateSelector<T1, T2, T3>(
         private IViewStateSelector<TViewState> m_ViewStateSelector;
         private IList<IView> m_ChildViews;
         private bool m_IsFirstUpdate = true;
+
+
+        protected bool IsDuplicateShortcutPressed(KeyDownEvent keyDownEvent)
+        {
+#if UNITY_STANDALONE_OSX
+            return keyDownEvent.keyCode == KeyCode.D && keyDownEvent.modifiers == EventModifiers.Command;
+#else
+            return keyDownEvent.keyCode == KeyCode.D && keyDownEvent.modifiers == EventModifiers.Control;
+#endif
+        }
     }
 
     internal class ViewStateSelector<TReturn> : IViewStateSelector<TReturn>