Skip to content

Commit 96f5aa7

Browse files
authored
FIX: Selection highlight lingering after clicking save button (ISX-1482). (#1818)
1 parent 176e46f commit 96f5aa7

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

Packages/com.unity.inputsystem/CHANGELOG.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ however, it has to be formatted properly to pass verification tests.
1818
- [`InputAction.activeValueType`](xref:UnityEngine.InputSystem.InputAction.activeValueType) returns the `Type` expected by `ReadValue<TValue>` based on the currently active control that is driving the action.
1919
- [`InputAction.GetMagnitude`](xref:UnityEngine.InputSystem.InputAction.GetMagnitude) returns the current amount of actuation of the control that is driving the action.
2020
- [`InputAction.WasCompletedThisFrame`](xref:UnityEngine.InputSystem.InputAction.WasCompletedThisFrame) returns `true` on the frame that the action stopped being in the performed phase. This allows for similar functionality to [`WasPressedThisFrame`](xref:UnityEngine.InputSystem.InputAction.WasPressedThisFrame)/[`WasReleasedThisFrame`](xref:UnityEngine.InputSystem.InputAction.WasReleasedThisFrame) when paired with [`WasPerformedThisFrame`](xref:UnityEngine.InputSystem.InputAction.WasPerformedThisFrame) except it is directly based on the interactions driving the action. For example, you can use it to distinguish between the button being released or whether it was released after being held for long enough to perform when using the Hold interaction.
21+
- Added Copy, Paste and Cut support for Action Maps, Actions and Bindings via context menu and key command shortcuts.
22+
- Added Dual Sense Edge controller to be mapped to the same layout as the Dual Sense controller
2123

2224
### Fixed
2325
- Fixed syntax of code examples in API documentation for [`AxisComposite`](xref:UnityEngine.InputSystem.Composites.AxisComposite).
@@ -30,10 +32,7 @@ however, it has to be formatted properly to pass verification tests.
3032
- Fixed possible exceptions thrown when deleting and adding Action Maps.
3133
- Fixed potential race condition on access to GCHandle in DefferedResolutionOfBindings and halved number of calls to GCHandle resolution [ISXB-726](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-726)
3234
- Fixed issue where composite part dropdown manipulates binding path and leaves composite part field unchanged.
33-
34-
### Added
35-
- Added Copy, Paste and Cut support for Action Maps, Actions and Bindings via context menu and key command shortcuts.
36-
- Added Dual Sense Edge controller to be mapped to the same layout as the Dual Sense controller
35+
- Fixed lingering highlight effect on Save Asset button after clicking.
3736

3837
## [1.8.0-pre.2] - 2023-11-09
3938

Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/InputActionsEditorView.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,11 @@ private void OnReset()
8484
private void OnSaveButton()
8585
{
8686
Dispatch(Commands.SaveAsset(postSaveAction));
87+
88+
// Don't let focus linger after clicking (ISX-1482). Ideally this would be only applied on mouse click,
89+
// rather than if the user is using tab to navigate UI, but there doesn't seem to be a way to differentiate
90+
// between those interactions at the moment.
91+
m_Root.Q<ToolbarButton>(name: saveButtonId).Blur();
8792
}
8893

8994
private void OnAutoSaveToggle(ChangeEvent<bool> evt)

0 commit comments

Comments
 (0)