[Yamato] Fix & re-enable unstable IsAssetPreviewCorrect test

Fix unstable test: https://jira.unity3d.com/browse/UUM-59403 which was disabled earlier due to instability.
 
The test was unstable because it sometimes took too long and timed out. The instability was actually introduced by this PR https://github.cds.internal.unity3d.com/unity/unity/pull/41268 that tracks timeouts correctly, meaning that the highly varying runtimes of this test (usually 100-300sec but up to 700 sec sometimes) were not being enforced before. After the UTF 1.4.2 release the timeouts started correctly failing the test, and the test became unstable as a consequence.

This PR fixes the issue by refactoring it: it used to be a edit mode test that manually enters playmode (triggering domain reload) before running the test logic. It was originally done this way to more closely follow the repro steps where asset preview bugs would happen. But given the long runtime, it makes more sense to just implement it as a playmode test instead, so that we don't need to enter playmode separately which is time-consuming. As a result, the test is now passing reliably and only taking ~5sec.

cc @alex-vazquez - There was a separate issue with URP_Foundation project where the playmode test assembly was being excluded from editor, meaning that we had tests that were not being run when they should have been. These tests have now been fixed and enabled too.

Author: arttu-peltonen

Tests/SRPTests/Projects/UniversalGraphicsTest_Foundation/Assets/Test/Editor/PreviewTests.cs renamed to Tests/SRPTests/Projects/UniversalGraphicsTest_Foundation/Assets/Test/Runtime/PreviewTests.cs

@@ -1,3 +1,4 @@
+#if UNITY_EDITOR
 using System.Collections;
 using NUnit.Framework;
 using Unity.Graphics.Tests;
@@ -8,20 +9,14 @@
 public class PreviewTests : MonoBehaviour
 {
     [UnityTest]
-    [Ignore("Disabled for Instability https://jira.unity3d.com/browse/UUM-59403")]
     public IEnumerator AssetPreviewIsCorrect()
     {
-        EditorApplication.EnterPlaymode();
-        yield return new WaitForDomainReload(); // Avoid errors on domain reload
-        while (!EditorApplication.isPlaying)
-            yield return null;
         var threshold = 0.003f;
 
         yield return AssetPreviewTesting.CompareAssetPreview<Material>(
             "Assets/CommonAssets/Materials/Roofing.mat",
             "Assets/ReferenceImagesBase/Roofing.png",
             threshold);
-
-        EditorApplication.ExitPlaymode();
     }
 }
+#endif

Tests/SRPTests/Projects/UniversalGraphicsTest_Foundation/Assets/Test/Editor/PreviewTests.cs.meta renamed to Tests/SRPTests/Projects/UniversalGraphicsTest_Foundation/Assets/Test/Runtime/PreviewTests.cs.meta

@@ -6,10 +6,15 @@
 public class URPGlobalSettingsStrippingTests
 {
     [Test]
+    // Runtime settings
     [TestCase(typeof(ShaderStrippingSetting), true)]
-    [TestCase(typeof(URPShaderStrippingSetting), true)]
     [TestCase(typeof(URPDefaultVolumeProfileSettings), true)]
     [TestCase(typeof(RenderGraphSettings), true)]
+    [TestCase(typeof(UniversalRendererResources), true)]
+    [TestCase(typeof(UniversalRenderPipelineRuntimeTextures), true)]
+    [TestCase(typeof(UniversalRenderPipelineRuntimeShaders), true)]
+    // Editor-only settings
+    [TestCase(typeof(URPShaderStrippingSetting), false)]
     public void IsAvailableOnPlayerBuilds(System.Type type, bool expectedAvailable)
     {
         MethodInfo method = typeof(GraphicsSettings).GetMethod(nameof(GraphicsSettings.GetRenderPipelineSettings));

Tests/SRPTests/Projects/UniversalGraphicsTest_Foundation/Assets/Test/Runtime/URPGlobalSettingsStrippingTests.cs

@@ -11,12 +11,13 @@
         "GUID:c579267770062bf448e75eb160330b7f",
         "GUID:15fc0a57446b3144c949da3e2b9737a9",
         "GUID:36d514892e55d4340b470c29fcab8b44",
-        "GUID:df380645f10b7bc4b97d4f5eb6303d95"
+        "GUID:df380645f10b7bc4b97d4f5eb6303d95",
+        "GUID:343deaaf83e0cee4ca978e7df0b80d21",
+        "GUID:2bafac87e7f4b9b418d9448d219b01ab",
+        "GUID:adf6f42bac617413dbcd97c993ab7077"
     ],
     "includePlatforms": [],
-    "excludePlatforms": [
-        "Editor"
-    ],
+    "excludePlatforms": [],
     "allowUnsafeCode": false,
     "overrideReferences": true,
     "precompiledReferences": [
@@ -28,4 +29,4 @@
     ],
     "versionDefines": [],
     "noEngineReferences": false
-}
+}