Fix URP pass name handling

This is a continuation of https://github.cds.internal.unity3d.com/unity/unity/pull/50405

The goal is to have identical URP render pass names in all our profiling tools (RG viewer, Frame Debugger and Profiler).
The names are now also identical between RG and non-RG/Compatibility passes.

This PR fixes a number of potential bugs with regards to setting ScriptableRenderPass.profilerSampler to null, it fixes incorrect profiler scopes (inside the static method shared between RG and non-RG), improves more pass names using the naming convention from the previous PR and could have a very minor performance benefit in release build.   

In this PR, we separately store the passName and the profileSampler because these samplers can be null in the release build. Therefore, we can't just use sampler.name. By using the ScriptableRenderPass properties (passName, profileSampler) these names are kept in sync automatically.

The default name for a (user created) sub-class of a ScriptableRenderPass is now more descriptive, using the sub-class name instead of the base class.

The default RenderFeature that users create from the menu is updated to using this. 

The profile samplers being null in a release build was introduced by this PR as an optimization https://github.cds.internal.unity3d.com/unity/unity/pull/41824

However, in URP, many samplers are created differently, leading to limited performance gain, and inconsistency with some samplers being null and some not in the release build. This PR improves this so more samplers are null in a release build. Potentially gaining around 0.1ms main thread CPU in release on low end CPUs. 

Before and after this PR (no change), URP, ProfileSamplers references are kept in a few different places. Depending on that, the samplers can be nullified in the release build. 
- ScriptableRenderPass.profileSampler: used by RG and non-RG, in this PR, when using RG, they are nullified
- ProfileSampler.Get(URPProfileId): same pattern as with HDRP, these are nullified by the change from Julien
- RenderGraph.m_DefaultProfilingSamplers: created automatically when adding a pass without a sampler, these are nullified
- Other places of the URP code (outside of a pass): these are NOT nullified.

Likely, part of the optimization for HDRP came from the dictionary .TryGetValue with large pass dictionaries. The samplers kept outside of dictionary don't have this cost. So it likely will not improve performance to clean up these. 

Since some samplers can be null in the release build, it's bad practice (errors!) to use sampler.name.
However, the earlier PR to nullify this might have introduced issues already. To avoid issues with user project that do this (very low chance), in this PR, ScriptableRenderPass.profileSampler is only nullified in RenderGraph mode (not Compatibility).

This makes it a bit more complicated to ensure that the pass name and the sampler name (shown in profiler) don't get out of sync. However, it's confusing for users to see different names in different tools and complicates matching them during analysis. Hence the changes in this PR. 

The RenderGraph add pass methods (eg AddRasterPass, ...) have overloads for both passing a passName and a sampler, and one with only a passName. The use of passing only the passName seems recommended for users since they can't go out of sync, RG creates a new profiler with that name, and will nullify it in a release build, and users don't have access to the profilerSampler. In non release builds, there might be a small perf overhead of this practice since the dictionary can become large.

Author: UnityAljosha

Packages/com.unity.render-pipelines.universal/Editor/RendererFeatures/NewRendererFeature.cs.txt

@@ -23,7 +23,7 @@ public class #SCRIPTNAME# : ScriptableRendererFeature
         // FrameData is a context container through which URP resources can be accessed and managed.
         public override void RecordRenderGraph(RenderGraph renderGraph, ContextContainer frameData)
         {
-            const string passName = "Custom Render Pass";
+            const string passName = "Render Custom Pass";
 
             // This adds a raster render pass to the graph, specifying the name and the data type that will be passed to the ExecutePass function.
             using (var builder = renderGraph.AddRasterRenderPass<PassData>(passName, out var passData))

Packages/com.unity.render-pipelines.universal/Runtime/Decal/DBuffer/DBufferRenderPass.cs

@@ -238,7 +238,7 @@ public override void RecordRenderGraph(RenderGraph renderGraph, ContextContainer
             TextureHandle depthTarget = renderer.renderingModeActual == RenderingMode.Deferred ? resourceData.activeDepthTexture :
                 (cameraData.cameraTargetDescriptor.msaaSamples > 1 ? resourceData.dBufferDepth : resourceData.activeDepthTexture);
 
-            using (var builder = renderGraph.AddRasterRenderPass<PassData>(profilingSampler.name, out var passData, profilingSampler))
+            using (var builder = renderGraph.AddRasterRenderPass<PassData>(passName, out var passData, profilingSampler))
             {
                 InitPassData(ref passData);
 

Packages/com.unity.render-pipelines.universal/Runtime/Decal/DBuffer/DecalForwardEmissivePass.cs

@@ -79,7 +79,7 @@ private static void ExecutePass(RasterCommandBuffer cmd, PassData passData, Rend
 
         public override void RecordRenderGraph(RenderGraph renderGraph, ContextContainer frameData)
         {
-            using (var builder = renderGraph.AddRasterRenderPass<PassData>(profilingSampler.name, out var passData, profilingSampler))
+            using (var builder = renderGraph.AddRasterRenderPass<PassData>(passName, out var passData, profilingSampler))
             {
                 UniversalResourceData resourceData = frameData.Get<UniversalResourceData>();
                 UniversalRenderingData renderingData = frameData.Get<UniversalRenderingData>();

Packages/com.unity.render-pipelines.universal/Runtime/Decal/ScreenSpace/DecalGBufferRenderPass.cs

@@ -164,7 +164,7 @@ public override void RecordRenderGraph(RenderGraph renderGraph, ContextContainer
             UniversalResourceData resourceData = frameData.Get<UniversalResourceData>();
             TextureHandle cameraDepthTexture = resourceData.cameraDepthTexture;
 
-            using (var builder = renderGraph.AddRasterRenderPass<PassData>(profilingSampler.name, out var passData, profilingSampler))
+            using (var builder = renderGraph.AddRasterRenderPass<PassData>(passName, out var passData, profilingSampler))
             {
                 UniversalRenderingData renderingData = frameData.Get<UniversalRenderingData>();
                 UniversalCameraData cameraData = frameData.Get<UniversalCameraData>();

Packages/com.unity.render-pipelines.universal/Runtime/Decal/ScreenSpace/DecalScreenSpaceRenderPass.cs

@@ -110,7 +110,7 @@ public override void RecordRenderGraph(RenderGraph renderGraph, ContextContainer
 
             TextureHandle cameraDepthTexture = resourceData.cameraDepthTexture;
 
-            using (var builder = renderGraph.AddRasterRenderPass<PassData>(profilingSampler.name, out var passData, profilingSampler))
+            using (var builder = renderGraph.AddRasterRenderPass<PassData>(passName, out var passData, profilingSampler))
             {
                 UniversalRenderingData renderingData = frameData.Get<UniversalRenderingData>();
                 UniversalCameraData cameraData = frameData.Get<UniversalCameraData>();

Packages/com.unity.render-pipelines.universal/Runtime/Passes/AdditionalLightsShadowCasterPass.cs

@@ -895,7 +895,7 @@ internal TextureHandle Render(RenderGraph graph, ContextContainer frameData)
             UniversalLightData lightData = frameData.Get<UniversalLightData>();
             UniversalShadowData shadowData = frameData.Get<UniversalShadowData>();
 
-            using (var builder = graph.AddRasterRenderPass<PassData>(profilingSampler.name, out var passData, profilingSampler))
+            using (var builder = graph.AddRasterRenderPass<PassData>(passName, out var passData, profilingSampler))
             {
                 InitPassData(ref passData, cameraData, lightData, shadowData);
                 InitRendererLists(ref renderingData.cullResults, ref passData, default(ScriptableRenderContext), graph, true);

Packages/com.unity.render-pipelines.universal/Runtime/Passes/CapturePass.cs

@@ -13,11 +13,10 @@ namespace UnityEngine.Rendering.Universal
     internal class CapturePass : ScriptableRenderPass
     {
         RTHandle m_CameraColorHandle;
-        const string m_ProfilerTag = "Capture Pass";
-        private static readonly ProfilingSampler m_ProfilingSampler = new ProfilingSampler(m_ProfilerTag);
+
         public CapturePass(RenderPassEvent evt)
         {
-            base.profilingSampler = new ProfilingSampler(nameof(CapturePass));
+            base.profilingSampler = new ProfilingSampler("Capture Camera output");
             renderPassEvent = evt;
         }
 
@@ -29,7 +28,7 @@ public override void Execute(ScriptableRenderContext context, ref RenderingData
 
             m_CameraColorHandle = renderingData.cameraData.renderer.GetCameraColorBackBuffer(cmdBuf);
 
-            using (new ProfilingScope(cmdBuf, m_ProfilingSampler))
+            using (new ProfilingScope(cmdBuf, profilingSampler))
             {
                 var colorAttachmentIdentifier = m_CameraColorHandle.nameID;
                 var captureActions = renderingData.cameraData.captureActions;
@@ -44,8 +43,6 @@ private class UnsafePassData
             public IEnumerator<Action<RenderTargetIdentifier, CommandBuffer>> captureActions;
         }
 
-        const string k_UnsafePassName = "CapturePass (Render Graph Unsafe Pass)";
-
         // This function needs to add an unsafe render pass to Render Graph because a raster render pass, which is typically
         // used for rendering with Render Graph, cannot perform the texture readback operations performed with the command
         // buffer in CameraTextureProvider. Unsafe passes can do certain operations that raster render passes cannot do and
@@ -55,7 +52,7 @@ public override void RecordRenderGraph(RenderGraph renderGraph, ContextContainer
             UniversalResourceData resourceData = frameData.Get<UniversalResourceData>();
             UniversalCameraData cameraData = frameData.Get<UniversalCameraData>();
 
-            using (var builder = renderGraph.AddUnsafePass<UnsafePassData>(k_UnsafePassName, out var passData, profilingSampler))
+            using (var builder = renderGraph.AddUnsafePass<UnsafePassData>(passName, out var passData, profilingSampler))
             {
                 // Setup up the pass data with cameraColor, which has the correct orientation and position in a built player
                 passData.source = resourceData.cameraColor;

Packages/com.unity.render-pipelines.universal/Runtime/Passes/ColorGradingLutPass.cs

@@ -29,7 +29,7 @@ public class ColorGradingLutPass : ScriptableRenderPass
         /// <seealso cref="PostProcessData"/>
         public ColorGradingLutPass(RenderPassEvent evt, PostProcessData data)
         {
-            base.profilingSampler = new ProfilingSampler("Blit Color LUT");
+            profilingSampler = new ProfilingSampler("Blit Color LUT");
             renderPassEvent = evt;
             overrideCameraTarget = true;
 
@@ -280,7 +280,7 @@ internal void Render(RenderGraph renderGraph, ContextContainer frameData, out Te
             UniversalCameraData cameraData = frameData.Get<UniversalCameraData>();
             UniversalPostProcessingData postProcessingData= frameData.Get<UniversalPostProcessingData>();
 
-            using (var builder = renderGraph.AddRasterRenderPass<PassData>(base.profilingSampler.name, out var passData, base.profilingSampler))
+            using (var builder = renderGraph.AddRasterRenderPass<PassData>(passName, out var passData, profilingSampler))
             {
                 this.ConfigureDescriptor(in postProcessingData, out var lutDesc, out var filterMode);
                 internalColorLut = UniversalRenderer.CreateRenderGraphTexture(renderGraph, lutDesc, "_InternalGradingLut", true, filterMode);

Packages/com.unity.render-pipelines.universal/Runtime/Passes/CopyColorPass.cs

@@ -35,9 +35,8 @@ public class CopyColorPass : ScriptableRenderPass
         /// <seealso cref="Downsampling"/>
         public CopyColorPass(RenderPassEvent evt, Material samplingMaterial, Material copyColorMaterial = null, string customPassName = null)
         {
-            var passName = customPassName != null ? customPassName : "Copy Color";
+            profilingSampler = customPassName != null ? new ProfilingSampler(customPassName) : ProfilingSampler.Get(URPProfileId.CopyColor);
 
-            base.profilingSampler = new ProfilingSampler(passName);
             m_PassData = new PassData();
 
             m_SamplingMaterial = samplingMaterial;
@@ -214,7 +213,7 @@ internal void RenderToExistingTexture(RenderGraph renderGraph, ContextContainer
 
         private void RenderInternal(RenderGraph renderGraph, in TextureHandle destination, in TextureHandle source, bool useProceduralBlit)
         {
-            using (var builder = renderGraph.AddRasterRenderPass<PassData>(profilingSampler.name, out var passData, profilingSampler))
+            using (var builder = renderGraph.AddRasterRenderPass<PassData>(passName, out var passData, profilingSampler))
             {
                 passData.destination = destination;
                 builder.SetRenderAttachment(destination, 0, AccessFlags.Write);

Packages/com.unity.render-pipelines.universal/Runtime/Passes/CopyDepthPass.cs

@@ -41,7 +41,7 @@ public class CopyDepthPass : ScriptableRenderPass
         /// <seealso cref="RenderPassEvent"/>
         public CopyDepthPass(RenderPassEvent evt, Shader copyDepthShader, bool shouldClear = false, bool copyToDepth = false, bool copyResolvedDepth = false, string customPassName = null)
         {
-            base.profilingSampler = customPassName != null ? new ProfilingSampler(customPassName) : new ProfilingSampler("Copy Depth");
+            profilingSampler = customPassName != null ? new ProfilingSampler(customPassName) : ProfilingSampler.Get(URPProfileId.CopyDepth);
             m_PassData = new PassData();
             CopyToDepth = copyToDepth;
             m_CopyDepthMaterial = copyDepthShader != null ? CoreUtils.CreateEngineMaterial(copyDepthShader) : null;