[Quest][Foveated Rendering] prevent foveation for intermediate passes if dynamic resolution is active for RenderGraph

thomas-zeng · Evergreen · commit 935e97913cb2 · 2024-05-16T15:01:04.000Z
Jira: https://jira.unity3d.com/browse/UUM-68032 Prevent foveation for intermediate passes if dynamic resolution is active on Quest
diff --git a/Packages/com.unity.render-pipelines.core/Runtime/XR/XRSystem.cs b/Packages/com.unity.render-pipelines.core/Runtime/XR/XRSystem.cs
@@ -226,6 +226,22 @@ public static void SetRenderScale(float renderScale)
 #endif
         }
 
+
+        /// <summary>
+        /// Used by the render pipeline to retrieve the renderViewportScale value from the XR display.
+        /// One use case for retriving this value is that render pipeline can properly sync some SRP owned textures to scale accordingly
+        /// </summary>
+        /// <returns> Returns current scaleOfAllViewports value from the XRDisplaySubsystem. </returns>
+        public static float GetRenderViewportScale()
+        {
+#if ENABLE_VR && ENABLE_XR_MODULE
+
+            return s_Display.scaleOfAllViewports;
+#else
+            return 1.0f;
+#endif
+        }
+
         /// <summary>
         /// Used by the render pipeline to initiate a new rendering frame through a XR layout.
         /// </summary>
diff --git a/Packages/com.unity.render-pipelines.universal/Runtime/Passes/DepthNormalOnlyPass.cs b/Packages/com.unity.render-pipelines.universal/Runtime/Passes/DepthNormalOnlyPass.cs
@@ -204,7 +204,8 @@ internal void Render(RenderGraph renderGraph, ContextContainer frameData, Textur
                 param.filteringSettings.batchLayerMask = batchLayerMask;
                 passData.rendererList = renderGraph.CreateRendererList(param);
                 builder.UseRendererList(passData.rendererList);
-                builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering);
+                if (cameraData.xr.enabled)
+                    builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering && cameraData.xrUniversal.canFoveateIntermediatePasses);
 
                 UniversalRenderer universalRenderer = cameraData.renderer as UniversalRenderer;
                 if (postSetGlobalTextures && universalRenderer != null)
diff --git a/Packages/com.unity.render-pipelines.universal/Runtime/Passes/DepthOnlyPass.cs b/Packages/com.unity.render-pipelines.universal/Runtime/Passes/DepthOnlyPass.cs
@@ -137,7 +137,8 @@ internal void Render(RenderGraph renderGraph, ContextContainer frameData, ref Te
                 //  TODO RENDERGRAPH: culling? force culling off for testing
                 builder.AllowPassCulling(false);
                 builder.AllowGlobalStateModification(true);
-                builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering);
+                if (cameraData.xr.enabled)
+                    builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering && cameraData.xrUniversal.canFoveateIntermediatePasses);
 
                 builder.SetRenderFunc((PassData data, RasterGraphContext context) =>
                 {
diff --git a/Packages/com.unity.render-pipelines.universal/Runtime/Passes/DrawObjectsPass.cs b/Packages/com.unity.render-pipelines.universal/Runtime/Passes/DrawObjectsPass.cs
@@ -304,7 +304,12 @@ internal void Render(RenderGraph renderGraph, ContextContainer frameData, Textur
 
                 builder.AllowPassCulling(false);
                 builder.AllowGlobalStateModification(true);
-                builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering);
+
+                if (cameraData.xr.enabled)
+                {
+                    bool passSupportsFoveation = cameraData.xrUniversal.canFoveateIntermediatePasses || resourceData.isActiveTargetBackBuffer;
+                    builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering && passSupportsFoveation);
+                }
 
                 builder.SetRenderFunc((PassData data, RasterGraphContext context) =>
                 {
@@ -451,7 +456,12 @@ internal void Render(RenderGraph renderGraph, ContextContainer frameData, Textur
                 builder.AllowPassCulling(false);
                 // Required here because of RenderingLayerUtils.SetupProperties
                 builder.AllowGlobalStateModification(true);
-                builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering);
+
+                if (cameraData.xr.enabled)
+                {
+                    bool passSupportsFoveation = cameraData.xrUniversal.canFoveateIntermediatePasses || resourceData.isActiveTargetBackBuffer;
+                    builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering && passSupportsFoveation);
+                }
 
                 builder.SetRenderFunc((RenderingLayersPassData data, RasterGraphContext context) =>
                 {
diff --git a/Packages/com.unity.render-pipelines.universal/Runtime/Passes/DrawSkyboxPass.cs b/Packages/com.unity.render-pipelines.universal/Runtime/Passes/DrawSkyboxPass.cs
@@ -166,7 +166,11 @@ internal void Render(RenderGraph renderGraph, ContextContainer frameData, Script
                 }
 
                 builder.AllowPassCulling(false);
-                builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering);
+                if (cameraData.xr.enabled)
+                {
+                    bool passSupportsFoveation = cameraData.xrUniversal.canFoveateIntermediatePasses || resourceData.isActiveTargetBackBuffer;
+                    builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering && passSupportsFoveation);
+                }
 
                 builder.SetRenderFunc((PassData data, RasterGraphContext context) =>
                 {
diff --git a/Packages/com.unity.render-pipelines.universal/Runtime/Passes/FinalBlitPass.cs b/Packages/com.unity.render-pipelines.universal/Runtime/Passes/FinalBlitPass.cs
@@ -287,6 +287,12 @@ internal void Render(RenderGraph renderGraph, UniversalCameraData cameraData, in
                 passData.destination = dest;
                 builder.SetRenderAttachment(dest, 0, AccessFlags.Write);
 
+#if ENABLE_VR && ENABLE_XR_MODULE
+                // This is a screen-space pass, make sure foveated rendering is disabled for non-uniform renders
+                bool passSupportsFoveation = !XRSystem.foveatedRenderingCaps.HasFlag(FoveatedRenderingCaps.NonUniformRaster);
+                builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering && passSupportsFoveation);
+#endif
+
                 if (outputsToHDR && overlayUITexture.IsValid())
                 {
                     VolumeStack stack = VolumeManager.instance.stack;
diff --git a/Packages/com.unity.render-pipelines.universal/Runtime/Passes/MotionVectorRenderPass.cs b/Packages/com.unity.render-pipelines.universal/Runtime/Passes/MotionVectorRenderPass.cs
@@ -132,6 +132,7 @@ private static void DrawCameraMotionVectors(RasterCommandBuffer cmd, XRPass xr,
 #if ENABLE_VR && ENABLE_XR_MODULE
             bool foveatedRendering = xr.supportsFoveatedRendering;
             bool nonUniformFoveatedRendering = foveatedRendering && XRSystem.foveatedRenderingCaps.HasFlag(FoveatedRenderingCaps.NonUniformRaster);
+
             if (foveatedRendering)
             {
                 if (nonUniformFoveatedRendering)
@@ -219,7 +220,8 @@ internal void Render(RenderGraph renderGraph, ContextContainer frameData, Textur
                 //  TODO RENDERGRAPH: culling? force culling off for testing
                 builder.AllowPassCulling(false);
                 builder.AllowGlobalStateModification(true);
-                builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering);
+                if (cameraData.xr.enabled)
+                    builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering && cameraData.xrUniversal.canFoveateIntermediatePasses);
 
                 passData.motionVectorColor = motionVectorColor;
                 builder.SetRenderAttachment(motionVectorColor, 0, AccessFlags.Write);
diff --git a/Packages/com.unity.render-pipelines.universal/Runtime/Passes/RenderObjectsPass.cs b/Packages/com.unity.render-pipelines.universal/Runtime/Passes/RenderObjectsPass.cs
@@ -313,7 +313,8 @@ public override void RecordRenderGraph(RenderGraph renderGraph, ContextContainer
 
                 builder.AllowPassCulling(false);
                 builder.AllowGlobalStateModification(true);
-                builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering);
+                if (cameraData.xr.enabled)
+                    builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering && cameraData.xrUniversal.canFoveateIntermediatePasses);
 
                 builder.SetRenderFunc((PassData data, RasterGraphContext rgContext) =>
                 {
diff --git a/Packages/com.unity.render-pipelines.universal/Runtime/Passes/XROcclusionMeshPass.cs b/Packages/com.unity.render-pipelines.universal/Runtime/Passes/XROcclusionMeshPass.cs
@@ -72,7 +72,11 @@ internal void Render(RenderGraph renderGraph, ContextContainer frameData, in Tex
                 //  TODO RENDERGRAPH: culling? force culling off for testing
                 builder.AllowPassCulling(false);
                 builder.AllowGlobalStateModification(true);
-                builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering);
+                if (cameraData.xr.enabled)
+                {
+                    bool passSupportsFoveation = cameraData.xrUniversal.canFoveateIntermediatePasses || resourceData.isActiveTargetBackBuffer;
+                    builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering && passSupportsFoveation);
+                }
 
                 builder.SetRenderFunc((PassData data, RasterGraphContext context) =>
                 {
diff --git a/Packages/com.unity.render-pipelines.universal/Runtime/ScriptableRenderer.cs b/Packages/com.unity.render-pipelines.universal/Runtime/ScriptableRenderer.cs
@@ -1038,6 +1038,11 @@ internal void BeginRenderGraphXRRendering(RenderGraph renderGraph)
             if (!cameraData.xr.enabled)
                 return;
 
+            bool isDefaultXRViewport = XRSystem.GetRenderViewportScale() == 1.0f;
+            // For untethered XR, intermediate pass' foveation is currenlty unsupported with non-default viewport.
+            // Must be configured during the recording timeline before adding other XR intermediate passes.
+            cameraData.xrUniversal.canFoveateIntermediatePasses = !PlatformAutoDetect.isXRMobile || isDefaultXRViewport;
+
             using (var builder = renderGraph.AddRasterRenderPass<BeginXRPassData>("BeginXRRendering", out var passData,
                 Profiling.beginXRRendering))
             {
diff --git a/Packages/com.unity.render-pipelines.universal/Runtime/UniversalRenderPipeline.cs b/Packages/com.unity.render-pipelines.universal/Runtime/UniversalRenderPipeline.cs
@@ -988,6 +988,10 @@ static void RenderCameraStack(ScriptableRenderContext context, Camera baseCamera
                 {
                     xrActive = true;
                     UpdateCameraStereoMatrices(baseCamera, xrPass);
+
+                    // Apply XR display's viewport scale to URP's dynamic resolution solution
+                    float xrViewportScale = XRSystem.GetRenderViewportScale();
+                    ScalableBufferManager.ResizeBuffers(xrViewportScale, xrViewportScale);
                 }
 
                 bool finalOutputHDR = false;
diff --git a/Packages/com.unity.render-pipelines.universal/Runtime/XR/XRPassUniversal.cs b/Packages/com.unity.render-pipelines.universal/Runtime/XR/XRPassUniversal.cs
@@ -13,6 +13,7 @@ public static XRPass Create(XRPassCreateInfo createInfo)
             pass.isLateLatchEnabled = false;
             pass.canMarkLateLatch = false;
             pass.hasMarkedLateLatch = false;
+            pass.canFoveateIntermediatePasses = true;
 
             return pass;
         }
@@ -30,5 +31,8 @@ override public void Release()
 
         /// Track the state of the late latching system.
         internal bool hasMarkedLateLatch { get; set; }
+
+        /// If false, foveated rendering should not be applied to intermediate render passes that are not the final pass.
+        internal bool canFoveateIntermediatePasses { get; set; }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,8 @@ internal void Render(RenderGraph renderGraph, ContextContainer frameData, ref Te`
`137`	`137`	`// TODO RENDERGRAPH: culling? force culling off for testing`
`138`	`138`	`builder.AllowPassCulling(false);`
`139`	`139`	`builder.AllowGlobalStateModification(true);`
`140`		`- builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering);`
	`140`	`+ if (cameraData.xr.enabled)`
	`141`	`+ builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering && cameraData.xrUniversal.canFoveateIntermediatePasses);`
`141`	`142`
`142`	`143`	`builder.SetRenderFunc((PassData data, RasterGraphContext context) =>`
`143`	`144`	`{`
Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,11 @@ internal void Render(RenderGraph renderGraph, ContextContainer frameData, Script`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`builder.AllowPassCulling(false);`
`169`		`- builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering);`
	`169`	`+ if (cameraData.xr.enabled)`
	`170`	`+ {`
	`171`	`+ bool passSupportsFoveation = cameraData.xrUniversal.canFoveateIntermediatePasses \|\| resourceData.isActiveTargetBackBuffer;`
	`172`	`+ builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering && passSupportsFoveation);`
	`173`	`+ }`
`170`	`174`
`171`	`175`	`builder.SetRenderFunc((PassData data, RasterGraphContext context) =>`
`172`	`176`	`{`
Original file line number	Diff line number	Diff line change
`@@ -313,7 +313,8 @@ public override void RecordRenderGraph(RenderGraph renderGraph, ContextContainer`
`313`	`313`
`314`	`314`	`builder.AllowPassCulling(false);`
`315`	`315`	`builder.AllowGlobalStateModification(true);`
`316`		`- builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering);`
	`316`	`+ if (cameraData.xr.enabled)`
	`317`	`+ builder.EnableFoveatedRasterization(cameraData.xr.supportsFoveatedRendering && cameraData.xrUniversal.canFoveateIntermediatePasses);`
`317`	`318`
`318`	`319`	`builder.SetRenderFunc((PassData data, RasterGraphContext rgContext) =>`
`319`	`320`	`{`