[APV] Various Fixes

Fixed missing option to offset probe at runtime, can be used for camera relative rendering on large worlds, or when loading scene at a different location than where it was baked
Fixed baking when using terrain trees with LOD groups
Fixed warnings in various shaders
Fixed dispatches too large for sky occlusion that would result in errors when baking
Slightly changed the thread group size and batch size to reduce time spend in baking shaders to avoid windows TDR errors
Fixed to debug modes when using baking offset
Fix error when we try to delete temp directory but it was marked as readonly by the OS

Increase test coverage

Author: adrien-de-tocqueville

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/DynamicGI/DynamicGISkyOcclusion.compute

@@ -1,5 +1,7 @@
+#pragma only_renderers d3d11 playstation xboxone xboxseries vulkan metal
+
 #define UNIFIED_RT_BACKEND_COMPUTE
-#define UNIFIED_RT_GROUP_SIZE_X 16
+#define UNIFIED_RT_GROUP_SIZE_X 64
 #define UNIFIED_RT_GROUP_SIZE_Y 1
 #include "DynamicGISkyOcclusion.hlsl"
 #include_with_pragmas "Packages/com.unity.rendering.light-transport/Runtime/UnifiedRayTracing/Compute/ComputeRaygenShader.hlsl"

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeAdjustmentVolumeEditor.cs

@@ -36,7 +36,7 @@ internal static class Styles
             internal static readonly GUIContent s_Mode = new GUIContent("Mode", "Choose which type of adjustment to apply to probes covered by this volume.");
             internal static readonly GUIContent s_DilationThreshold = new GUIContent("Dilation Validity Threshold", "Override the Dilation Validity Threshold for probes covered by this Probe Adjustment Volume. Higher values increase the chance of probes being considered invalid.");
             internal static readonly GUIContent virtualOffsetThreshold = new GUIContent("Validity Threshold", "Override the Virtual Offset Validity Threshold for probes covered by this Probe Adjustment Volume. Higher values increase the chance of probes being considered invalid.");
-            internal static readonly GUIContent s_VODirection = new GUIContent("Direction", "Rotate the axis along which probes will be pushed when applying Virtual Offset.");
+            internal static readonly GUIContent s_VODirection = new GUIContent("Rotation", "Rotate the axis along which probes will be pushed when applying Virtual Offset.");
             internal static readonly GUIContent s_VODistance = new GUIContent("Distance", "Determines how far probes are pushed in the direction of the Virtual Offset.");
             internal static readonly GUIContent renderingLayerMaskOperation = new GUIContent("Operation", "The operation to combine the Rendering Layer Mask set by this adjustment volume with the Rendering Layer Mask of the probes covered by this volume.");
             internal static readonly GUIContent renderingLayerMask = new GUIContent("Rendering Layer Mask", "Sets the Rendering Layer Mask to be combined with the Rendering Layer Mask of the probes covered by this volume.");

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeGIBaking.Dilate.cs

@@ -357,6 +357,7 @@ static void PerformDilation(ProbeReferenceVolume.Cell cell, ProbeVolumeBakingSet
             parameters.skyOcclusionShadingDirection = bakingSet.skyOcclusionShadingDirection ? true : false;
             parameters.regionCount = 1;
             parameters.regionLayerMasks = 1;
+            parameters.worldOffset = Vector3.zero;
             ProbeReferenceVolume.instance.UpdateConstantBuffer(cmd, parameters);
 
 

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeGIBaking.LightTransport.cs

@@ -804,6 +804,8 @@ internal static void BakeAdjustmentVolume(ProbeVolumeBakingSet bakingSet, ProbeA
                 m_CellsToDilate.Clear();
             }
 
+            Debug.Assert(bakingSet.CheckCompatibleCellLayout());
+
             // Clear loaded data
             foreach (var data in prv.perSceneDataList)
                 data.QueueSceneRemoval();

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeGIBaking.SkyOcclusion.cs

@@ -115,7 +115,7 @@ internal static uint EncodeSkyShadingDirection(Vector3 direction)
 
         class DefaultSkyOcclusion : SkyOcclusionBaker
         {
-            const int k_MaxProbeCountPerBatch = 65535 * 64;
+            const int k_MaxProbeCountPerBatch = 128 * 1024;
             const float k_SkyOcclusionOffsetRay = 0.015f;
             const int k_SampleCountPerStep = 16;
 

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeGIBaking.cs

@@ -102,7 +102,7 @@ static internal void CompressSH(ref SphericalHarmonicsL2 shv, float intensitySca
                     shv[rgb, 8] = shv[rgb, 8] / (l0 * l2scale * 2.0f) + 0.5f;
 
                     for (int coeff = 1; coeff < 9; ++coeff)
-                        Debug.Assert(shv[rgb, coeff] >= 0.0f && shv[rgb, coeff] <= 1.0f);
+                        shv[rgb, coeff] = Mathf.Clamp01(shv[rgb, coeff]);
                 }
             }
         }

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeBuildProcessor.cs

@@ -73,7 +73,17 @@ public override void PrepareForBuild(BuildPlayerContext buildPlayerContext)
 
             // Delete previously built data. This way we remove any data from scenes that are no longer in the build.
             if (Directory.Exists(tempStreamingAssetsPath))
-                Directory.Delete(tempStreamingAssetsPath, recursive: true);
+            {
+                try
+                {
+                    Directory.Delete(tempStreamingAssetsPath, recursive: true);
+                }
+                catch
+                {
+                    // This can happen if for example the folder is write protected
+                    // This is not ideal but don't block project build
+                }
+            }
 
             Directory.CreateDirectory(tempStreamingAssetsPath);
 

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeLightingTab.cs

@@ -1003,9 +1003,7 @@ internal bool PrepareAPVBake()
                 activeSet.SetActiveScenario(activeSet.m_LightingScenarios[0], false);
 
             // Layout has changed and is incompatible.
-            if (activeSet.HasValidSharedData() && !activeSet.freezePlacement &&
-                (activeSet.bakedMinDistanceBetweenProbes != activeSet.minDistanceBetweenProbes ||
-                activeSet.bakedSimplificationLevels != activeSet.simplificationLevels))
+            if (activeSet.HasValidSharedData() && !activeSet.freezePlacement && !activeSet.CheckCompatibleCellLayout())
             {
                 if (AdaptiveProbeVolumes.partialBakeSceneList != null)
                 {

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumesOptionsEditor.cs

@@ -15,6 +15,7 @@ sealed class ProbeVolumesOptionsEditor : VolumeComponentEditor
 
         SerializedDataParameter m_IntensityMultiplier;
         SerializedDataParameter m_SkyOcclusionIntensityMultiplier;
+        SerializedDataParameter m_WorldOffset;
 
         public override void OnEnable()
         {
@@ -30,6 +31,7 @@ public override void OnEnable()
 
             m_IntensityMultiplier = Unpack(o.Find(x => x.intensityMultiplier));
             m_SkyOcclusionIntensityMultiplier = Unpack(o.Find(x => x.skyOcclusionIntensityMultiplier));
+            m_WorldOffset = Unpack(o.Find(x => x.worldOffset));
 
             base.OnEnable();
         }
@@ -46,6 +48,7 @@ public override void OnInspectorGUI()
 
             PropertyField(m_IntensityMultiplier);
             PropertyField(m_SkyOcclusionIntensityMultiplier);
+            PropertyField(m_WorldOffset);
         }
     }
 }

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/VirtualOffset/TraceVirtualOffset.compute

@@ -1,5 +1,7 @@
+#pragma only_renderers d3d11 playstation xboxone xboxseries vulkan metal
+
 #define UNIFIED_RT_BACKEND_COMPUTE
-#define UNIFIED_RT_GROUP_SIZE_X 16
+#define UNIFIED_RT_GROUP_SIZE_X 64
 #define UNIFIED_RT_GROUP_SIZE_Y 1
 #include "TraceVirtualOffset.hlsl"
 #include_with_pragmas "Packages/com.unity.rendering.light-transport/Runtime/UnifiedRayTracing/Compute/ComputeRaygenShader.hlsl"