[HDRP] Adding SG custom refraction example to Transparency sample

This concludes the task of adding transparent samples to HDRP. The last needed part was the shader graph example which needed to include compute thickness and new nodes added by @soufiane-khiat a while ago. 

This adds 3 examples: 
- The gummy bears, which shows two ways of using compute thickness by rendering gummy bears and its x-ray using the same shader. 
- The lens effect which has been snatched from the dead Werner demo
- And a full custom refraction shader which replicates the sphere refraction model in HDRP using an Unlit shader. 

Those should be good base for user to kickstart a custom refraction effect in HDRP

![image](https://media.github.cds.internal.unity3d.com/user/1764/files/0565c42d-b16d-4504-91a0-8056d440e8c4)

this adds two new thing to check in the HDRP asset when importing a sample. 

![image](https://media.github.cds.internal.unity3d.com/user/1764/files/09c823b1-39b6-46bc-94fc-226e071fcefc)

Lastly, took the opportunity to reduce filesize by replacing the tif with png file which minimize the additional file needed for this addition. 

before: 
![image](https://media.github.cds.internal.unity3d.com/user/1764/files/610bd172-ce4d-408a-a157-347ed9089b40)

now:
![image](https://media.github.cds.internal.unity3d.com/user/1764/files/88c9e5e7-7241-472a-aabc-0f68b23730f4)


Regarding the raytracing quality node. It's not really possible to have a migration / upgrade. But by default, if the user doesn't re-save their graph the result stay unchanged. Then, if they want to upgrade, they need to delete / re-add the keywords to be able to get the new behavior. Since, it's most probably not used a lot (we never had a report regarding this), it's probably acceptable to have this behavior.

Author: remi-chapelain

Packages/com.unity.render-pipelines.core/Samples~/Common/Scripts/RequiredSettings/RequiredSettingBase.cs

@@ -84,7 +84,7 @@ public virtual bool state
                         break;
                     case ValueType.Int:
                         floatValue = property.intValue;
-                        comparedValue = (int)comparedValue;
+                        comparedValue = (int)targetValue;
                         break;
                     default:
                             return property.boolValue == (targetValue > 0f);
@@ -102,6 +102,10 @@ public virtual bool state
                         return floatValue <= comparedValue;
                     case ValidationType.Different:
                         return floatValue != comparedValue;
+                    case ValidationType.LayermaskContains:
+                        var intValue = property.intValue;
+                        var intCompared = (int)targetValue;
+                        return (intValue & intCompared) == intCompared;
                     default:
                         return floatValue == comparedValue;
                 }
@@ -123,7 +127,8 @@ public enum ValidationType
         Lower,
         GreaterEqual,
         LowerEqual,
-        Different
+        Different,
+        LayermaskContains
     };
 }
 #endif

Packages/com.unity.render-pipelines.high-definition/Documentation~/Images/RaytracingQualityNode.png

@@ -1,6 +1,6 @@
 # Implement ray tracing with Shader Graph
 
-To use ray-traced effects with Shader Graph, use the **Raytracing Quality** Keyword node. This node exchanges accuracy for speed, except for [Path-Traced effects](Ray-Tracing-Path-Tracing.md) which aren't affected and use the default path.
+To use ray-traced effects with Shader Graph, use the **Raytracing Quality** Keyword node. This node exchanges accuracy for speed for ray-traced effects. It's also useful to prevent compilation error due to unsupported nodes when using [Path Tracing](Ray-Tracing-Path-Tracing.md).
 
 ## Add the Raytracing Quality Keyword node
 
@@ -21,6 +21,7 @@ To use this keyword in the graph, you need to create a [Keyword Node](https://do
 
 | Name          | Direction | Type           | Description                                                  |
 | :------------ | :-------- | :------------- | :----------------------------------------------------------- |
-| **default**   | Input     | Vector4        | The value to use for the normal Shader Graph. This is the default path Unity uses to render this Shader Graph. |
-| **raytraced** | Input     | Vector4        | The value to use for the fast Shader Graph to use with the ray-traced effects excepth the path traced one.|
-| **output**    | Output    | Vector4        | Outputs is the value which will be selected based on the context this shader graph is used. |
+| **default**       | Input     | Vector4        | The value to use for the normal Shader Graph. This is the default path Unity uses to render this Shader Graph. |
+| **raytraced**     | Input     | Vector4        | The value to use for the fast Shader Graph to use with the ray-traced effects.|
+| **pathtraced**    | Input     | Vector4        | The value to use for the Shader Graph when the path tracer is enabled. This is useful to prevent compilation error due to unsupported nodes in path tracing.|
+| **output**        | Output    | Vector4        | Outputs is the value which will be selected based on the context this shader graph is used. |

Packages/com.unity.render-pipelines.high-definition/Documentation~/SGNode-Raytracing-Quality.md

@@ -22,6 +22,10 @@ With the introduction of the sky occlusion feature some asset data layout has ch
 
 Path tracing now has a *Seed Mode* parameter. The default is the **non repeating** noise pattern, which is different from the previous behavior. To match behavior in the last version, select the **repeating** pattern.
 
+The [Raytracing Quality Keyword](SGNode-Raytracing-Quality.md) has been updated to include a Pathtraced input. 
+In previous versions, when Path tracing is enabled, the default input was used. Now, it uses the Pathtraced input. This is to prevent compilation error in graphs using unsupported nodes. 
+If you had Shader Graph materials using the Raytracing Quality Keyword, the result will stay unchanged until you re-save them. To upgrade the behavior, you need to delete the keyword in the blackboard and re-add it manually. 
+
 ## Enabling light sources in Path Tracing
 
 In this version, the setting to include light sources in ray traced effects has been split in one checkbox for hybrid ray tracing effects (`include for Ray Tracing`) and one checkbox for inclusion in Path Tracing (`include for Path Tracing`). When upgrading, this last checkbox might need to be updated.

Packages/com.unity.render-pipelines.high-definition/Documentation~/Upgrading-from-2023.2-to-unity-6-preview.md

@@ -1306,7 +1306,7 @@ IncludeCollection GenerateIncludes()
         public static DefineCollection RaytracingPathTracingDefines = new DefineCollection
         {
             { Defines.shadowLow },
-            { Defines.raytracingDefault },
+            { Defines.raytracingPathtraced },
             { Defines.pathtracingDisableLightCluster },
             { CoreKeywordDescriptors.HasLightloop, 1 },
         };
@@ -1423,6 +1423,7 @@ public static class Defines
             // Raytracing Quality
             public static DefineCollection raytracingDefault = new DefineCollection { { RayTracingQualityNode.GetRayTracingQualityKeyword(), 0 } };
             public static DefineCollection raytracingRaytraced = new DefineCollection { { RayTracingQualityNode.GetRayTracingQualityKeyword(), 1 } };
+            public static DefineCollection raytracingPathtraced = new DefineCollection { { RayTracingQualityNode.GetRayTracingQualityKeyword(), 2 } };
 
             // Path tracing specific defines
             public static DefineCollection pathtracingDisableLightCluster = new DefineCollection { { CoreKeywordDescriptors.DisableLightloopTileAndCluster, 1 }, { CoreKeywordDescriptors.PathTracingclusteredDecals, 1 } };

Packages/com.unity.render-pipelines.high-definition/Editor/Material/ShaderGraph/HDShaderPasses.cs

@@ -13,11 +13,13 @@ class RayTracingQualityNode
     {
         private const string k_KeywordDefault = "RAYTRACING_SHADER_GRAPH_DEFAULT";
         private const string k_KeywordRaytraced = "RAYTRACING_SHADER_GRAPH_RAYTRACED";
+        private const string k_KeywordPathtracer = "RAYTRACING_SHADER_GRAPH_PATHTRACED";
 
         public enum RayTracingQualityVariant
         {
             Default,
-            Raytraced
+            Raytraced,
+            Pathtraced
         }
 
         public static string RaytracingVariantKeyword(RayTracingQualityVariant variant)
@@ -26,6 +28,7 @@ public static string RaytracingVariantKeyword(RayTracingQualityVariant variant)
             {
                 case RayTracingQualityVariant.Default: return k_KeywordDefault;
                 case RayTracingQualityVariant.Raytraced: return k_KeywordRaytraced;
+                case RayTracingQualityVariant.Pathtraced: return k_KeywordPathtracer;
                 default: throw new ArgumentOutOfRangeException(nameof(variant));
             }
         }
@@ -46,6 +49,7 @@ public static KeywordDescriptor GetRayTracingQualityKeyword()
                 {
                     new KeywordEntry("Default", "DEFAULT"),
                     new KeywordEntry("Raytraced", "RAYTRACED"),
+                    new KeywordEntry("Pathtraced", "PATHTRACED"),
                 },
             };
         }

Packages/com.unity.render-pipelines.high-definition/Editor/Material/ShaderGraph/Nodes/RayTracingQualityNode.cs

@@ -37,8 +37,9 @@ internal enum ExpandableRendering
             DynamicResolution = 1 << 1,
             LowResTransparency = 1 << 2,
             Water = 1 << 3,
-            ComputeThickness = 1 << 4,
-            HighQualityLineRendering = 1 << 5
+            // Illegal index 1 << 4 since parent Lighting section index is using it
+            HighQualityLineRendering = 1 << 5,
+            ComputeThickness = 1 << 6
         }
 
         internal enum ExpandableDecal
@@ -53,8 +54,9 @@ internal enum ExpandableLighting
             Cookie = 1 << 2,
             Reflection = 1 << 3,
             Sky = 1 << 4,
-            Shadow = 1 << 5,
-            LightLoop = 1 << 6
+            // Illegal index 1 << 5 since parent Lighting section index is using it
+            LightLoop = 1 << 6,
+            Shadow = 1 << 7
         }
 
         internal enum ExpandableLightingQuality

Packages/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/HDRenderPipelineUI.cs

@@ -96,11 +96,11 @@ Material:
         m_Scale: {x: 2, y: 2}
         m_Offset: {x: 0, y: 0}
     - _MaskMap:
-        m_Texture: {fileID: 2800000, guid: decd59cf305ad964bb384d3e0a9bd4b6, type: 3}
+        m_Texture: {fileID: 2800000, guid: 5ed4ee65b96332c489342cd3aa01d63c, type: 3}
         m_Scale: {x: 1, y: 1}
         m_Offset: {x: 0, y: 0}
     - _NormalMap:
-        m_Texture: {fileID: 2800000, guid: 10be5dc71ddc43b41994c5b5d60dde4c, type: 3}
+        m_Texture: {fileID: 2800000, guid: 68d089e25cf7c5e48bf86174b5d00074, type: 3}
         m_Scale: {x: 1, y: 1}
         m_Offset: {x: 0, y: 0}
     - _NormalMapOS:

Packages/com.unity.render-pipelines.high-definition/Samples~/TransparentSamples/Materials/Models/IceCube.mat

@@ -95,11 +95,11 @@ Material:
         m_Scale: {x: 1, y: 1}
         m_Offset: {x: 0, y: 0}
     - _MaskMap:
-        m_Texture: {fileID: 2800000, guid: decd59cf305ad964bb384d3e0a9bd4b6, type: 3}
+        m_Texture: {fileID: 2800000, guid: 5ed4ee65b96332c489342cd3aa01d63c, type: 3}
         m_Scale: {x: 1, y: 1}
         m_Offset: {x: 0, y: 0}
     - _NormalMap:
-        m_Texture: {fileID: 2800000, guid: 10be5dc71ddc43b41994c5b5d60dde4c, type: 3}
+        m_Texture: {fileID: 2800000, guid: 68d089e25cf7c5e48bf86174b5d00074, type: 3}
         m_Scale: {x: 1, y: 1}
         m_Offset: {x: 0, y: 0}
     - _NormalMapOS:

Packages/com.unity.render-pipelines.high-definition/Samples~/TransparentSamples/Materials/Models/Marble Blue.mat

@@ -95,11 +95,11 @@ Material:
         m_Scale: {x: 1, y: 1}
         m_Offset: {x: 0, y: 0}
     - _MaskMap:
-        m_Texture: {fileID: 2800000, guid: decd59cf305ad964bb384d3e0a9bd4b6, type: 3}
+        m_Texture: {fileID: 2800000, guid: 5ed4ee65b96332c489342cd3aa01d63c, type: 3}
         m_Scale: {x: 1, y: 1}
         m_Offset: {x: 0, y: 0}
     - _NormalMap:
-        m_Texture: {fileID: 2800000, guid: 10be5dc71ddc43b41994c5b5d60dde4c, type: 3}
+        m_Texture: {fileID: 2800000, guid: 68d089e25cf7c5e48bf86174b5d00074, type: 3}
         m_Scale: {x: 1, y: 1}
         m_Offset: {x: 0, y: 0}
     - _NormalMapOS: