Remove misleading CommonInst::method, remove unused common InstList (#333)

Author: Lipen

jacodb-api-common/src/main/kotlin/org/jacodb/api/common/cfg/CommonInst.kt

@@ -20,9 +20,6 @@ import org.jacodb.api.common.CommonMethod
 
 interface CommonInst {
     val location: CommonInstLocation
-
-    val method: CommonMethod
-        get() = location.method
 }
 
 interface CommonInstLocation {

jacodb-api-common/src/main/kotlin/org/jacodb/api/common/cfg/InstList.kt

@@ -55,8 +55,6 @@ interface JcInst : CommonInst {
     override val location: JcInstLocation
     val operands: List<JcExpr>
 
-    override val method: JcMethod
-        get() = location.method
     val lineNumber: Int
         get() = location.lineNumber
 

jacodb-api-jvm/src/main/kotlin/org/jacodb/api/jvm/cfg/JcInst.kt

@@ -109,8 +109,8 @@ class JcBlockGraphImpl(
         (block.start.index..block.end.index).map { jcGraph.instructions[it] }
 
     override fun block(inst: JcInst): JcBasicBlock {
-        assert(inst.method == jcGraph.method) {
-            "required method of instruction ${jcGraph.method} but got ${inst.method}"
+        assert(inst.location.method == jcGraph.method) {
+            "required method of instruction ${jcGraph.method} but got ${inst.location.method}"
         }
         for (basicBlock in entries) {
             if (basicBlock.contains(inst)) {

jacodb-core/src/main/kotlin/org/jacodb/impl/cfg/JcBlockGraphImpl.kt

@@ -25,9 +25,6 @@ import org.jacodb.api.common.cfg.CommonReturnInst
 interface EtsStmt : CommonInst {
     override val location: EtsStmtLocation
 
-    override val method: EtsMethod
-        get() = location.method
-
     interface Visitor<out R> {
         fun visit(stmt: EtsNopStmt): R
         fun visit(stmt: EtsAssignStmt): R

jacodb-ets/src/main/kotlin/org/jacodb/ets/model/Stmt.kt

@@ -154,7 +154,7 @@ fun InterproceduralCfg.toHighlightedDotWithCalls(
         val h = sanitize(stmt.hashCode())
         val clusterName = "cluster_${h}_B${parentBlock}"
         // method signature label
-        val methodSig = cfg.entries.first().method.signature
+        val methodSig = cfg.entries.first().location.method.signature
         // open subgraph
         lines += "  subgraph \"$clusterName\" {"
         lines += "    label=\"$methodSig\";"