Prohibit soot.dummy.InvokeDynamic in summaries name and comment text #1869 (#2396)

Prohibit `soot.dummy.InvokeDynamic` in summaries text

Author: sofurihafe

utbot-summary/src/main/kotlin/org/utbot/summary/comment/SentenceUtil.kt

@@ -91,15 +91,26 @@ val nextSynonyms = arrayOf(
     "then"
 )
 
-val skipInvokes = arrayOf(
+val forbiddenMethodInvokes = arrayOf(
     "<init>",
     "<clinit>",
     "valueOf",
-    "getClass"
+    "getClass",
 )
 
-// TODO: SAT-1589
-fun shouldSkipInvoke(invoke: String) = (invoke in skipInvokes) || (invoke.endsWith('$'))
+val forbiddenClassInvokes = arrayOf(
+    "soot.dummy.InvokeDynamic"
+)
+
+/**
+ * Filters out
+ * ```soot.dummy.InvokeDynamic#makeConcat```,
+ * ```soot.dummy.InvokeDynamic#makeConcatWithConstants```,
+ * constructor calls (```<init>```), ```bootstrap$```
+ * and other unwanted things from name and comment text.
+ */
+fun shouldSkipInvoke(className: String, methodName: String) =
+    className in forbiddenClassInvokes || methodName in forbiddenMethodInvokes || methodName.endsWith("$")
 
 fun squashDocRegularStatements(sentences: List<DocStatement>): List<DocStatement> {
     val newStatements = mutableListOf<DocStatement>()

utbot-summary/src/main/kotlin/org/utbot/summary/comment/classic/symbolic/SimpleCommentBuilder.kt

@@ -301,8 +301,9 @@ open class SimpleCommentBuilder(
      */
     protected fun addTextRecursion(sentenceBlock: SimpleSentenceBlock, stmt: Stmt, frequency: Int) {
         if (stmt is JAssignStmt || stmt is JInvokeStmt) {
+            val className = stmt.invokeExpr.methodRef.declaringClass.name
             val methodName = stmt.invokeExpr.method.name
-            addTextRecursion(sentenceBlock, methodName, frequency)
+            addTextRecursion(sentenceBlock, className, methodName, frequency)
         }
     }
 
@@ -337,7 +338,7 @@ open class SimpleCommentBuilder(
         isPrivate: Boolean,
         frequency: Int
     ) {
-        if (!shouldSkipInvoke(methodName))
+        if (!shouldSkipInvoke(className, methodName))
             sentenceBlock.stmtTexts.add(
                 StmtDescription(
                     StmtType.Invoke,
@@ -352,10 +353,11 @@ open class SimpleCommentBuilder(
      */
     protected fun addTextRecursion(
         sentenceBlock: SimpleSentenceBlock,
+        className: String,
         methodName: String,
         frequency: Int
     ) {
-        if (!shouldSkipInvoke(methodName))
+        if (!shouldSkipInvoke(className, methodName))
             sentenceBlock.stmtTexts.add(
                 StmtDescription(
                     StmtType.RecursionAssignment,

utbot-summary/src/main/kotlin/org/utbot/summary/name/SimpleNameBuilder.kt

@@ -385,11 +385,12 @@ class SimpleNameBuilder(
                     prefix = "Return"
                     name = name ?: ""
                 } else if (statementTag.basicTypeTag == BasicTypeTag.Invoke && statementTag.uniquenessTag == UniquenessTag.Unique) {
+                    val declaringClass = stmt.invokeExpr.methodRef.declaringClass
                     val methodName = stmt.invokeExpr.method.name.capitalize()
-                    if (!shouldSkipInvoke(methodName)) {
+                    if (!shouldSkipInvoke(declaringClass.name, methodName)) {
                         if (stmt is JAssignStmt || stmt is JInvokeStmt) {
                             type = NameType.Invoke
-                            prefix += stmt.invokeExpr.methodRef.declaringClass.javaStyleName.substringBefore('$') //class name
+                            prefix += declaringClass.javaStyleName.substringBefore('$')
                             prefix += methodName
                             name =
                                 "" //todo change var name to val name, everything should be mapped through .convertNodeToString