Merge pull request #509 from Nikita240/patch-1

streamtw · web-flow · commit d646d3fecb74 · 2018-01-08T10:38:48.000+08:00
Prevent Container::make() from type-hinting the parameters
diff --git a/src/LfmPath.php b/src/LfmPath.php
@@ -120,7 +120,7 @@ public function pretty($item_path)
         $lfm_path = clone $this;
         $lfm_path = $lfm_path->setName($this->helper->getNameFromPath($item_path));
 
-        return Container::getInstance()->make(LfmItem::class, [$lfm_path, $this->helper]);
+        return Container::getInstance()->makeWith(LfmItem::class, ['lfm' => $lfm_path, 'helper' => $this->helper]);
     }
 
     public function delete()

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ public function pretty($item_path)`
`120`	`120`	`$lfm_path = clone $this;`
`121`	`121`	`$lfm_path = $lfm_path->setName($this->helper->getNameFromPath($item_path));`
`122`	`122`
`123`		`- return Container::getInstance()->make(LfmItem::class, [$lfm_path, $this->helper]);`
	`123`	`+ return Container::getInstance()->makeWith(LfmItem::class, ['lfm' => $lfm_path, 'helper' => $this->helper]);`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`public function delete()`