Skip to content

Commit 4fd3315

Browse files
move security check before save file
1 parent e2f9fd5 commit 4fd3315

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/controllers/UploadController.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,17 +121,21 @@ private function uploadValidator($file)
121121
return 'pass';
122122
}
123123

124+
protected function replaceInsecureSuffix($name)
125+
{
126+
return preg_replace("/\.php$/", '', $name);
127+
}
128+
124129
private function getNewName($file)
125130
{
126131
$new_filename = parent::translateFromUtf8(trim($this->_pathinfo($file->getClientOriginalName(), PATHINFO_FILENAME)));
127-
$new_filename = preg_replace("/\.php$/", '', $new_filename);
128132
if (config('lfm.rename_file') === true) {
129133
$new_filename = uniqid();
130134
} elseif (config('lfm.alphanumeric_filename') === true) {
131135
$new_filename = preg_replace('/[^A-Za-z0-9\-\']/', '_', $new_filename);
132136
}
133137

134-
return $new_filename . '.' . $file->getClientOriginalExtension();
138+
return $new_filename . $this->replaceInsecureSuffix('.' . $file->getClientOriginalExtension());
135139
}
136140

137141
private function makeThumb($new_filename)

0 commit comments

Comments
 (0)