Skip to content

Commit 45835ab

Browse files
authored
Merge pull request #349 from UniSharp/analysis-qrEpox
Apply fixes from StyleCI
2 parents 6976957 + 00d759b commit 45835ab

25 files changed

+163
-152
lines changed

src/LaravelFilemanagerServiceProvider.php

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
1-
<?php namespace Unisharp\Laravelfilemanager;
1+
<?php
2+
3+
namespace Unisharp\Laravelfilemanager;
24

3-
use Illuminate\Support\ServiceProvider;
45
use Illuminate\Support\Facades\Config;
6+
use Illuminate\Support\ServiceProvider;
57

68
/**
7-
* Class LaravelFilemanagerServiceProvider
8-
* @package Unisharp\Laravelfilemanager
9+
* Class LaravelFilemanagerServiceProvider.
910
*/
10-
class LaravelFilemanagerServiceProvider extends ServiceProvider {
11-
11+
class LaravelFilemanagerServiceProvider extends ServiceProvider
12+
{
1213
/**
1314
* Bootstrap the application services.
1415
*
@@ -37,7 +38,7 @@ public function boot()
3738
], 'lfm_view');
3839

3940
$this->publishes([
40-
__DIR__.'/Handlers/LfmConfigHandler.php' => base_path('app/Handlers/LfmConfigHandler.php')
41+
__DIR__.'/Handlers/LfmConfigHandler.php' => base_path('app/Handlers/LfmConfigHandler.php'),
4142
], 'lfm_handler');
4243
}
4344

src/config/lfm.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
// Middlewares which should be applied to all package routes.
1414
// For laravel 5.1 and before, remove 'web' from the array.
15-
'middlewares' => ['web','auth'],
15+
'middlewares' => ['web', 'auth'],
1616

1717
// The url to this package. Change it if necessary.
1818
'prefix' => 'laravel-filemanager',
@@ -164,7 +164,7 @@
164164
| directives are not supported.
165165
*/
166166
'php_ini_overrides' => [
167-
'memory_limit' => '256M'
168-
]
167+
'memory_limit' => '256M',
168+
],
169169

170170
];

src/controllers/Controller.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
<?php namespace Unisharp\Laravelfilemanager\controllers;
1+
<?php
2+
3+
namespace Unisharp\Laravelfilemanager\controllers;
24

35
use Illuminate\Foundation\Bus\DispatchesJobs;
46
use Illuminate\Routing\Controller as BaseController;

src/controllers/CropController.php

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
1-
<?php namespace Unisharp\Laravelfilemanager\controllers;
1+
<?php
2+
3+
namespace Unisharp\Laravelfilemanager\controllers;
24

3-
use Unisharp\Laravelfilemanager\controllers\Controller;
45
use Intervention\Image\Facades\Image;
56
use Unisharp\Laravelfilemanager\Events\ImageIsCropping;
67
use Unisharp\Laravelfilemanager\Events\ImageWasCropped;
78

89
/**
9-
* Class CropController
10-
* @package Unisharp\Laravelfilemanager\controllers
10+
* Class CropController.
1111
*/
1212
class CropController extends LfmController
1313
{
1414
/**
15-
* Show crop page
15+
* Show crop page.
1616
*
1717
* @return mixed
1818
*/
@@ -25,20 +25,19 @@ public function getCrop()
2525
->with(compact('working_dir', 'img'));
2626
}
2727

28-
2928
/**
30-
* Crop the image (called via ajax)
29+
* Crop the image (called via ajax).
3130
*/
3231
public function getCropimage($overWrite = true)
3332
{
34-
$dataX = request('dataX');
35-
$dataY = request('dataY');
33+
$dataX = request('dataX');
34+
$dataY = request('dataY');
3635
$dataHeight = request('dataHeight');
37-
$dataWidth = request('dataWidth');
36+
$dataWidth = request('dataWidth');
3837
$image_path = parent::getCurrentPath(request('img'));
39-
$crop_path = $image_path;
38+
$crop_path = $image_path;
4039

41-
if(!$overWrite) {
40+
if (! $overWrite) {
4241
$fileParts = explode('.', request('img'));
4342
$fileParts[count($fileParts) - 2] = $fileParts[count($fileParts) - 2] . '_cropped_' . time();
4443
$crop_path = parent::getCurrentPath(implode('.', $fileParts));

src/controllers/DeleteController.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
1-
<?php namespace Unisharp\Laravelfilemanager\controllers;
1+
<?php
2+
3+
namespace Unisharp\Laravelfilemanager\controllers;
24

35
use Illuminate\Support\Facades\File;
46
use Unisharp\Laravelfilemanager\Events\ImageIsDeleting;
57
use Unisharp\Laravelfilemanager\Events\ImageWasDeleted;
68

79
/**
8-
* Class CropController
9-
* @package Unisharp\Laravelfilemanager\controllers
10+
* Class CropController.
1011
*/
1112
class DeleteController extends LfmController
1213
{
1314
/**
14-
* Delete image and associated thumbnail
15+
* Delete image and associated thumbnail.
1516
*
1617
* @return mixed
1718
*/
@@ -28,12 +29,12 @@ public function getDelete()
2829
return parent::error('folder-name');
2930
}
3031

31-
if (!File::exists($file_to_delete)) {
32+
if (! File::exists($file_to_delete)) {
3233
return parent::error('folder-not-found', ['folder' => $file_to_delete]);
3334
}
3435

3536
if (File::isDirectory($file_to_delete)) {
36-
if (!parent::directoryIsEmpty($file_to_delete)) {
37+
if (! parent::directoryIsEmpty($file_to_delete)) {
3738
return parent::error('delete-folder');
3839
}
3940

src/controllers/DemoController.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
<?php namespace Unisharp\Laravelfilemanager\controllers;
1+
<?php
2+
3+
namespace Unisharp\Laravelfilemanager\controllers;
24

35
/**
4-
* Class DemoController
5-
* @package Unisharp\Laravelfilemanager\controllers
6+
* Class DemoController.
67
*/
78
class DemoController extends LfmController
89
{
9-
1010
/**
1111
* @return mixed
1212
*/

src/controllers/DownloadController.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
1-
<?php namespace Unisharp\Laravelfilemanager\controllers;
1+
<?php
2+
3+
namespace Unisharp\Laravelfilemanager\controllers;
24

35
/**
4-
* Class DownloadController
5-
* @package Unisharp\Laravelfilemanager\controllers
6+
* Class DownloadController.
67
*/
78
class DownloadController extends LfmController
89
{
910
/**
10-
* Download a file
11+
* Download a file.
1112
*
1213
* @return mixed
1314
*/

src/controllers/FolderController.php

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
1-
<?php namespace Unisharp\Laravelfilemanager\controllers;
1+
<?php
2+
3+
namespace Unisharp\Laravelfilemanager\controllers;
24

35
use Illuminate\Support\Facades\File;
46

57
/**
6-
* Class FolderController
7-
* @package Unisharp\Laravelfilemanager\controllers
8+
* Class FolderController.
89
*/
910
class FolderController extends LfmController
1011
{
1112
/**
12-
* Get list of folders as json to populate treeview
13+
* Get list of folders as json to populate treeview.
1314
*
1415
* @return mixed
1516
*/
@@ -34,21 +35,20 @@ public function getFolders()
3435
return strcmp($a->name, $b->name);
3536
});
3637

37-
array_push($root_folders, (object)[
38+
array_push($root_folders, (object) [
3839
'name' => trans('laravel-filemanager::lfm.title-' . $lang_key),
3940
'path' => parent::getInternalPath($root_folder_path),
4041
'children' => $children,
41-
'has_next' => !($lang_key == end($folder_types))
42+
'has_next' => ! ($lang_key == end($folder_types)),
4243
]);
4344
}
4445

4546
return view('laravel-filemanager::tree')
4647
->with(compact('root_folders'));
4748
}
4849

49-
5050
/**
51-
* Add a new folder
51+
* Add a new folder.
5252
*
5353
* @return mixed
5454
*/
@@ -66,6 +66,7 @@ public function getAddfolder()
6666
return parent::error('folder-alnum');
6767
} else {
6868
parent::createFolderByPath($path);
69+
6970
return parent::$success_response;
7071
}
7172
}

src/controllers/ItemsController.php

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
1-
<?php namespace Unisharp\Laravelfilemanager\controllers;
1+
<?php
22

3-
use Illuminate\Support\Facades\File;
3+
namespace Unisharp\Laravelfilemanager\controllers;
44

55
/**
6-
* Class ItemsController
7-
* @package Unisharp\Laravelfilemanager\controllers
6+
* Class ItemsController.
87
*/
98
class ItemsController extends LfmController
109
{
1110
/**
12-
* Get the images to load for a selected folder
11+
* Get the images to load for a selected folder.
1312
*
1413
* @return mixed
1514
*/
@@ -22,22 +21,21 @@ public function getItems()
2221
$directories = parent::sortFilesAndDirectories(parent::getDirectories($path), $sort_type);
2322

2423
return [
25-
'html' => (string)view($this->getView())->with([
24+
'html' => (string) view($this->getView())->with([
2625
'files' => $files,
2726
'directories' => $directories,
28-
'items' => array_merge($directories, $files)
27+
'items' => array_merge($directories, $files),
2928
]),
30-
'working_dir' => parent::getInternalPath($path)
29+
'working_dir' => parent::getInternalPath($path),
3130
];
3231
}
3332

34-
3533
private function getView()
3634
{
3735
$view_type = 'grid';
3836
$show_list = request('show_list');
3937

40-
if ($show_list === "1") {
38+
if ($show_list === '1') {
4139
$view_type = 'list';
4240
} elseif (is_null($show_list)) {
4341
$type_key = parent::currentLfmType();

src/controllers/LfmController.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
1-
<?php namespace Unisharp\Laravelfilemanager\controllers;
1+
<?php
2+
3+
namespace Unisharp\Laravelfilemanager\controllers;
24

35
use Unisharp\Laravelfilemanager\traits\LfmHelpers;
46

57
/**
6-
* Class LfmController
7-
* @package Unisharp\Laravelfilemanager\controllers
8+
* Class LfmController.
89
*/
910
class LfmController extends Controller
1011
{
@@ -18,7 +19,7 @@ public function __construct()
1819
}
1920

2021
/**
21-
* Show the filemanager
22+
* Show the filemanager.
2223
*
2324
* @return mixed
2425
*/
@@ -39,7 +40,7 @@ public function getErrors()
3940
$mine_config = 'lfm.valid_' . $type_key . '_mimetypes';
4041
$config_error = null;
4142

42-
if (!is_array(config($mine_config))) {
43+
if (! is_array(config($mine_config))) {
4344
array_push($arr_errors, 'Config : ' . $mine_config . ' is not a valid array.');
4445
}
4546

0 commit comments

Comments
 (0)