Skip to content

Commit 44eafbf

Browse files
authored
Merge pull request #9 from TysonAndre/update-ast-logic
Update README, update composer.json
2 parents 9a489f8 + f662a8a commit 44eafbf

File tree

4 files changed

+154
-276
lines changed

4 files changed

+154
-276
lines changed

README.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@ PHP-Parser to php-ast
33

44
[![Build Status](https://travis-ci.org/TysonAndre/php-parser-to-php-ast.svg?branch=master)](https://travis-ci.org/TysonAndre/php-parser-to-php-ast)
55

6-
5 out of 28 tests are failing, and only due to line numbers being wrong in php-ast. This is fixed in php 7.1-dev (will be in 7.1.4)
6+
8 out of 41 tests are failing, and only due to namespace support and line numbers being slightly different in php-ast.
7+
8+
- The test suite is not yet comprehensive.
79

810
[Current Issues](https://github.com/TysonAndre/php-parser-to-php-ast/issues/)
911

@@ -24,6 +26,13 @@ Using it as an error-tolerant substitute for php-ast (e.g. for use in IDEs)
2426
- Placeholders may change in the future.
2527
- [tests/ASTConverter/ErrorTolerantConversionTest.php](https://github.com/TysonAndre/php-parser-to-php-ast/blob/master/tests/ASTConverter/ErrorTolerantConversionTest.php)
2628

29+
Running unit tests
30+
------------------
31+
32+
To run unit tests, you must install [nikic/php-ast](https://github.com/nikic/php-ast)
33+
34+
- Then run `vendor/bin/phpunit`
35+
2736
Possible Future Enhancements
2837
----------------------------
2938

composer.json

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,13 @@
33
"description": "A php-parser to php-ast converter written in php",
44
"require": {
55
"php": ">=7.1",
6-
"nikic/PHP-Parser": "3.0.5",
7-
"ext-ast": "~0.1.4"
6+
"nikic/PHP-Parser": "3.0.5"
87
},
98
"require-dev": {
10-
"phpunit/phpunit": "~6.2"
9+
"phpunit/phpunit": "^5.7"
10+
},
11+
"suggest": {
12+
"ext-ast": "~0.1.4"
1113
},
1214
"autoload": {
1315
"psr-4": {"ASTConverter\\": "src/ASTConverter"}

0 commit comments

Comments
 (0)