Make more things translatable and partially fix existing stuff #482
Conversation
arch1t3cht
left a comment
arch1t3cht
left a comment
There was a problem hiding this comment.
Thanks! Just a few small comments.
Finally: Could you squash the first two commits together? (Or give the first one a more detailed commit message?)
I... have no clue either how to squash commits or how to edit a commit's description |
That's fine, I can do that for you before merging. (If you'd like to do it yourself, the relevant command here is |
|
I've being trying to squash commits for like an hour. In the end, I kinda managed to squash them, but now it tries to push changes directly to the upstream and not to my fork, so I'm stuck again |
|
I give up |
|
No worries, I'll push the squashed version to your branch and merge once the CI finishes. |
arch1t3cht
force-pushed
the
translations
branch
from
b251382 to
2cf7196
Compare
aegisublocale.cpp -- Make dialog window translatable
auto4_base.cpp -- Make warning logs translatable
auto4_lua.cpp -- Make descriptions used in the Create() function translatable
dialog_attachments.cpp -- Make file types translatable --> I also noticed that the file extraction dialog only has one file type ("Font Files"), so I added two new types: "All Supported Formats" and "Graphic Files"
dialog_automation.cpp -- Make warning log translatable
dialog_dummy_video.cpp -- Make resolution names translatable
dialog_export.cpp -- Make message boxes translatable
dialog_properties.cpp -- Make "YCbCr Matrix:" string translatable
dialog_spellchecker.cpp -- Make message boxes translatable
dialog_style_manager.cpp -- Make message boxes translatable
main.cpp -- Make message boxes translatable
preferences.cpp -- Make FFmpegSource's log levels, search bar and columns' titles of hotkey table translatable
project.cpp -- Make message boxes translatable
subs_controller.cpp -- Make "Untitled" string filename and messages translatable
subs_preview.cpp -- Make message box translatable
video_provider_manager.cpp -- Make error strings translatable
macro-2-mkfullwitdh.lua -- Make script metadata translatable
timecode.cpp -- Fix file types names video.cpp -- Fix descriptions of "video play" commands: "video/play" -> fixed grammar; "video/play/line" -> made description slightly more verbose to prevent it from fetching translation from "audio/play/line"'s STR_DISP (or STR_MENU, idk) vis_tool.cpp -- Remove suffixes from visual vector tools
arch1t3cht
force-pushed
the
translations
branch
from
2cf7196 to
b80e379
Compare
|
By the way, after you regenerated the pot file, four tags located in the |
|
Yes, I saw that. These strings were added in #479 a couple of days ago. There's probably some version mismatch between xgettext versions that caused these strings to get emitted for #479's author but not for me. My xgettext is on the latest version (0.26), though, so it's probably correct to remove these strings. Either way, they're not really important. |
|
Oh, I think you're right. I had these strings too, and it turned out that I have the 0.23.1 version on my Fedora, very weird... |
2 participants
Please note that I haven’t made every single existing string to be translatable . In general, I’ve added translation support only for stuff I personally understand and can somewhat test
The code compiles without errors (at least on Windows). Although, as always - trust, but verify