Fix a few compiler warnings

Author: arch1t3cht

libaegisub/common/karaoke_matcher.cpp

@@ -19,7 +19,6 @@
 #include "libaegisub/ass/karaoke.h"
 #include "libaegisub/exception.h"
 #include "libaegisub/kana_table.h"
-#include "libaegisub/scoped_ptr.h"
 #include "libaegisub/util.h"
 
 #include <boost/algorithm/string/case_conv.hpp>
@@ -30,16 +29,6 @@
 #include <unicode/utf8.h>
 
 namespace {
-int32_t next_codepoint(const char *str, size_t *i) {
-	UChar32 c;
-	U8_NEXT_UNSAFE(str, *i, c);
-	return c;
-}
-
-bool is_whitespace(int32_t c) {
-	return !!u_isUWhiteSpace(c);
-}
-
 bool is_whitespace(std::string_view str) {
 	size_t i = 0;
 	while (i < str.size()) {

src/auto4_lua_assfile.cpp

@@ -764,7 +764,7 @@ namespace Automation4 {
 	, can_modify(can_modify)
 	, can_set_undo(can_set_undo)
 	{
-		for (auto& line : ass->Info)
+		for ([[maybe_unused]] auto& line : ass->Info)
 			lines.push_back(nullptr);
 		for (auto& line : ass->Styles)
 			lines.push_back(&line);

src/hotkey.cpp

@@ -47,10 +47,12 @@ namespace {
 		{nullptr}
 	};
 
+#ifdef __WXMAC__
 	const char *added_hotkeys_minimize[][3] = {
 		{"app/minimize", "Default", "Ctrl-M"},
 		{nullptr}
 	};
+#endif
 
 	void migrate_hotkeys(const char *added[][3]) {
 		auto hk_map = hotkey::inst->GetHotkeyMap();

src/placeholder_ctrl.h

@@ -77,7 +77,8 @@ class Placeholder final : public BaseCtrl {
 	/// @param new_value New value of the control
 	///
 	/// If new_value is empty, the control will switch to placeholder mode
-	void ChangeValue(wxString new_value) {
+	void ChangeValue(const wxString& value) override {
+		wxString new_value = value;
 		if (new_value.empty() && !this->HasFocus()) {
 			is_placeholder = true;
 			new_value = placeholder;
@@ -95,7 +96,7 @@ class Placeholder final : public BaseCtrl {
 	}
 
 	/// Override GetValue to return empty when in placeholder mode rather than the placeholder text
-	wxString GetValue() const {
+	wxString GetValue() const override {
 		if (is_placeholder && !this->HasFocus())
 			return "";
 		return BaseCtrl::GetValue();

src/retina_helper.h

@@ -19,8 +19,10 @@
 class wxWindow;
 
 class RetinaHelper {
+#ifdef __WXOSX_COCOA__
 	wxWindow *window;
 	void *observer;
+#endif
 	agi::signal::Signal<int> ScaleFactorChanged;
 public:
 	RetinaHelper(wxWindow *window);

src/subs_edit_ctrl.cpp

@@ -128,7 +128,7 @@ SubsTextEditCtrl::SubsTextEditCtrl(wxWindow* parent, wxSize wsize, long style, a
 		{
 			std::string text = GetTextRaw().data();
 			if (text == line_text) return;
-			line_text = move(text);
+			line_text = std::move(text);
 		}
 
 		UpdateStyle();