fix: runner::spinner new line display

Chemaclass · Chemaclass · commit b4db09f6a822 · 2025-06-09T18:19:49.000+02:00
diff --git a/src/console_results.sh b/src/console_results.sh
@@ -14,7 +14,6 @@ function console_results::render_result() {
 
   if env::is_simple_output_enabled; then
     progress::blank_line
-    progress::blank_line
   fi
 
   local total_tests=0
diff --git a/src/env.sh b/src/env.sh
@@ -30,9 +30,6 @@ _DEFAULT_VERBOSE="false"
 _DEFAULT_BENCH_MODE="false"
 _DEFAULT_PROGRESS_BAR="false"
 
-# Controls if the progress bar should render during execution
-_PROGRESS_ENABLED=true
-
 : "${BASHUNIT_PARALLEL_RUN:=${PARALLEL_RUN:=$_DEFAULT_PARALLEL_RUN}}"
 : "${BASHUNIT_SHOW_HEADER:=${SHOW_HEADER:=$_DEFAULT_SHOW_HEADER}}"
 : "${BASHUNIT_HEADER_ASCII_ART:=${HEADER_ASCII_ART:=$_DEFAULT_HEADER_ASCII_ART}}"
diff --git a/src/runner.sh b/src/runner.sh
@@ -48,10 +48,16 @@ function runner::load_bench_files() {
     runner::clean_set_up_and_tear_down_after_script
   done
 }
-
 function runner::spinner() {
+  if env::is_simple_output_enabled; then
+    printf "\n"
+  fi
+
   local delay=0.1
   local spin_chars="|/-\\"
+
+  trap 'printf "\r \r"' EXIT
+
   while true; do
     for ((i=0; i<${#spin_chars}; i++)); do
       printf "\r%s" "${spin_chars:$i:1}"
diff --git a/tests/acceptance/snapshots/bashunit_benchmark_test_sh.test_bashunit_functional_benchmark.snapshot b/tests/acceptance/snapshots/bashunit_benchmark_test_sh.test_bashunit_functional_benchmark.snapshot
diff --git a/tests/acceptance/snapshots/bashunit_benchmark_test_sh.test_bashunit_runs_benchmark_file.snapshot b/tests/acceptance/snapshots/bashunit_benchmark_test_sh.test_bashunit_runs_benchmark_file.snapshot
diff --git a/tests/acceptance/snapshots/bashunit_fail_test_sh.test_bashunit_when_a_test_fail_simple_output_env.snapshot b/tests/acceptance/snapshots/bashunit_fail_test_sh.test_bashunit_when_a_test_fail_simple_output_env.snapshot
@@ -8,7 +8,6 @@
 |    [2mbut got [0m [1m'0'[0m
 
 
-
 [2mTests:     [0m [32m4 passed[0m, [31m1 failed[0m, 5 total
 [2mAssertions:[0m [32m6 passed[0m, [31m1 failed[0m, 7 total
 
diff --git a/tests/acceptance/snapshots/bashunit_fail_test_sh.test_bashunit_when_a_test_fail_simple_output_option.snapshot b/tests/acceptance/snapshots/bashunit_fail_test_sh.test_bashunit_when_a_test_fail_simple_output_option.snapshot
@@ -8,7 +8,6 @@
 |    [2mbut got [0m [1m'0'[0m
 
 
-
 [2mTests:     [0m [32m4 passed[0m, [31m1 failed[0m, 5 total
 [2mAssertions:[0m [32m6 passed[0m, [31m1 failed[0m, 7 total
 
diff --git a/tests/acceptance/snapshots/bashunit_pass_test_sh.test_bashunit_when_a_test_passes_simple_output_env.snapshot b/tests/acceptance/snapshots/bashunit_pass_test_sh.test_bashunit_when_a_test_passes_simple_output_env.snapshot
@@ -1,5 +1,4 @@
 ....
-
 [2mTests:     [0m [32m4 passed[0m, 4 total
 [2mAssertions:[0m [32m6 passed[0m, 6 total
 
diff --git a/tests/acceptance/snapshots/bashunit_pass_test_sh.test_bashunit_when_a_test_passes_simple_output_option.snapshot b/tests/acceptance/snapshots/bashunit_pass_test_sh.test_bashunit_when_a_test_passes_simple_output_option.snapshot
@@ -1,5 +1,4 @@
 ....
-
 [2mTests:     [0m [32m4 passed[0m, 4 total
 [2mAssertions:[0m [32m6 passed[0m, 6 total
 
diff --git a/tests/acceptance/snapshots/bashunit_stop_on_failure_test_sh.test_bashunit_when_stop_on_failure_env_simple_output.snapshot b/tests/acceptance/snapshots/bashunit_stop_on_failure_test_sh.test_bashunit_when_stop_on_failure_env_simple_output.snapshot
@@ -10,7 +10,6 @@
 |    [2mbut got [0m [1m'2'[0m
 
 
-
 [2mTests:     [0m [32m1 passed[0m, [31m1 failed[0m, 2 total
 [2mAssertions:[0m [32m3 passed[0m, [31m1 failed[0m, 4 total
 

-Original file line number
+Diff line change
 |    [2mbut got [0m [1m'0'[0m
+-
 [2mTests:     [0m [32m4 passed[0m, [31m1 failed[0m, 5 total
 [2mAssertions:[0m [32m6 passed[0m, [31m1 failed[0m, 7 total
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`....`
`2`		`-`
`3`	`2`	`[2mTests: [0m [32m4 passed[0m, 4 total`
`4`	`3`	`[2mAssertions:[0m [32m6 passed[0m, 6 total`
`5`	`4`
-Original file line number
+Diff line change
 |    [2mbut got [0m [1m'2'[0m
+-
 [2mTests:     [0m [32m1 passed[0m, [31m1 failed[0m, 2 total
 [2mAssertions:[0m [32m3 passed[0m, [31m1 failed[0m, 4 total