refactor: improve clock performance

Author: Chemaclass

src/clock.sh

@@ -1,6 +1,15 @@
 #!/usr/bin/env bash
 
 function clock::now() {
+  local shell_time
+  if shell_time="$(clock::shell_time)"; then
+    local seconds="${shell_time%%.*}"
+    local microseconds="${shell_time#*.}"
+
+    math::calculate "($seconds * 1000000000) + ($microseconds * 1000)"
+    return 0
+  fi
+
   if dependencies::has_perl && perl -MTime::HiRes -e "" > /dev/null 2>&1; then
     if perl -MTime::HiRes -e 'printf("%.0f\n",Time::HiRes::time()*1000000000)'; then
         return 0
@@ -27,18 +36,6 @@ function clock::now() {
     fi
   fi
 
-  local shell_time has_shell_time
-  shell_time="$(clock::shell_time)"
-  has_shell_time="$?"
-  if [[ "$has_shell_time" -eq 0 ]]; then
-    local  seconds microseconds
-    seconds=$(echo "$shell_time" | cut -f 1 -d '.')
-    microseconds=$(echo "$shell_time" | cut -f 2 -d '.')
-
-    math::calculate "($seconds * 1000000000) + ($microseconds * 1000)"
-    return 0
-  fi
-
   echo ""
   return 1
 }

tests/unit/clock_test.sh

@@ -15,13 +15,15 @@ function mock_non_existing_fn() {
 }
 
 function test_now_with_perl() {
+  mock clock::shell_time mock_non_existing_fn
   mock perl echo "1720705883457"
 
   assert_same "1720705883457" "$(clock::now)"
 }
 
 function test_now_on_linux_unknown() {
   mock_unknown_linux_os
+  mock clock::shell_time mock_non_existing_fn
   mock perl mock_non_existing_fn
   mock date echo "1720705883457"
 
@@ -30,6 +32,7 @@ function test_now_on_linux_unknown() {
 
 function test_now_on_linux_alpine() {
   mock_alpine_os
+  mock clock::shell_time mock_non_existing_fn
   mock perl echo "1720705883457"
 
   assert_same "1720705883457" "$(clock::now)"
@@ -40,6 +43,7 @@ function test_now_on_windows_without_with_powershell() {
   mock dependencies::has_perl mock_false
   mock dependencies::has_powershell mock_true
   mock powershell echo "1727768183281580800"
+  mock clock::shell_time mock_non_existing_fn
 
   assert_same "1727768183281580800" "$(clock::now)"
 }
@@ -49,6 +53,7 @@ function test_now_on_windows_without_without_powershell() {
   mock dependencies::has_perl mock_false
   mock dependencies::has_powershell mock_false
   mock date echo "1727768951"
+  mock clock::shell_time mock_non_existing_fn
 
   assert_same "1727768951" "$(clock::now)"
 }