fix: .github/workflows/bash30-tests.yml

Author: Chemaclass

.github/workflows/bash30-tests.yml

@@ -7,58 +7,90 @@ on:
       - main
 
 jobs:
-  bash3-setup:
-    name: "Setup - Install Bash 3.0"
+  build-bash30:
+    name: "Build Bash 3.0.22"
     runs-on: ubuntu-latest
-    timeout-minutes: 10
+    timeout-minutes: 20
     steps:
       - name: Checkout
         uses: actions/checkout@v4
         with:
           fetch-depth: 1
 
-      - name: Cache Bash 3.0 Binary
+      - name: Cache Bash 3.0.22 Build
         uses: actions/cache@v4
-        id: cache-bash3
+        id: cache-bash
         with:
-          path: /opt/bash-3.0
-          key: bash-3.0.22-${{ runner.os }}
+          path: /tmp/bash-3.0.22-build
+          key: bash-3.0.22-build-${{ runner.os }}
 
-      - name: Install Bash 3.0
-        if: steps.cache-bash3.outputs.cache-hit != 'true'
+      - name: Download and Build Bash 3.0.22
+        if: steps.cache-bash.outputs.cache-hit != 'true'
         run: |
-          # Update package lists
+          mkdir -p /tmp/bash-3.0.22-build
+          cd /tmp
+
+          # Install build dependencies
           sudo apt-get update
+          sudo apt-get install -y build-essential wget curl
 
-          # Install dependencies for building bash 3.0
-          sudo apt-get install -y \
-            build-essential \
-            curl \
-            git \
-            make
+          # Download bash 3.0.22 from GNU FTP with retries
+          BASH_VERSION="3.0.22"
+          BASH_TARBALL="bash-${BASH_VERSION}.tar.gz"
+          MAX_RETRIES=3
+          RETRY_COUNT=0
 
-          # Download and build bash 3.0.22
-          cd /tmp
-          curl -L https://ftp.gnu.org/gnu/bash/bash-3.0.22.tar.gz -o bash-3.0.22.tar.gz
-          tar xzf bash-3.0.22.tar.gz
-          cd bash-3.0.22
+          while [ $RETRY_COUNT -lt $MAX_RETRIES ]; do
+            echo "Attempt $((RETRY_COUNT+1))/$MAX_RETRIES: Downloading bash ${BASH_VERSION}..."
+
+            # Try different sources in order of reliability
+            if wget --timeout=10 -O "${BASH_TARBALL}" \
+              "https://ftpmirror.gnu.org/bash/${BASH_TARBALL}" 2>&1 | grep -v "^--"; then
+              # Verify the download
+              if tar -tzf "${BASH_TARBALL}" > /dev/null 2>&1; then
+                echo "Successfully downloaded and verified bash ${BASH_VERSION}"
+                break
+              fi
+            fi
+
+            RETRY_COUNT=$((RETRY_COUNT+1))
+            if [ $RETRY_COUNT -lt $MAX_RETRIES ]; then
+              echo "Download failed, retrying in 10 seconds..."
+              sleep 10
+            fi
+          done
 
-          # Configure and build
-          ./configure --prefix=/opt/bash-3.0
-          make
-          sudo make install
+          # Check if we got a valid tarball
+          if ! tar -tzf "${BASH_TARBALL}" > /dev/null 2>&1; then
+            echo "Error: Failed to download valid bash ${BASH_VERSION} tarball"
+            exit 1
+          fi
 
-          # Create symlink for easy access
-          sudo ln -sf /opt/bash-3.0/bin/bash /usr/local/bin/bash3
+          # Extract and build
+          tar xzf "${BASH_TARBALL}"
+          cd "bash-${BASH_VERSION}"
 
-          # Verify installation
-          /usr/local/bin/bash3 --version
+          # Configure for minimal build
+          ./configure \
+            --prefix=/tmp/bash-3.0.22-build \
+            --without-bash-malloc \
+            --disable-nls
+
+          # Build
+          make -j$(nproc)
+
+          # Install to cache directory
+          make install
+
+          # Verify the build
+          /tmp/bash-3.0.22-build/bin/bash --version
+          echo "Bash 3.0.22 successfully built and cached"
 
   bash3-tests:
-    name: "Bash 3.0 Tests - ${{ matrix.test_mode }}"
+    name: "Bash 3.0.22 Tests - ${{ matrix.test_mode }}"
     runs-on: ubuntu-latest
     timeout-minutes: 15
-    needs: bash3-setup
+    needs: build-bash30
     strategy:
       matrix:
         test_mode:
@@ -72,32 +104,34 @@ jobs:
         with:
           fetch-depth: 1
 
-      - name: Restore Bash 3.0 from Cache
+      - name: Restore Bash 3.0.22 Build from Cache
         uses: actions/cache@v4
         with:
-          path: /opt/bash-3.0
-          key: bash-3.0.22-${{ runner.os }}
+          path: /tmp/bash-3.0.22-build
+          key: bash-3.0.22-build-${{ runner.os }}
 
-      - name: Create Bash 3.0 Symlink
-        run: sudo ln -sf /opt/bash-3.0/bin/bash /usr/local/bin/bash3
+      - name: Verify Bash 3.0.22
+        run: |
+          /tmp/bash-3.0.22-build/bin/bash --version
+          echo "Using bash: $(/tmp/bash-3.0.22-build/bin/bash --version | head -1)"
 
       - name: Run Tests - Standard Mode
         if: matrix.test_mode == 'standard'
         run: |
-          /usr/local/bin/bash3 ./bashunit tests/unit/ -q
+          /tmp/bash-3.0.22-build/bin/bash ./bashunit tests/unit/ -q
         env:
-          BASH: /usr/local/bin/bash3
+          BASH: /tmp/bash-3.0.22-build/bin/bash
 
       - name: Run Tests - Simple Output Mode
         if: matrix.test_mode == 'simple'
         run: |
-          /usr/local/bin/bash3 ./bashunit --simple tests/unit/ -q
+          /tmp/bash-3.0.22-build/bin/bash ./bashunit --simple tests/unit/ -q
         env:
-          BASH: /usr/local/bin/bash3
+          BASH: /tmp/bash-3.0.22-build/bin/bash
 
       - name: Run Tests - Parallel Mode
         if: matrix.test_mode == 'parallel'
         run: |
-          /usr/local/bin/bash3 ./bashunit --parallel tests/unit/ -q
+          /tmp/bash-3.0.22-build/bin/bash ./bashunit --parallel tests/unit/ -q
         env:
-          BASH: /usr/local/bin/bash3
+          BASH: /tmp/bash-3.0.22-build/bin/bash