refactor: support bash 3.0 arrays

Author: Chemaclass

src/assert.sh

@@ -548,7 +548,7 @@ function assert_line_count() {
     local actual
     actual=$(echo "$input_str" | wc -l | tr -d '[:blank:]')
     local additional_new_lines
-    additional_new_lines=$(grep -o '\\n' <<< "$input_str" | wc -l | tr -d '[:blank:]')
+    additional_new_lines=$(echo "$input_str" | grep -o '\\n' | wc -l | tr -d '[:blank:]')
     ((actual+=additional_new_lines))
   fi
 

src/benchmark.sh

@@ -61,7 +61,8 @@ function benchmark::run_function() {
   local revs=$2
   local its=$3
   local max_ms=$4
-  local durations=()
+  local durations
+  durations=()
 
   for ((i=1; i<=its; i++)); do
     local start_time=$(clock::now)
@@ -135,13 +136,15 @@ function benchmark::print_results() {
 
     if (( $(echo "$avg <= $max_ms" | bc -l) )); then
       local raw="≤ ${max_ms}"
-      printf -v padded "%14s" "$raw"
+      local padded
+      padded=$(printf "%14s" "$raw")
       printf '%-40s %6s %6s %10s %12s\n' "$name" "$revs" "$its" "$avg" "$padded"
       continue
     fi
 
     local raw="> ${max_ms}"
-    printf -v padded "%12s" "$raw"
+    local padded
+    padded=$(printf "%12s" "$raw")
     printf '%-40s %6s %6s %10s %s%s%s\n' \
       "$name" "$revs" "$its" "$avg" \
       "$_COLOR_FAILED" "$padded" "${_COLOR_DEFAULT}"

src/clock.sh

@@ -4,7 +4,8 @@ _CLOCK_NOW_IMPL=""
 
 function clock::_choose_impl() {
   local shell_time
-  local attempts=()
+  local attempts
+  attempts=()
 
   # 1. Try Perl with Time::HiRes
   attempts+=("Perl")

src/helpers.sh

@@ -33,7 +33,7 @@ function helper::normalize_test_function_name() {
   # Replace underscores with spaces
   result="${result//_/ }"
   # Capitalize the first letter
-  result="$(tr '[:lower:]' '[:upper:]' <<< "${result:0:1}")${result:1}"
+  result="$(echo "${result:0:1}" | tr '[:lower:]' '[:upper:]')${result:1}"
 
   echo "$result"
 }
@@ -271,7 +271,8 @@ function helper::find_total_tests() {
                 # shellcheck disable=SC2207
                 local functions_to_run=($filtered_functions)
                 for fn_name in "${functions_to_run[@]}"; do
-                    local provider_data=()
+                    local provider_data
+                    provider_data=()
                     while IFS=" " read -r line; do
                         provider_data+=("$line")
                     done <<< "$(helper::get_provider_data "$fn_name" "$file")"
@@ -297,7 +298,8 @@ function helper::load_test_files() {
   local filter=$1
   local files=("${@:2}")
 
-  local test_files=()
+  local test_files
+  test_files=()
 
   if [[ "${#files[@]}" -eq 0 ]]; then
     if [[ -n "${BASHUNIT_DEFAULT_PATH}" ]]; then
@@ -316,7 +318,8 @@ function helper::load_bench_files() {
   local filter=$1
   local files=("${@:2}")
 
-  local bench_files=()
+  local bench_files
+  bench_files=()
 
   if [[ "${#files[@]}" -eq 0 ]]; then
     if [[ -n "${BASHUNIT_DEFAULT_PATH}" ]]; then

src/main.sh

@@ -4,7 +4,8 @@ function main::exec_tests() {
   local filter=$1
   local files=("${@:2}")
 
-  local test_files=()
+  local test_files
+  test_files=()
   while IFS= read -r line; do
     test_files+=("$line")
   done < <(helper::load_test_files "$filter" "${files[@]}")
@@ -82,7 +83,8 @@ function main::exec_benchmarks() {
   local filter=$1
   local files=("${@:2}")
 
-  local bench_files=()
+  local bench_files
+  bench_files=()
   while IFS= read -r line; do
     bench_files+=("$line")
   done < <(helper::load_bench_files "$filter" "${files[@]}")

src/runner.sh

@@ -5,7 +5,8 @@ function runner::load_test_files() {
   local filter=$1
   shift
   local files=("${@}")
-  local scripts_ids=()
+  local scripts_ids
+  scripts_ids=()
 
   for test_file in "${files[@]}"; do
     if [[ ! -f $test_file ]]; then
@@ -189,7 +190,8 @@ function runner::call_test_functions() {
       break
     fi
 
-    local provider_data=()
+    local provider_data
+    provider_data=()
     while IFS=" " read -r line; do
       provider_data+=("$line")
     done <<< "$(helper::get_provider_data "$fn_name" "$script")"
@@ -203,7 +205,8 @@ function runner::call_test_functions() {
 
     # Execute the test function for each line of data
     for data in "${provider_data[@]}"; do
-      local parsed_data=()
+      local parsed_data
+      parsed_data=()
       while IFS= read -r line; do
         parsed_data+=( "$(helper::decode_base64 "${line}")" )
       done <<< "$(runner::parse_data_provider_args "$data")"
@@ -236,7 +239,12 @@ function runner::call_bench_functions() {
   fi
 
   for fn_name in "${functions_to_run[@]}"; do
-    read -r revs its max_ms <<< "$(benchmark::parse_annotations "$fn_name" "$script")"
+    local annotation_result
+    annotation_result="$(benchmark::parse_annotations "$fn_name" "$script")"
+    set -- $annotation_result
+    revs="$1"
+    its="$2"
+    max_ms="$3"
     benchmark::run_function "$fn_name" "$revs" "$its" "$max_ms"
     unset fn_name
   done

src/test_doubles.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-declare -a MOCKED_FUNCTIONS=()
+MOCKED_FUNCTIONS=()
 
 function unmock() {
   local command=$1
@@ -116,7 +116,7 @@ function assert_have_been_called_with() {
   fi
 
   local raw
-  IFS='|' read -r raw _ <<<"$line"
+  raw=$(echo "$line" | cut -d'|' -f1)
 
   if [[ "$expected" != "$raw" ]]; then
     state::add_assertions_failed