refactor: unit/assert_snapshot_test

Author: Chemaclass

tests/unit/assert_snapshot_test.sh

@@ -1,4 +1,5 @@
 #!/usr/bin/env bash
+# shellcheck disable=SC2155
 
 function set_up() {
   export BASHUNIT_SIMPLE_OUTPUT=false
@@ -10,7 +11,6 @@ function test_successful_assert_match_snapshot() {
 }
 
 function test_creates_a_snapshot() {
-  # shellcheck disable=SC2155
   local snapshot_path="$(temp_dir)/assert_snapshot_test_sh.test_creates_a_snapshot.snapshot"
   local expected=$((_ASSERTIONS_SNAPSHOT + 1))
 
@@ -34,19 +34,16 @@ function test_unsuccessful_assert_match_snapshot() {
     Expected to match the snapshot")"
   fi
 
-  local actual
-  actual="$(assert_match_snapshot "Expected snapshot")"
+  local actual="$(assert_match_snapshot "Expected snapshot")"
 
   assert_equals "$expected" "$actual"
 }
 
 function test_successful_assert_match_snapshot_ignore_colors() {
-  local colored
-  colored=$(printf '\e[31mHello\e[0m World!')
+  local colored=$(printf '\e[31mHello\e[0m World!')
   assert_empty "$(assert_match_snapshot_ignore_colors "$colored")"
 }
 
-# shellcheck disable=SC2155
 function test_creates_a_snapshot_ignore_colors() {
   local snapshot_path="$(temp_dir)/assert_snapshot_test_sh.test_creates_a_snapshot_ignore_colors.snapshot"
   local expected=$((_ASSERTIONS_SNAPSHOT + 1))
@@ -72,10 +69,8 @@ function test_unsuccessful_assert_match_snapshot_ignore_colors() {
     Expected to match the snapshot")"
   fi
 
-  local actual
-  local colored
-  colored=$(printf '\e[31mExpected snapshot\e[0m')
-  actual="$(assert_match_snapshot_ignore_colors "$colored")"
+  local colored=$(printf '\e[31mExpected snapshot\e[0m')
+  local actual="$(assert_match_snapshot_ignore_colors "$colored")"
 
   assert_equals "$expected" "$actual"
 }
@@ -85,28 +80,20 @@ function test_assert_match_snapshot_with_placeholder() {
     skip "perl not available" && return
   fi
 
-  local temp_dir
-  temp_dir=$(mktemp -d)
-  local snapshot_path="$temp_dir/assert_snapshot_test_sh.test_assert_match_snapshot_with_placeholder.snapshot"
+  local snapshot_path="$(temp_dir)/assert_snapshot_test_sh.test_assert_match_snapshot_with_placeholder.snapshot"
   echo 'Run at ::ignore::' > "$snapshot_path"
 
   assert_empty "$(assert_match_snapshot "Run at $(date -u '+%F %T UTC')" "$snapshot_path")"
-
-  rm -rf "$temp_dir"
 }
 
 function test_assert_match_snapshot_with_custom_placeholder() {
   if ! dependencies::has_perl; then
     skip "perl not available" && return
   fi
 
-  local temp_dir
-  temp_dir=$(mktemp -d)
-  local snapshot_path="$temp_dir/assert_snapshot_test_sh.test_assert_match_snapshot_with_custom_placeholder.snapshot"
+  local snapshot_path="$(temp_dir)/assert_snapshot_test_sh.test_assert_match_snapshot_with_custom_placeholder.snapshot"
   echo 'Value __ANY__' > "$snapshot_path"
 
   export BASHUNIT_SNAPSHOT_PLACEHOLDER='__ANY__'
   assert_empty "$(assert_match_snapshot "Value 42" "$snapshot_path")"
-
-  rm -rf "$temp_dir"
 }