Skip to content

Commit db80755

Browse files
committed
Implement review comments and fixed test
1 parent 2c5be96 commit db80755

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

packages/examples/resources/styles/views.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
#editors {
3737
position: relative;
3838
min-width: 0;
39-
height: 95%;
39+
height: 99%;
4040
border: 1px solid var(--vscode-editorWidget-border);
4141
}
4242

packages/examples/src/appPlayground/common.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
* ------------------------------------------------------------------------------------------ */
55

66
import * as vscode from 'vscode';
7-
import { getService, IWorkbenchLayoutService } from 'vscode/services';
87
import { RegisterLocalProcessExtensionResult } from 'vscode/extensions';
98
import { MonacoEditorLanguageClientWrapper } from 'monaco-editor-wrapper';
109
import { ConfigResult } from './config.js';
@@ -13,9 +12,6 @@ export const configurePostStart = async (wrapper: MonacoEditorLanguageClientWrap
1312
const result = wrapper.getExtensionRegisterResult('mlc-app-playground') as RegisterLocalProcessExtensionResult;
1413
result.setAsDefaultApi();
1514

16-
// currently unused
17-
await getService(IWorkbenchLayoutService);
18-
1915
// WA: Force show explorer and not search
2016
// await vscode.commands.executeCommand('workbench.view.explorer');
2117

packages/wrapper-react/src/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ export const MonacoEditorReactComp: React.FC<MonacoEditorProps> = (props) => {
102102
});
103103

104104
const viewServiceType = wrapperConfig.vscodeApiConfig?.viewsConfig?.viewServiceType;
105-
if (viewServiceType === 'EditorService') {
105+
if (viewServiceType === 'EditorService' || viewServiceType === undefined) {
106106
await wrapperRef.current.start();
107107
}
108108
onLoad?.(wrapperRef.current);

0 commit comments

Comments
 (0)