fix: update the types to have better inference based on options provided

Author: nperez0111

packages/core/src/schema/blocks/createSpec.ts

@@ -290,7 +290,46 @@ export function createBlockSpec<
   TName extends string,
   TProps extends PropSchema,
   TContent extends "inline" | "none",
-  TOptions extends Record<string, any> | undefined = undefined,
+  BlockConf extends BlockConfig<TName, TProps, TContent>,
+  TOptions extends Partial<Record<string, any>>,
+>(
+  blockCreator: (options: Partial<TOptions>) => BlockConf,
+  blockImplementationOrCreator:
+    | BlockImplementation<
+        BlockConf["type"],
+        BlockConf["propSchema"],
+        BlockConf["content"]
+      >
+    | (TOptions extends undefined
+        ? () => BlockImplementation<
+            BlockConf["type"],
+            BlockConf["propSchema"],
+            BlockConf["content"]
+          >
+        : (
+            options: TOptions,
+          ) => BlockImplementation<
+            BlockConf["type"],
+            BlockConf["propSchema"],
+            BlockConf["content"]
+          >),
+  extensionsOrCreator?:
+    | BlockNoteExtension<any>[]
+    | (TOptions extends undefined
+        ? () => BlockNoteExtension<any>[]
+        : (options: TOptions) => BlockNoteExtension<any>[]),
+): (
+  options?: TOptions,
+) => BlockSpec<
+  BlockConf["type"],
+  BlockConf["propSchema"],
+  BlockConf["content"]
+>;
+export function createBlockSpec<
+  TName extends string,
+  TProps extends PropSchema,
+  TContent extends "inline" | "none",
+  TOptions extends Partial<Record<string, any>> | undefined = undefined,
 >(
   blockConfigOrCreator:
     | BlockConfig<TName, TProps, TContent>

packages/react/src/components/Comments/schema.ts

@@ -1,5 +1,5 @@
 import { BlockNoteSchema, defaultStyleSpecs } from "@blocknote/core";
-// import { createParagraphBlockSpec } from "@blocknote/core";
+import { createParagraphBlockSpec } from "@blocknote/core";
 
 // this is quite convoluted. we'll clean this up when we make
 // it easier to extend / customize the default blocks
@@ -9,8 +9,8 @@ const { textColor, backgroundColor, ...styleSpecs } = defaultStyleSpecs;
 
 // the schema to use for comments
 export const schema = BlockNoteSchema.create({
-  // blockSpecs: {
-  //   paragraph: createParagraphBlockSpec(),
-  // },
+  blockSpecs: {
+    paragraph: createParagraphBlockSpec(),
+  },
   styleSpecs,
 });

packages/react/src/schema/ReactBlockSpec.tsx

@@ -117,6 +117,49 @@ export function BlockContentWrapper<
   );
 }
 
+/**
+ * Helper function to create a React block definition.
+ * Can accept either functions that return the required objects, or the objects directly.
+ */
+export function createReactBlockSpec<
+  TName extends string,
+  TProps extends PropSchema,
+  TContent extends "inline" | "none",
+  BlockConf extends BlockConfig<TName, TProps, TContent>,
+  TOptions extends Partial<Record<string, any>>,
+>(
+  blockCreator: (options: Partial<TOptions>) => BlockConf,
+  blockImplementationOrCreator:
+    | ReactCustomBlockImplementation<
+        BlockConf["type"],
+        BlockConf["propSchema"],
+        BlockConf["content"]
+      >
+    | (TOptions extends undefined
+        ? () => ReactCustomBlockImplementation<
+            BlockConf["type"],
+            BlockConf["propSchema"],
+            BlockConf["content"]
+          >
+        : (
+            options: TOptions,
+          ) => ReactCustomBlockImplementation<
+            BlockConf["type"],
+            BlockConf["propSchema"],
+            BlockConf["content"]
+          >),
+  extensionsOrCreator?:
+    | BlockNoteExtension<any>[]
+    | (TOptions extends undefined
+        ? () => BlockNoteExtension<any>[]
+        : (options: TOptions) => BlockNoteExtension<any>[]),
+): (
+  options?: TOptions,
+) => BlockSpec<
+  BlockConf["type"],
+  BlockConf["propSchema"],
+  BlockConf["content"]
+>;
 export function createReactBlockSpec<
   TName extends string,
   TProps extends PropSchema,