Skip to content

Commit 88c5bf8

Browse files
mrgames13mrgames13
committed
Prettify code
1 parent 5f8ff25 commit 88c5bf8

File tree

9 files changed

+149
-180
lines changed

9 files changed

+149
-180
lines changed

‎library/src/main/java/com/developer/filepicker/controller/adapters/FileListAdapter.java‎

Lines changed: 38 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
/**
2828
* @author akshay sunil masram
2929
*/
30-
public class FileListAdapter extends BaseAdapter{
30+
public class FileListAdapter extends BaseAdapter {
3131
private ArrayList<FileListItem> listItem;
3232
private Context context;
3333
private DialogProperties properties;
@@ -61,87 +61,74 @@ public View getView(final int i, View view, ViewGroup viewGroup) {
6161
view = LayoutInflater.from(context).inflate(R.layout.dialog_file_list_item, viewGroup, false);
6262
holder = new ViewHolder(view);
6363
view.setTag(holder);
64-
}
65-
else
66-
{ holder = (ViewHolder)view.getTag();
64+
} else {
65+
holder = (ViewHolder) view.getTag();
6766
}
6867
final FileListItem item = listItem.get(i);
6968
if (MarkedItemList.hasItem(item.getLocation())) {
70-
Animation animation = AnimationUtils.loadAnimation(context,R.anim.marked_item_animation);
69+
Animation animation = AnimationUtils.loadAnimation(context, R.anim.marked_item_animation);
7170
view.setAnimation(animation);
72-
}
73-
else {
74-
Animation animation = AnimationUtils.loadAnimation(context,R.anim.unmarked_item_animation);
71+
} else {
72+
Animation animation = AnimationUtils.loadAnimation(context, R.anim.unmarked_item_animation);
7573
view.setAnimation(animation);
7674
}
7775
if (item.isDirectory()) {
7876
holder.type_icon.setImageResource(R.mipmap.ic_type_folder);
7977
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
80-
holder.type_icon.setColorFilter(context.getResources().getColor(R.color.colorPrimary,context.getTheme()));
81-
}
82-
else
83-
{ holder.type_icon.setColorFilter(context.getResources().getColor(R.color.colorPrimary));
78+
holder.type_icon.setColorFilter(context.getResources().getColor(R.color.colorPrimary, context.getTheme()));
79+
} else {
80+
holder.type_icon.setColorFilter(context.getResources().getColor(R.color.colorPrimary));
8481
}
85-
if(properties.selection_type == DialogConfigs.FILE_SELECT)
86-
{ holder.fmark.setVisibility(View.INVISIBLE);
82+
if (properties.selection_type == DialogConfigs.FILE_SELECT) {
83+
holder.fmark.setVisibility(View.INVISIBLE);
84+
} else {
85+
holder.fmark.setVisibility(View.VISIBLE);
8786
}
88-
else
89-
{ holder.fmark.setVisibility(View.VISIBLE);
90-
}
91-
}
92-
else {
87+
} else {
9388
holder.type_icon.setImageResource(R.mipmap.ic_type_file);
9489
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
95-
holder.type_icon.setColorFilter(context.getResources().getColor(R.color.colorAccent,context.getTheme()));
96-
}
97-
else
98-
{ holder.type_icon.setColorFilter(context.getResources().getColor(R.color.colorAccent));
90+
holder.type_icon.setColorFilter(context.getResources().getColor(R.color.colorAccent, context.getTheme()));
91+
} else {
92+
holder.type_icon.setColorFilter(context.getResources().getColor(R.color.colorAccent));
9993
}
100-
if(properties.selection_type == DialogConfigs.DIR_SELECT)
101-
{ holder.fmark.setVisibility(View.INVISIBLE);
102-
}
103-
else
104-
{ holder.fmark.setVisibility(View.VISIBLE);
94+
if (properties.selection_type == DialogConfigs.DIR_SELECT) {
95+
holder.fmark.setVisibility(View.INVISIBLE);
96+
} else {
97+
holder.fmark.setVisibility(View.VISIBLE);
10598
}
10699
}
107100
holder.type_icon.setContentDescription(item.getFilename());
108101
holder.name.setText(item.getFilename());
109102
DateFormat dateFormatter = android.text.format.DateFormat.getMediumDateFormat(context);
110103
DateFormat timeFormatter = android.text.format.DateFormat.getTimeFormat(context);
111-
//SimpleDateFormat sdate = new SimpleDateFormat("dd/MM/yyyy", Locale.getDefault());
112-
//SimpleDateFormat stime = new SimpleDateFormat("hh:mm aa", Locale.getDefault());
113104
Date date = new Date(item.getTime());
114-
if(i==0&&item.getFilename().startsWith(context.getString(R.string.label_parent_dir))) {
105+
if (i == 0 && item.getFilename().startsWith(context.getString(R.string.label_parent_dir))) {
115106
holder.type.setText(R.string.label_parent_directory);
116-
}
117-
else {
107+
} else {
118108
holder.type.setText(String.format(context.getString(R.string.last_edit), dateFormatter.format(date), timeFormatter.format(date)));
119109
}
120-
if(holder.fmark.getVisibility()==View.VISIBLE) {
121-
if(i==0&&item.getFilename().startsWith(context.getString(R.string.label_parent_dir)))
122-
{ holder.fmark.setVisibility(View.INVISIBLE);
110+
if (holder.fmark.getVisibility() == View.VISIBLE) {
111+
if (i == 0 && item.getFilename().startsWith(context.getString(R.string.label_parent_dir))) {
112+
holder.fmark.setVisibility(View.INVISIBLE);
123113
}
124114
if (MarkedItemList.hasItem(item.getLocation())) {
125115
holder.fmark.setChecked(true);
126-
}
127-
else {
116+
} else {
128117
holder.fmark.setChecked(false);
129118
}
130119
}
131-
120+
132121
holder.fmark.setOnCheckedChangedListener(new OnCheckedChangeListener() {
133122
@Override
134123
public void onCheckedChanged(MaterialCheckbox checkbox, boolean isChecked) {
135124
item.setMarked(isChecked);
136125
if (item.isMarked()) {
137-
if(properties.selection_mode == DialogConfigs.MULTI_MODE) {
126+
if (properties.selection_mode == DialogConfigs.MULTI_MODE) {
138127
MarkedItemList.addSelectedItem(item);
139-
}
140-
else {
128+
} else {
141129
MarkedItemList.addSingleFile(item);
142130
}
143-
}
144-
else {
131+
} else {
145132
MarkedItemList.removeSelectedItem(item.getLocation());
146133
}
147134
notifyItemChecked.notifyCheckBoxIsClicked();
@@ -150,16 +137,16 @@ public void onCheckedChanged(MaterialCheckbox checkbox, boolean isChecked) {
150137
return view;
151138
}
152139

153-
private class ViewHolder
154-
{ ImageView type_icon;
155-
TextView name,type;
140+
private class ViewHolder {
141+
ImageView type_icon;
142+
TextView name, type;
156143
MaterialCheckbox fmark;
157144

158145
ViewHolder(View itemView) {
159-
name= itemView.findViewById(R.id.fname);
160-
type= itemView.findViewById(R.id.ftype);
161-
type_icon= itemView.findViewById(R.id.image_type);
162-
fmark= itemView.findViewById(R.id.file_mark);
146+
name = itemView.findViewById(R.id.fname);
147+
type = itemView.findViewById(R.id.ftype);
148+
type_icon = itemView.findViewById(R.id.image_type);
149+
fmark = itemView.findViewById(R.id.file_mark);
163150
}
164151
}
165152

‎library/src/main/java/com/developer/filepicker/view/FilePickerDialog.java‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,7 @@ public void notifyCheckBoxIsClicked() {
128128
int color;
129129
if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.M) {
130130
color = context.getResources().getColor(R.color.colorAccent, context.getTheme());
131-
}
132-
else {
131+
} else {
133132
color = context.getResources().getColor(R.color.colorAccent);
134133
}
135134
select.setTextColor(Color.argb(128, Color.red(color), Color.green(color), Color.blue(color)));
@@ -139,8 +138,7 @@ public void notifyCheckBoxIsClicked() {
139138
int color;
140139
if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.M) {
141140
color = context.getResources().getColor(R.color.colorAccent, context.getTheme());
142-
}
143-
else {
141+
} else {
144142
color = context.getResources().getColor(R.color.colorAccent);
145143
}
146144
select.setTextColor(color);
@@ -188,8 +186,8 @@ protected void onStart() {
188186
super.onStart();
189187
positiveBtnNameStr = (
190188
positiveBtnNameStr == null ?
191-
context.getResources().getString(R.string.choose_button_label) :
192-
positiveBtnNameStr
189+
context.getResources().getString(R.string.choose_button_label) :
190+
positiveBtnNameStr
193191
);
194192
select.setText(positiveBtnNameStr);
195193
if (Utility.checkStorageAccessPermissions(context)) {

‎library/src/main/java/com/developer/filepicker/view/FilePickerPreference.java‎

Lines changed: 41 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public class FilePickerPreference extends Preference implements DialogSelectionL
2323

2424
private FilePickerDialog mDialog;
2525
private DialogProperties properties;
26-
private String titleText=null;
26+
private String titleText = null;
2727

2828
public FilePickerPreference(Context context) {
2929
super(context);
@@ -96,18 +96,17 @@ private void showDialog(Bundle state) {
9696

9797
@Override
9898
public void onSelectedFilePaths(String[] files) {
99-
StringBuilder buff=new StringBuilder();
100-
for(String path:files)
101-
{ buff.append(path).append(":");
99+
StringBuilder buff = new StringBuilder();
100+
for (String path : files) {
101+
buff.append(path).append(":");
102102
}
103103
String dFiles = buff.toString();
104104
if (isPersistent()) {
105105
persistString(dFiles);
106106
}
107107
try {
108108
getOnPreferenceChangeListener().onPreferenceChange(this, dFiles);
109-
}
110-
catch (NullPointerException e) {
109+
} catch (NullPointerException e) {
111110
e.printStackTrace();
112111
}
113112
}
@@ -118,8 +117,8 @@ public boolean onPreferenceClick(Preference preference) {
118117
return false;
119118
}
120119

121-
public void setProperties(DialogProperties properties)
122-
{ mDialog.setProperties(properties);
120+
public void setProperties(DialogProperties properties) {
121+
mDialog.setProperties(properties);
123122
}
124123

125124
private static class SavedState extends BaseSavedState {
@@ -141,56 +140,49 @@ public SavedState(Parcelable superState) {
141140
}
142141

143142
public static final Creator<SavedState> CREATOR =
144-
new Creator<SavedState>() {
145-
public SavedState createFromParcel(Parcel in) {
146-
return new SavedState(in);
147-
}
148-
149-
public SavedState[] newArray(int size) {
150-
return new SavedState[size];
151-
}
152-
};
143+
new Creator<SavedState>() {
144+
public SavedState createFromParcel(Parcel in) {
145+
return new SavedState(in);
146+
}
147+
148+
public SavedState[] newArray(int size) {
149+
return new SavedState[size];
150+
}
151+
};
153152
}
154153

155154
private void initProperties(AttributeSet attrs) {
156-
TypedArray tarr=getContext().getTheme().obtainStyledAttributes(attrs, R.styleable.FilePickerPreference,0,0);
155+
TypedArray tarr = getContext().getTheme().obtainStyledAttributes(attrs, R.styleable.FilePickerPreference, 0, 0);
157156
final int N = tarr.getIndexCount();
158-
for (int i = 0; i < N; ++i)
159-
{ int attr = tarr.getIndex(i);
157+
for (int i = 0; i < N; ++i) {
158+
int attr = tarr.getIndex(i);
160159
if (attr == R.styleable.FilePickerPreference_selection_mode) {
161-
properties.selection_mode=tarr.getInteger(R.styleable.FilePickerPreference_selection_mode, DialogConfigs.SINGLE_MODE);
162-
}
163-
else if (attr == R.styleable.FilePickerPreference_selection_type) {
164-
properties.selection_type=tarr.getInteger(R.styleable.FilePickerPreference_selection_type,DialogConfigs.FILE_SELECT);
165-
}
166-
else if (attr == R.styleable.FilePickerPreference_root_dir) {
167-
String root_dir=tarr.getString(R.styleable.FilePickerPreference_root_dir);
168-
if(root_dir!=null&&!root_dir.equals(""))
169-
{ properties.root=new File(root_dir);
160+
properties.selection_mode = tarr.getInteger(R.styleable.FilePickerPreference_selection_mode, DialogConfigs.SINGLE_MODE);
161+
} else if (attr == R.styleable.FilePickerPreference_selection_type) {
162+
properties.selection_type = tarr.getInteger(R.styleable.FilePickerPreference_selection_type, DialogConfigs.FILE_SELECT);
163+
} else if (attr == R.styleable.FilePickerPreference_root_dir) {
164+
String root_dir = tarr.getString(R.styleable.FilePickerPreference_root_dir);
165+
if (root_dir != null && !root_dir.equals("")) {
166+
properties.root = new File(root_dir);
170167
}
171-
}
172-
else if (attr == R.styleable.FilePickerPreference_error_dir) {
173-
String error_dir=tarr.getString(R.styleable.FilePickerPreference_error_dir);
174-
if(error_dir!=null&&!error_dir.equals(""))
175-
{ properties.error_dir=new File(error_dir);
168+
} else if (attr == R.styleable.FilePickerPreference_error_dir) {
169+
String error_dir = tarr.getString(R.styleable.FilePickerPreference_error_dir);
170+
if (error_dir != null && !error_dir.equals("")) {
171+
properties.error_dir = new File(error_dir);
176172
}
177-
}
178-
else if (attr == R.styleable.FilePickerPreference_offset_dir) {
179-
String offset_dir=tarr.getString(R.styleable.FilePickerPreference_offset_dir);
180-
if(offset_dir!=null&&!offset_dir.equals(""))
181-
{ properties.offset=new File(offset_dir);
173+
} else if (attr == R.styleable.FilePickerPreference_offset_dir) {
174+
String offset_dir = tarr.getString(R.styleable.FilePickerPreference_offset_dir);
175+
if (offset_dir != null && !offset_dir.equals("")) {
176+
properties.offset = new File(offset_dir);
182177
}
183-
}
184-
else if (attr == R.styleable.FilePickerPreference_extensions) {
185-
String extensions=tarr.getString(R.styleable.FilePickerPreference_extensions);
186-
if(extensions!=null&&!extensions.equals(""))
187-
{ properties.extensions= extensions.split(":");
178+
} else if (attr == R.styleable.FilePickerPreference_extensions) {
179+
String extensions = tarr.getString(R.styleable.FilePickerPreference_extensions);
180+
if (extensions != null && !extensions.equals("")) {
181+
properties.extensions = extensions.split(":");
188182
}
189-
}
190-
else if (attr == R.styleable.FilePickerPreference_title_text) {
191-
titleText=tarr.getString(R.styleable.FilePickerPreference_title_text);
192-
}
193-
else if (attr == R.styleable.FilePickerPreference_show_hidden_files) {
183+
} else if (attr == R.styleable.FilePickerPreference_title_text) {
184+
titleText = tarr.getString(R.styleable.FilePickerPreference_title_text);
185+
} else if (attr == R.styleable.FilePickerPreference_show_hidden_files) {
194186
properties.show_hidden_files = tarr.getBoolean(R.styleable.FilePickerPreference_show_hidden_files, false);
195187
}
196188
}

‎library/src/main/java/com/developer/filepicker/widget/MaterialCheckbox.java‎

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import android.os.Build;
1010
import android.util.AttributeSet;
1111
import android.view.View;
12+
1213
import com.developer.filepicker.R;
1314

1415
/**
@@ -58,32 +59,30 @@ public void onClick(View v) {
5859
@Override
5960
protected void onDraw(Canvas canvas) {
6061
super.onDraw(canvas);
61-
if(isChecked()) {
62+
if (isChecked()) {
6263
paint.reset();
6364
paint.setAntiAlias(true);
64-
bounds.set(minDim / 10, minDim / 10, minDim - (minDim/10), minDim - (minDim/10));
65+
bounds.set(minDim / 10, minDim / 10, minDim - (minDim / 10), minDim - (minDim / 10));
6566
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
6667
paint.setColor(getResources().getColor(R.color.colorAccent, context.getTheme()));
67-
}
68-
else {
68+
} else {
6969
paint.setColor(getResources().getColor(R.color.colorAccent));
7070
}
7171
canvas.drawRoundRect(bounds, minDim / 8, minDim / 8, paint);
7272

7373
paint.setColor(Color.parseColor("#FFFFFF"));
74-
paint.setStrokeWidth(minDim/10);
74+
paint.setStrokeWidth(minDim / 10);
7575
paint.setStyle(Paint.Style.STROKE);
7676
paint.setStrokeJoin(Paint.Join.BEVEL);
7777
canvas.drawPath(tick, paint);
78-
}
79-
else {
78+
} else {
8079
paint.reset();
8180
paint.setAntiAlias(true);
82-
bounds.set(minDim / 10, minDim / 10, minDim - (minDim/10), minDim - (minDim/10));
81+
bounds.set(minDim / 10, minDim / 10, minDim - (minDim / 10), minDim - (minDim / 10));
8382
paint.setColor(Color.parseColor("#C1C1C1"));
8483
canvas.drawRoundRect(bounds, minDim / 8, minDim / 8, paint);
8584

86-
bounds.set(minDim / 5, minDim / 5, minDim - (minDim/5), minDim - (minDim/5));
85+
bounds.set(minDim / 5, minDim / 5, minDim - (minDim / 5), minDim - (minDim / 5));
8786
paint.setColor(Color.parseColor("#FFFFFF"));
8887
canvas.drawRect(bounds, paint);
8988
}
@@ -95,7 +94,7 @@ protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
9594
int height = getMeasuredHeight();
9695
int width = getMeasuredWidth();
9796
minDim = Math.min(width, height);
98-
bounds.set(minDim / 10, minDim / 10, minDim - (minDim/10), minDim - (minDim/10));
97+
bounds.set(minDim / 10, minDim / 10, minDim - (minDim / 10), minDim - (minDim / 10));
9998
tick.moveTo(minDim / 4, minDim / 2);
10099
tick.lineTo(minDim / 2.5f, minDim - (minDim / 3));
101100

‎sample/src/main/java/com/developer/filepicker/file/FileListAdapter.java‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
package com.developer.filepicker.file;
22

33
import android.content.Context;
4-
import androidx.annotation.NonNull;
5-
import androidx.recyclerview.widget.RecyclerView;
64
import android.view.LayoutInflater;
75
import android.view.View;
86
import android.view.ViewGroup;
97
import android.widget.TextView;
108

9+
import androidx.annotation.NonNull;
10+
import androidx.recyclerview.widget.RecyclerView;
11+
1112
import java.util.ArrayList;
1213

1314
class FileListAdapter extends RecyclerView.Adapter<FileListAdapter.FileListViewHolder> {
@@ -52,4 +53,4 @@ class FileListViewHolder extends RecyclerView.ViewHolder {
5253
path = itemView.findViewById(R.id.path);
5354
}
5455
}
55-
}
56+
}

0 commit comments

Comments
 (0)