Skip to content

Commit 9419d4f

Browse files
authored
Remove unnecessary (and incorrect) Zygote rule for PDBijector (#286)
* Update BijectorsZygoteExt.jl * Update BijectorsZygoteExt.jl * Update Project.toml * Update Project.toml * Update Project.toml
1 parent a41f840 commit 9419d4f

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

Project.toml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name = "Bijectors"
22
uuid = "76274a88-744f-5084-9051-94815aaf08c4"
3-
version = "0.13.5"
3+
version = "0.13.6"
44

55
[deps]
66
ArgCheck = "dce04be8-c92d-5529-be00-80e4d2c0e197"
@@ -30,6 +30,9 @@ ReverseDiff = "37e2e3b7-166d-5795-8a7a-e32c996b4267"
3030
Tracker = "9f7883ad-71c0-57eb-9f7f-b5c9e6d3789c"
3131
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
3232

33+
[extras]
34+
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
35+
3336
[extensions]
3437
BijectorsDistributionsADExt = "DistributionsAD"
3538
BijectorsForwardDiffExt = "ForwardDiff"
@@ -42,6 +45,7 @@ BijectorsZygoteExt = "Zygote"
4245
ArgCheck = "1, 2"
4346
ChainRules = "1"
4447
ChainRulesCore = "0.10.11, 1"
48+
Zygote = "0.6.63"
4549
ChangesOfVariables = "0.1"
4650
Compat = "3, 4"
4751
Distributions = "0.25.33"

ext/BijectorsZygoteExt.jl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -224,9 +224,6 @@ end
224224
end
225225
return pullback(_maximum, d)
226226
end
227-
@adjoint function lower_triangular(A::AbstractMatrix)
228-
return lower_triangular(A), Δ -> (lower_triangular(Δ),)
229-
end
230227
@adjoint function pd_from_lower(X::AbstractMatrix)
231228
return LowerTriangular(X) * LowerTriangular(X)',
232229
Δ -> begin

0 commit comments

Comments
 (0)