Fix todo on renaming 'String.subCode'

Author: ssoelvsten

lib/Hash.trp

@@ -10,15 +10,15 @@ let
      *)
     fun hashString s =
         (* String hash with fast paths for small strings *)
-        let val len     = String.size s
-            val radix   = 127
-            val subCode = String.subCode s
+        let val len    = String.size s
+            val radix  = 127
+            val codeAt = String.sub' s
         in case len of 0 => 0
-                     | 1 => subCode 0
-                     | 2 => (radix * subCode 0 + subCode 1) andb Number.maxInt32
+                     | 1 => codeAt 0
+                     | 2 => (radix * codeAt 0 + codeAt 1) andb Number.maxInt32
                      | _ => let fun go idx acc =
                                     if len <= idx then acc
-                                    else go (idx + 1) ((acc * radix + subCode idx) andb Number.maxInt32)
+                                    else go (idx + 1) ((acc * radix + codeAt idx) andb Number.maxInt32)
                             in go 0 0
                             end
         end

lib/String.trp

@@ -26,8 +26,7 @@ let val __substring = substring
 
     (** The character value at the given index. If `i` is out of bounds, then 0 (NULL) is
      *  returned. *)
-    (* TODO (#59): Rename to `sub'` when `'` symbols are properly supported. *)
-    fun subCode s i = charCodeAtWithDefault (s, i, 0)
+    fun sub' s i = charCodeAtWithDefault (s, i, 0)
 
     (** Returns the substring of `s`. Indices beyond the end of string are silently truncated. *)
     fun substring s i j = __substring (s, i, j)
@@ -76,7 +75,7 @@ let val __substring = substring
         maxSize,
         size,
         sub,
-        subCode,
+        sub',
         substring,
         concat,
         concatWith,

tests/lib/String.golden

@@ -16,7 +16,7 @@
       [ TEST ] it is ''  for 5      [ PASS ] it is ''  for 5
       [ TEST ] it is ''  for 6      [ PASS ] it is ''  for 6
   end 
-  begin subCode
+  begin sub'
       [ TEST ] it is 87 for 0      [ PASS ] it is 87 for 0
       [ TEST ] it is 111 for 1      [ PASS ] it is 111 for 1
       [ TEST ] it is 114 for 2      [ PASS ] it is 114 for 2

tests/lib/String.trp

@@ -21,14 +21,14 @@ let val tests = Unit.group "String" [
                 ]
             end,
             let val s = "World!"
-            in Unit.group "subCode" [
-                    Unit.it "is 87 for 0"  (Unit.isEq 87  (String.subCode s 0))
-                  , Unit.it "is 111 for 1" (Unit.isEq 111 (String.subCode s 1))
-                  , Unit.it "is 114 for 2" (Unit.isEq 114 (String.subCode s 2))
-                  , Unit.it "is 108 for 3" (Unit.isEq 108 (String.subCode s 3))
-                  , Unit.it "is 100 for 4" (Unit.isEq 100 (String.subCode s 4))
-                  , Unit.it "is 33  for 5" (Unit.isEq 33  (String.subCode s 5))
-                  , Unit.it "is 0   for 6" (Unit.isEq 0   (String.subCode s 6))
+            in Unit.group "sub'" [
+                    Unit.it "is 87 for 0"  (Unit.isEq 87  (String.sub' s 0))
+                  , Unit.it "is 111 for 1" (Unit.isEq 111 (String.sub' s 1))
+                  , Unit.it "is 114 for 2" (Unit.isEq 114 (String.sub' s 2))
+                  , Unit.it "is 108 for 3" (Unit.isEq 108 (String.sub' s 3))
+                  , Unit.it "is 100 for 4" (Unit.isEq 100 (String.sub' s 4))
+                  , Unit.it "is 33  for 5" (Unit.isEq 33  (String.sub' s 5))
+                  , Unit.it "is 0   for 6" (Unit.isEq 0   (String.sub' s 6))
                 ]
             end,
             let val s = "Hello Troupe!"