Fix #48 - Created rule G-2135: Avoid assigning values to local variables that are not used by a subsequent statement.

Author: kibeha

docs/4-language-usage/2-variables-and-types/1-general/g-2135.md

@@ -0,0 +1,56 @@
+# G-2135: Avoid assigning values to local variables that are not used by a subsequent statement.
+
+!!! warning "Major"
+    Efficiency, Maintainability, Testability
+
+## Reason
+
+Expending resources calculating and assigning values to a local variable and never use the value subsequently is at best a waste, at worst indicative of a mistake that leads to a bug.
+
+## Example (bad)
+
+``` sql
+create or replace package body my_package is
+   procedure my_proc is
+      co_employee_id constant employees.employee_id%type := 1042;
+      l_last_name  employees.last_name%type;
+      l_message    varchar2(100 char);
+   begin
+      select emp.last_name
+        into l_last_name
+        from employees emp
+       where emp.employee_id = co_employee_id;
+
+      l_message := 'Hello, ' || l_last_name;
+   exception
+      when no_data_found then null; -- handle_no_data_found;
+      when too_many_rows then null; -- handle_too_many_rows;
+   end my_proc;
+end my_package;
+/
+```
+
+## Example (good)
+
+``` sql
+create or replace package body my_package is
+   procedure my_proc is
+      co_employee_id constant employees.employee_id%type := 1042;
+      l_last_name  employees.last_name%type;
+      l_message    varchar2(100 char);
+   begin
+      select emp.last_name
+        into l_last_name
+        from employees emp
+       where emp.employee_id = co_employee_id;
+
+      l_message := 'Hello, ' || l_last_name;
+
+      message_api.send_message(l_message);
+   exception
+      when no_data_found then null; -- handle_no_data_found;
+      when too_many_rows then null; -- handle_too_many_rows;
+   end my_proc;
+end my_package;
+/
+```

docs/4-language-usage/7-stored-objects/3-procedures/g-7330.md

@@ -15,7 +15,7 @@ create or replace package body my_package is
       in_name      in  varchar2
     , out_greeting out varchar2
    ) is
-      l_message varchar2(100);
+      l_message varchar2(100 char);
    begin
       l_message := 'Hello, ' || in_name;
    end my_procedure;