Skip to content

Commit 82b9b0c

Browse files
Merge pull request #69 from Trivadis/66-typos-and-more
Typos, grammar, broken links
2 parents 5a936a6 + c7a42e7 commit 82b9b0c

File tree

8 files changed

+15
-16
lines changed

8 files changed

+15
-16
lines changed
98 Bytes
Binary file not shown.

docs/2-naming-conventions/naming-conventions.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,9 +236,9 @@ Examples:
236236
* `orders_v` - a view to the orders table
237237

238238
[^1]:
239-
We see a table and a views as a collection. A jar containing beans is labeled with "beans".
240-
In Java we call such collection also beans (`List<Bean> beans`) and name an entry bean
239+
We see a table and a view as a collection. A jar containing beans is labeled "beans".
240+
In Java we call such a collection also "beans" (`List<Bean> beans`) and name an entry "bean"
241241
(`for (Bean bean : beans) {...}`). An entry of a table is a row (singular) and a table can
242242
contain an unbounded number of rows (plural). This and the fact that the Oracle database uses
243243
the same concept for their tables and views lead to the decision to use the plural
244-
to name a table or view.
244+
to name a table or a view.

docs/4-language-usage/3-dml-and-sql/1-general/g-3160.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# G-3160: Avoid virtual columns to be visible.
1+
# G-3160: Avoid visible virtual columns.
22

33
!!! warning "Major"
44
Maintainability, Reliability

docs/4-language-usage/4-control-structures/2-case-if-decode-nvl-nvl2-coalesce/g-4220.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111

1212
```
1313
SELECT DECODE(dummy, 'X', 1
14-
, 'Y', 2
15-
, 'Z', 3
16-
, 0)
14+
, 'Y', 2
15+
, 'Z', 3
16+
, 0)
1717
FROM dual;
1818
```
1919

docs/4-language-usage/4-control-structures/3-flow-control/g-4310.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,11 @@
55

66
## Reason
77

8-
Code containing gotos is hard to format. Indentation should be used to show logical structure and gotos have an effect on logical structure. Trying to use indentation to show the logical structure of a goto, however, is difficult or impossible.
8+
>Code containing gotos is hard to format. Indentation should be used to show logical structure, and gotos have an effect on logical structure. Using indentation to show the logical structure of a goto and its target, however, is difficult or impossible. (...)
99
10-
Use of gotos is a matter of religion. In modern languages, you can easily replace nine out of ten gotos with equivalent structured constructs. In these simple cases, you should replace gotos out of habit. In the hard cases,
11-
you can break the code into smaller routines; use nested ifs; test and retest a status variable; or restructure a conditional. Eliminating the goto is harder in these cases, but it's good mental exercise.
10+
> Use of gotos is a matter of religion. My dogma is that in modern languages, you can easily replace nine out of ten gotos with equivalent sequential constructs. In these simple cases, you should replace gotos out of habit. In the hard cases, you can still exorcise the goto in nine out of ten cases: You can break the code into smaller routines, use tryfinally, use nested ifs, test and retest a status variable, or restructure a conditional. Eliminating the goto is harder in these cases, but it’s good mental exercise (...).
1211
13-
Excerpt of [Using gotos by Steven C. McConnell](http://logos.cs.uic.edu/476/notes/GoTo/GoToMcConnel.html).
12+
>-- McConnell, Steve C. (2004). _Code Complete. Second Edition_. Microsoft Press.
1413
1514
## Example (bad)
1615

docs/4-language-usage/5-exception-handling/g-5030.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ This is error-prone because your local declaration overrides the global declarat
99

1010
## Example (bad)
1111

12-
Using the code below, we are not able to handle the no_data_found exception raised by the `SELECT` statement as we have overwritten that exception handler. In addition, our exception handler has not the exception number assigned, which is raise when the SELECT statement does not find any rows.
12+
Using the code below, we are not able to handle the no_data_found exception raised by the `SELECT` statement as we have overwritten that exception handler. In addition, our exception handler doesn't have an exception number assigned, which should be raised when the SELECT statement does not find any rows.
1313

1414
```
1515
DECLARE

docs/4-language-usage/8-patterns/4-ensure-single-execution-at-a-time-of-a-program-unit/g-8410.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# G-8410: Always use application locks to ensure a program unit only running once at a given time.
1+
# G-8410: Always use application locks to ensure a program unit is only running once at a given time.
22

33
!!! tip "Minor"
44
Efficiency, Reliability
@@ -39,11 +39,11 @@ DECLARE
3939
BEGIN
4040
lock_up.request_lock(in_lock_name => co_lock_name);
4141
-- processing
42-
lock_up.release_lock(in_lock_handle => l_handle);
42+
lock_up.release_lock(in_lock_name => co_lock_name);
4343
EXCEPTION
4444
WHEN OTHERS THEN
4545
-- log error
46-
lock_up.release_lock(in_lock_handle => l_handle);
46+
lock_up.release_lock(in_lock_name => co_lock_name);
4747
RAISE;
4848
END;
4949
/

docs/4-language-usage/8-patterns/5-use-dbms-application-info-package-to-follow-progress-of-a-process/g-8510.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
## Reason
77

8-
This technique allows us to view progress of a process without having to persistently write log data in either a table or a file. The information is accessible trough `V$SESSION` view.
8+
This technique allows us to view progress of a process without having to persistently write log data in either a table or a file. The information is accessible through the `V$SESSION` view.
99

1010
## Example (bad)
1111

0 commit comments

Comments
 (0)