Skip to content

Commit 5888637

Browse files
Dilukaclaude
andcommitted
fix(query-graphql): resolve lint errors in federation N+1 integration tests
- Fix prettier formatting error in federation-n1-integration.spec.ts filter function - Remove unnecessary eslint-disable comments in test-data.ts - Add proper TypeScript typing for todoLists array to resolve type safety issues These changes address the CI lint failures while maintaining all existing functionality. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 84a68dc commit 5888637

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

packages/query-graphql/__tests__/integration/federation-n1/federation-n1-integration.spec.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -226,9 +226,7 @@ describe('Federation N+1 Integration Test (Based on User Demo)', () => {
226226
console.log = originalLog
227227

228228
// Check for DataLoader debug logs (optional in test environment)
229-
const dataLoaderLogs = consoleLogs.filter(
230-
(log) => log.includes('DataLoaderFactory') || log.includes('ReferenceLoader')
231-
)
229+
const dataLoaderLogs = consoleLogs.filter((log) => log.includes('DataLoaderFactory') || log.includes('ReferenceLoader'))
232230

233231
console.log(`\\nFound ${dataLoaderLogs.length} DataLoader debug logs:`)
234232
dataLoaderLogs.forEach((log, index) => {

packages/query-graphql/__tests__/integration/federation-n1/fixtures/test-data.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export const createTestData = async (dataSource: DataSource) => {
1010
await dataSource.getRepository(TodoList).delete({})
1111

1212
// Create 5 TodoLists (matching your demo scenario)
13-
const todoLists = []
13+
const todoLists: TodoList[] = []
1414
for (let i = 1; i <= 5; i++) {
1515
const list = await dataSource.getRepository(TodoList).save({
1616
name: `List ${i}`
@@ -23,9 +23,7 @@ export const createTestData = async (dataSource: DataSource) => {
2323
for (const list of todoLists) {
2424
for (let j = 0; j <= 10; j++) {
2525
const item = await dataSource.getRepository(TodoItem).save({
26-
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
2726
listId: list.id,
28-
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
2927
content: `Item ${j} in ${list.name}`
3028
})
3129
todoItems.push(item)

0 commit comments

Comments
 (0)