Skip to content

Commit 288d76f

Browse files
Dilukaclaude
andcommitted
fix: resolve TypeScript compilation error in reference loader
Fix type assertion issue in reference.loader.ts where Filter<DTO> type didn't allow 'id' property. Use double type assertion through unknown to resolve compatibility issue. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent d01f54b commit 288d76f

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

packages/query-graphql/__tests__/resolvers/reference.resolver.spec.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ describe('ReferenceResolver', () => {
4444
id,
4545
stringField: 'foo'
4646
}
47-
47+
4848
when(mockService.query(anything())).thenResolve([output])
49-
49+
5050
// @ts-ignore
5151
// eslint-disable-next-line @typescript-eslint/no-unsafe-call,@typescript-eslint/naming-convention
5252
const result = await resolver.resolveReference({ __type: 'TestReference', id }, context)
@@ -56,7 +56,7 @@ describe('ReferenceResolver', () => {
5656
it('should reject if the id is not found', async () => {
5757
const { resolver } = await createResolverFromNest(TestResolver)
5858
const context = createContext()
59-
59+
6060
// @ts-ignore
6161
// eslint-disable-next-line @typescript-eslint/no-unsafe-call,@typescript-eslint/naming-convention
6262
return expect(resolver.resolveReference({ __type: 'TestReference' }, context)).rejects.toThrow(
@@ -68,9 +68,9 @@ describe('ReferenceResolver', () => {
6868
const { resolver, mockService } = await createResolverFromNest(TestResolver)
6969
const context = createContext()
7070
const id = 'id-not-found'
71-
71+
7272
when(mockService.query(anything())).thenResolve([])
73-
73+
7474
// @ts-ignore
7575
// eslint-disable-next-line @typescript-eslint/no-unsafe-call,@typescript-eslint/naming-convention
7676
return expect(resolver.resolveReference({ __type: 'TestReference', id }, context)).rejects.toThrow(

packages/query-graphql/src/loader/reference.loader.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ export class ReferenceLoader<DTO> implements NestjsQueryDataloader<DTO, Referenc
1515
const ids = args.map((arg) => arg.id)
1616

1717
// Use batch query to fetch all entities at once
18-
const filter: Filter<DTO> = { id: { in: ids } };
19-
const entities = await service.query({ filter });
18+
const filter = { id: { in: ids } } as unknown as Filter<DTO>
19+
const entities = await service.query({ filter })
2020

2121
// Create a map for fast lookup by ID
2222
const entityMap = new Map<string | number, DTO>()

0 commit comments

Comments
 (0)