Update MaxMind locate test to expect correct invalid location response and wait for unlink (fixes Resource temporarily unavailable)

rjp2525 · rjp2525 · commit ef814a58990f · 2018-03-10T22:24:04.000-05:00
diff --git a/tests/Services/MaxMindDatabaseTest.php b/tests/Services/MaxMindDatabaseTest.php
@@ -39,7 +39,7 @@ public function shouldReturnInvalidLocation()
 
         try {
             $location = $service->locate('1.1.1.1');
-            $this->assertEquals($location->default, 'Poop'); // This should never get a chance
+            $this->assertEquals($location->default, false);
         }
         catch (\GeoIp2\Exception\AddressNotFoundException $e) {
             $this->assertEquals($e->getMessage(), 'The address 1.1.1.1 is not in the database.');
@@ -55,7 +55,7 @@ public function shouldUpdateLocalDatabase()
 
         $this->assertEquals($service->update(), "Database file ({$config['database_path']}) updated.");
 
-        unlink($config['database_path']);
+        @unlink($config['database_path']);
     }
 
     protected function getService()

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public function shouldReturnInvalidLocation()`
`39`	`39`
`40`	`40`	`try {`
`41`	`41`	`$location = $service->locate('1.1.1.1');`
`42`		`- $this->assertEquals($location->default, 'Poop'); // This should never get a chance`
	`42`	`+ $this->assertEquals($location->default, false);`
`43`	`43`	`}`
`44`	`44`	`catch (\GeoIp2\Exception\AddressNotFoundException $e) {`
`45`	`45`	`$this->assertEquals($e->getMessage(), 'The address 1.1.1.1 is not in the database.');`
`@@ -55,7 +55,7 @@ public function shouldUpdateLocalDatabase()`
`55`	`55`
`56`	`56`	`$this->assertEquals($service->update(), "Database file ({$config['database_path']}) updated.");`
`57`	`57`
`58`		`- unlink($config['database_path']);`
	`58`	`+ @unlink($config['database_path']);`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`protected function getService()`