change to getFirst() and getLast() (#1127)

* change to getFirst() and getLast()

* run spotlessApply

* fix code smell

* remove star import

* run spotlessApply

* change extra get()

Author: nefelhhh

application/src/main/java/org/togetherjava/tjbot/features/bookmarks/BookmarksListRemoveHandler.java

@@ -314,7 +314,7 @@ Request withSelectedBookmarksToRemove(Set<Long> selectedBookmarkIdsToRemove) {
         }
 
         static Request fromArgs(List<String> args) {
-            RequestType requestType = RequestType.valueOf(args.get(0));
+            RequestType requestType = RequestType.valueOf(args.getFirst());
             String componentName = args.get(1);
             int currentPageIndex = Integer.parseInt(args.get(2));
 

application/src/main/java/org/togetherjava/tjbot/features/code/CodeMessageHandler.java

@@ -152,7 +152,7 @@ private Button createButtonForAction(CodeAction action, long originalMessageId)
 
     @Override
     public void onButtonClick(ButtonInteractionEvent event, List<String> args) {
-        long originalMessageId = Long.parseLong(args.get(0));
+        long originalMessageId = Long.parseLong(args.getFirst());
 
         event.deferEdit().queue();
 

application/src/main/java/org/togetherjava/tjbot/features/filesharing/FileSharingMessageListener.java

@@ -98,7 +98,7 @@ public void onMessageReceived(MessageReceivedEvent event) {
     @Override
     public void onButtonClick(ButtonInteractionEvent event, List<String> args) {
         Member interactionUser = event.getMember();
-        String gistAuthorId = args.get(0);
+        String gistAuthorId = args.getFirst();
         boolean hasSoftModPermissions =
                 interactionUser.getRoles().stream().map(Role::getName).anyMatch(isSoftModRole);
 

application/src/main/java/org/togetherjava/tjbot/features/github/GitHubReference.java

@@ -120,7 +120,7 @@ public void onMessageReceived(MessageReceivedEvent event) {
         List<MessageEmbed> embeds = new ArrayList<>();
 
         while (matcher.find()) {
-            long defaultRepoId = config.getGitHubRepositories().get(0);
+            long defaultRepoId = config.getGitHubRepositories().getFirst();
 
             int issueId = Integer.parseInt(matcher.group(ID_GROUP));
             findIssue(issueId, defaultRepoId).ifPresent(issue -> embeds.add(generateReply(issue)));

application/src/main/java/org/togetherjava/tjbot/features/help/HelpSystemHelper.java

@@ -337,7 +337,7 @@ private static ForumTag requireTag(String tagName, ForumChannel forumChannel) {
                 .formatted(forumChannel.getName(), forumChannel.getGuild().getName(), tagName));
         }
 
-        return matchingTags.get(0);
+        return matchingTags.getFirst();
     }
 
     boolean hasTagManageRole(Member member) {

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCommand.java

@@ -25,6 +25,7 @@
 import java.time.temporal.ChronoUnit;
 import java.util.Arrays;
 import java.util.EnumMap;
+import java.util.List;
 import java.util.Locale;
 import java.util.Map;
 import java.util.Objects;
@@ -213,7 +214,7 @@ private void resetActivity(SlashCommandInteractionEvent event, ThreadChannel hel
 
         helpThread.getHistory()
             .retrievePast(1)
-            .map(messages -> messages.get(0))
+            .map(List::getFirst)
             .queue(lastMessage -> manuallyResetChannelActivityCache.put(helpThread.getIdLong(),
                     lastMessage.getIdLong()));
 

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadCreatedListener.java

@@ -179,7 +179,7 @@ private boolean isPostAuthor(Member interactionUser, Message message) {
         }
 
         String embedAuthor = Objects
-            .requireNonNull(message.getEmbeds().get(0).getAuthor(),
+            .requireNonNull(message.getEmbeds().getFirst().getAuthor(),
                     "embed author for forum post is null")
             .getName();
 

application/src/main/java/org/togetherjava/tjbot/features/jshell/renderer/RendererUtils.java

@@ -59,8 +59,7 @@ static GeneralStatus getGeneralStatus(JShellResult result) {
             return GeneralStatus.PARTIAL_SUCCESS; // At least one snippet is a success
         }
 
-        return getGeneralStatus(
-                result.snippetsResults().get(result.snippetsResults().size() - 1).status());
+        return getGeneralStatus(result.snippetsResults().getLast().status());
     }
 
     static Color getStatusColor(JShellResult result) {

application/src/main/java/org/togetherjava/tjbot/features/mathcommands/TeXCommand.java

@@ -164,7 +164,7 @@ private boolean isInvalidInlineFormat(String latex) {
 
     @Override
     public void onButtonClick(final ButtonInteractionEvent event, final List<String> args) {
-        if (!args.get(0).equals(Objects.requireNonNull(event.getMember()).getId())) {
+        if (!args.getFirst().equals(Objects.requireNonNull(event.getMember()).getId())) {
             event.reply("You are not the person who executed the command, you cannot do that")
                 .setEphemeral(true)
                 .queue();

application/src/main/java/org/togetherjava/tjbot/features/moderation/ReportCommand.java

@@ -223,7 +223,7 @@ private static String createUserReply(Result<Message> result) {
     private record ReportedMessage(String content, String id, String jumpUrl, String channelID,
             Instant timestamp, String authorName, String authorAvatarUrl) {
         static ReportedMessage ofArgs(List<String> args) {
-            String content = args.get(0);
+            String content = args.getFirst();
             String id = args.get(1);
             String jumpUrl = args.get(2);
             String channelID = args.get(3);