refactor: make consants more verbose and precise

Rename `VALUE_DELIMITER` to `OPTION_PARAM_ID_DELIMITER` and `ARG_COUNT`
to `OPTIONS_PER_ROLE` for better and less ambiguous naming.

The current ones do not accurately reflect what they are delimiting and
where they should be used specifically, so we use more verbose names for
that purpose.

They are constants that aren't widely used anywhere in major places,
though we should still take good care of all naming regardless for
maximum code readability.

Suggested-by: Zabuzard <zabuza.dev@gmail.com>
Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

Author: christolis

application/src/main/java/org/togetherjava/tjbot/features/roleapplication/CreateRoleApplicationCommand.java

@@ -45,8 +45,8 @@ public class CreateRoleApplicationCommand extends SlashCommandAdapter {
     protected static final Color AMBIENT_COLOR = new Color(24, 221, 136, 255);
     private static final int OPTIONAL_ROLES_AMOUNT = 5;
     private static final String ROLE_COMPONENT_ID_HEADER = "application-create";
-    private static final String VALUE_DELIMITER = "_";
-    private static final int ARG_COUNT = 3;
+    private static final String OPTION_PARAM_ID_DELIMITER = "_";
+    private static final int OPTIONS_PER_ROLE = 3;
     private static final int MINIMUM_ANSWER_LENGTH = 50;
     private static final int MAXIMUM_ANSWER_LENGTH = 500;
 
@@ -88,7 +88,7 @@ private void generateRoleOptions() {
     }
 
     private static String generateOptionId(String name, int id) {
-        return "%s%s%d".formatted(name, VALUE_DELIMITER, id);
+        return "%s%s%d".formatted(name, OPTION_PARAM_ID_DELIMITER, id);
     }
 
     @Override
@@ -190,7 +190,7 @@ private static long getIncorrectRoleArgsCount(final List<OptionMapping> args) {
 
         args.stream()
             .map(OptionMapping::getName)
-            .map(name -> name.split(VALUE_DELIMITER)[1])
+            .map(name -> name.split(OPTION_PARAM_ID_DELIMITER)[1])
             .forEach(number -> frequencyMap.merge(number, 1, Integer::sum));
 
         return frequencyMap.values().stream().filter(value -> value != 3).count();
@@ -206,7 +206,7 @@ private void addRolesToMenu(StringSelectMenu.Builder menuBuilder,
             final List<OptionMapping> args) {
         final Map<Integer, MenuRole> roles = new HashMap<>();
 
-        for (int i = 0; i < args.size(); i += ARG_COUNT) {
+        for (int i = 0; i < args.size(); i += OPTIONS_PER_ROLE) {
             OptionMapping optionTitle = args.get(i);
             OptionMapping optionDescription = args.get(i + 1);
             OptionMapping optionEmoji = args.get(i + 2);